Page MenuHomePhabricator
Create Task
Maniphest T280023

Enable bracket matching on all wikis (except enwiki)
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Deploy to all wikis that have CodeMirror enabled, except for English Wikipedia, on March 9.

Details

SubjectRepoBranchLines +/-
Enable bracket matching and improved colors by defaultmediawiki/extensions/CodeMirrormaster+4 -4
Bracket matching on all wikis except enwikioperations/mediawiki-configmaster+2 -6
Customize query in gerrit

Related Objects
Search...

Event Timeline

Lena_WMDE created this task.Apr 13 2021, 1:40 PM
Restricted Application added a project: Community-Tech. · View Herald TranscriptApr 13 2021, 1:40 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Lena_WMDE added a subtask: T273591: Enable bracket matching on more wikis.Apr 13 2021, 1:40 PM
Trialpears subscribed.May 10 2021, 11:11 PM
Izno subscribed.May 10 2021, 11:59 PM
Proc subscribed.Jul 7 2021, 3:07 PM
MusikAnimal removed a project: Community-Tech.Jul 27 2021, 11:31 PM
MusikAnimal subscribed.EditedDec 16 2021, 5:31 AM

Any update on this? It's been enabled on de.wikipedia (a large wiki) for quite some time, so I'm assuming there haven't been many complaints in the way of performance, etc. Perhaps we could enable it for all of group1, at least? I eagerly wait for it over on en.wikipedia, too :)

In my opinion, if few have complained and performance looks good, we should also change CodeMirror to ship with this feature flag on by default (same for line numbering).

Lena_WMDE moved this task from Backlog to In preparation on the WMDE-Templates-FocusArea board.Feb 23 2022, 9:21 AM
Lena_WMDE renamed this task from Enable bracket matching on all wikis to Enable bracket matching on all wikis (except enwiki).Mar 2 2022, 9:09 AM
Lena_WMDE updated the task description. (Show Details)
thiemowmde added a project: WMDE-TechWish-Sprint-2022-03-02.Mar 2 2022, 9:11 AM
thiemowmde set the point value for this task to 1.Mar 2 2022, 9:14 AM
Lena_WMDE mentioned this in T302857: Deploy first template focus-area improvements to enwiki.Mar 2 2022, 9:17 AM
Lena_WMDE moved this task from In preparation to In sprint on the WMDE-Templates-FocusArea board.
gerritbot added a comment.Mar 2 2022, 1:02 PM

Change 767499 had a related patch set uploaded (by WMDE-Fisch; author: WMDE-Fisch):

[operations/mediawiki-config@master] Bracket matching on all wikis except enwiki

https://gerrit.wikimedia.org/r/767499

gerritbot added a project: Patch-For-Review.Mar 2 2022, 1:02 PM
awight updated the task description. (Show Details)Mar 3 2022, 6:35 AM
thiemowmde assigned this task to WMDE-Fisch.Mar 3 2022, 9:30 AM
thiemowmde moved this task from Sprint Backlog to Tech Review on the WMDE-TechWish-Sprint-2022-03-02 board.
gerritbot added a comment.Mar 3 2022, 10:18 AM

Change 767736 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/CodeMirror@master] Enable bracket matching and improved colors by default

https://gerrit.wikimedia.org/r/767736

awight moved this task from Tech Review to Watching / Epic / Stalled on the WMDE-TechWish-Sprint-2022-03-02 board.Mar 4 2022, 12:48 PM
gerritbot added a comment.Mar 9 2022, 11:33 AM

Change 767499 merged by jenkins-bot:

[operations/mediawiki-config@master] Bracket matching on all wikis except enwiki

https://gerrit.wikimedia.org/r/767499

Stashbot added a comment.Mar 9 2022, 11:37 AM

Mentioned in SAL (#wikimedia-operations) [2022-03-09T11:37:01Z] <awight@deploy1002> Synchronized wmf-config/InitialiseSettings.php: Config: [[gerrit:767499|Bracket matching on all wikis except enwiki (T280023)]] (duration: 00m 49s)

WMDE-Fisch moved this task from Watching / Epic / Stalled to Demo on the WMDE-TechWish-Sprint-2022-03-02 board.Mar 9 2022, 12:14 PM
WMDE-Fisch closed this task as Resolved.Mar 15 2022, 9:21 AM
WMDE-Fisch moved this task from Demo to Done on the WMDE-TechWish-Sprint-2022-03-02 board.
Lena_WMDE added a parent task: T302857: Deploy first template focus-area improvements to enwiki.Mar 15 2022, 10:19 AM
gerritbot added a comment.Mar 24 2022, 3:00 PM

Change 767736 abandoned by Thiemo Kreuz (WMDE):

[mediawiki/extensions/CodeMirror@master] Enable bracket matching and improved colors by default

Reason:

https://gerrit.wikimedia.org/r/767736

Maintenance_bot removed a project: Patch-For-Review.Mar 24 2022, 3:11 PM
Izno moved this task from Backlog to Done on the MediaWiki-extensions-CodeMirror board.Mar 29 2022, 9:37 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits