Page MenuHomePhabricator
Create Task
Maniphest T280164

Stop using SkinTemplateNavigation::SpecialPage and SkinTemplateNavigation hooks in favor of SkinTemplateNavigation::Universal
Closed, ResolvedPublic3 Estimated Story Points
Actions

Description

Stop using SkinTemplateNavigation::SpecialPage and SkinTemplateNavigation hooks will be deprecated and replaced by SkinTemplateNavigation::Universal
See T255319
Looking at these hooks and the other migrations that have happened this should be an easy change.

Seemingly there is only one of these in Wikibase https://gerrit.wikimedia.org/g/mediawiki/extensions/Wikibase/+/df949038c686af9c59b1ea5d554b55c81e338b55/extension-repo.json#922
With an implementation at https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/Wikibase/+/df949038c686af9c59b1ea5d554b55c81e338b55/repo/includes/RepoHooks.php#488
(This should be double checked when picked up)

Acceptance Criteria:🏕️🌟

  • The old hooks are no longer used

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/Wikibasemaster+2 -2Migrate using SkinTemplateNavigation to SkinTemplateNavigation::Universal
Customize query in gerrit

Related Objects
Search...

Event Timeline

• Addshore created this task.Apr 14 2021, 4:39 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 14 2021, 4:39 PM
• Addshore moved this task from Inbox to To Prioritize on the wdwb-tech board.Apr 14 2021, 4:40 PM
• Addshore moved this task from To Prioritize to Triaged Low (0-50) on the wdwb-tech board.May 4 2021, 10:51 AM
• Addshore added a project: Wikidata-Campsite.May 4 2021, 10:53 AM
• Addshore moved this task from Incoming to Prioritized Wikidata Tech Backlog (prioritised from top to bottom) on the Wikidata-Campsite board.
• Addshore updated the task description. (Show Details)May 4 2021, 12:06 PM
• Addshore updated the task description. (Show Details)
• Addshore updated the task description. (Show Details)May 4 2021, 12:08 PM
• Addshore updated the task description. (Show Details)May 5 2021, 9:18 AM
• Addshore updated the task description. (Show Details)
darthmon_wmde set the point value for this task to 3.May 5 2021, 9:19 AM
darthmon_wmde moved this task from Prioritized Wikidata Tech Backlog (prioritised from top to bottom) to Wikidata-Campsite-Iteration-∞ (On Hold) on the Wikidata-Campsite board.
darthmon_wmde edited projects, added Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)); removed Wikidata-Campsite.
• Addshore moved this task from Triaged Low (0-50) to Active on the wdwb-tech board.May 5 2021, 10:04 AM
Maintenance_bot moved this task from incoming to in progress on the Wikidata board.May 5 2021, 10:15 AM
Ladsgroup claimed this task.May 11 2021, 8:20 AM
Ladsgroup moved this task from To Do (prioritised from top to bottom) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
Restricted Application added a project: User-Ladsgroup. · View Herald TranscriptMay 11 2021, 8:20 AM
gerritbot added a comment.May 11 2021, 8:30 AM

Change 688913 had a related patch set uploaded (by Ladsgroup; author: Ladsgroup):

[mediawiki/extensions/Wikibase@master] Migrate using SkinTemplateNavigation to SkinTemplateNavigation::Universal

https://gerrit.wikimedia.org/r/688913

gerritbot added a project: Patch-For-Review.May 11 2021, 8:30 AM
Ladsgroup moved this task from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.May 11 2021, 8:31 AM
Maintenance_bot moved this task from Incoming to In progress on the User-Ladsgroup board.May 11 2021, 9:15 AM
gerritbot added a comment.May 11 2021, 10:12 AM

Change 688913 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Migrate using SkinTemplateNavigation to SkinTemplateNavigation::Universal

https://gerrit.wikimedia.org/r/688913

Ladsgroup moved this task from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.May 11 2021, 10:17 AM
Maintenance_bot removed a project: Patch-For-Review.May 11 2021, 11:10 AM
ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.6; 2021-05-18).May 11 2021, 5:00 PM
• Addshore closed this task as Resolved.May 12 2021, 10:07 AM

Looks good to me!
https://codesearch.wmcloud.org/extensions/?q=SkinTemplateNavigation&i=nope&files=&excludeFiles=&repos=Extension:Wikibase

Maintenance_bot moved this task from Test (Verification) to Done on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.May 12 2021, 10:15 AM
Lucas_Werkmeister_WMDE added a subscriber: Lucas_Werkmeister_WMDE.Wed, Jun 8, 10:01 AM

(We missed the one in EntitySchema at the time, which will now be handled in T255319.)

Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL