Page MenuHomePhabricator
Create Task
Maniphest T282069

Flow: PHP Notice: Trying to get property [...] of non-object
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

On wikidata wmf.4 logstash reported three very similar errors. I checked enabling Structured Discussion on wikidata - seems to be ok.

Error
normalized_message
[{reqId}] {exception_url}   PHP Notice: Trying to get property 'wt' of non-object
exception.trace
from /srv/mediawiki/php-1.37.0-wmf.4/extensions/Flow/includes/Import/TemplateHelper.php(49)
#0 /srv/mediawiki/php-1.37.0-wmf.4/extensions/Flow/includes/Import/TemplateHelper.php(49): MWExceptionHandler::handleError(integer, string, string, integer, array)
#1 /srv/mediawiki/php-1.37.0-wmf.4/extensions/Flow/includes/Import/TemplateHelper.php(27): Flow\Import\TemplateHelper::getTemplateName(string)
#2 /srv/mediawiki/php-1.37.0-wmf.4/extensions/Flow/includes/Import/OptInController.php(593): Flow\Import\TemplateHelper::removeFromHtml(string, string)
#3 /srv/mediawiki/php-1.37.0-wmf.4/extensions/Flow/includes/Import/OptInController.php(188): Flow\Import\OptInController->removeArchiveTemplateFromWikitextTalkpage(Title)
#4 /srv/mediawiki/php-1.37.0-wmf.4/extensions/Flow/includes/Import/OptInController.php(120): Flow\Import\OptInController->disable(Title)
#5 /srv/mediawiki/php-1.37.0-wmf.4/includes/deferred/MWCallableUpdate.php(38): Flow\Import\OptInController->Flow\Import\{closure}()
#6 /srv/mediawiki/php-1.37.0-wmf.4/includes/deferred/DeferredUpdates.php(513): MWCallableUpdate->doUpdate()
#7 /srv/mediawiki/php-1.37.0-wmf.4/includes/deferred/DeferredUpdates.php(390): DeferredUpdates::attemptUpdate(MWCallableUpdate, Wikimedia\Rdbms\LBFactoryMulti)
#8 /srv/mediawiki/php-1.37.0-wmf.4/includes/deferred/DeferredUpdates.php(221): DeferredUpdates::run(MWCallableUpdate, Wikimedia\Rdbms\LBFactoryMulti, Monolog\Logger, BufferingStatsdDataFactory, string)
#9 /srv/mediawiki/php-1.37.0-wmf.4/includes/deferred/DeferredUpdatesScope.php(267): DeferredUpdates::{closure}(MWCallableUpdate, integer)
#10 /srv/mediawiki/php-1.37.0-wmf.4/includes/deferred/DeferredUpdatesScope.php(196): DeferredUpdatesScope->processStageQueue(integer, integer, Closure)
#11 /srv/mediawiki/php-1.37.0-wmf.4/includes/deferred/DeferredUpdates.php(242): DeferredUpdatesScope->processUpdates(integer, Closure)
#12 /srv/mediawiki/php-1.37.0-wmf.4/includes/MediaWiki.php(1127): DeferredUpdates::doUpdates(string)
#13 /srv/mediawiki/php-1.37.0-wmf.4/includes/MediaWiki.php(837): MediaWiki->restInPeace()
#14 /srv/mediawiki/php-1.37.0-wmf.4/includes/MediaWiki.php(575): MediaWiki->doPostOutputShutdown()
#15 /srv/mediawiki/php-1.37.0-wmf.4/index.php(53): MediaWiki->run()
#16 /srv/mediawiki/php-1.37.0-wmf.4/index.php(46): wfIndexMain()
#17 /srv/mediawiki/w/index.php(3): require(string)
#18 {main}
Error
normalized_message
[{reqId}] {exception_url}   PHP Notice: Trying to get property 'template' of non-object
exception.trace
from /srv/mediawiki/php-1.37.0-wmf.4/extensions/Flow/includes/Import/TemplateHelper.php(49)
#0 /srv/mediawiki/php-1.37.0-wmf.4/extensions/Flow/includes/Import/TemplateHelper.php(49): MWExceptionHandler::handleError(integer, string, string, integer, array)
#1 /srv/mediawiki/php-1.37.0-wmf.4/extensions/Flow/includes/Import/TemplateHelper.php(27): Flow\Import\TemplateHelper::getTemplateName(string)
#2 /srv/mediawiki/php-1.37.0-wmf.4/extensions/Flow/includes/Import/OptInController.php(593): Flow\Import\TemplateHelper::removeFromHtml(string, string)
#3 /srv/mediawiki/php-1.37.0-wmf.4/extensions/Flow/includes/Import/OptInController.php(188): Flow\Import\OptInController->removeArchiveTemplateFromWikitextTalkpage(Title)
#4 /srv/mediawiki/php-1.37.0-wmf.4/extensions/Flow/includes/Import/OptInController.php(120): Flow\Import\OptInController->disable(Title)
#5 /srv/mediawiki/php-1.37.0-wmf.4/includes/deferred/MWCallableUpdate.php(38): Flow\Import\OptInController->Flow\Import\{closure}()
#6 /srv/mediawiki/php-1.37.0-wmf.4/includes/deferred/DeferredUpdates.php(513): MWCallableUpdate->doUpdate()
#7 /srv/mediawiki/php-1.37.0-wmf.4/includes/deferred/DeferredUpdates.php(390): DeferredUpdates::attemptUpdate(MWCallableUpdate, Wikimedia\Rdbms\LBFactoryMulti)
#8 /srv/mediawiki/php-1.37.0-wmf.4/includes/deferred/DeferredUpdates.php(221): DeferredUpdates::run(MWCallableUpdate, Wikimedia\Rdbms\LBFactoryMulti, Monolog\Logger, BufferingStatsdDataFactory, string)
#9 /srv/mediawiki/php-1.37.0-wmf.4/includes/deferred/DeferredUpdatesScope.php(267): DeferredUpdates::{closure}(MWCallableUpdate, integer)
#10 /srv/mediawiki/php-1.37.0-wmf.4/includes/deferred/DeferredUpdatesScope.php(196): DeferredUpdatesScope->processStageQueue(integer, integer, Closure)
#11 /srv/mediawiki/php-1.37.0-wmf.4/includes/deferred/DeferredUpdates.php(242): DeferredUpdatesScope->processUpdates(integer, Closure)
#12 /srv/mediawiki/php-1.37.0-wmf.4/includes/MediaWiki.php(1127): DeferredUpdates::doUpdates(string)
#13 /srv/mediawiki/php-1.37.0-wmf.4/includes/MediaWiki.php(837): MediaWiki->restInPeace()
#14 /srv/mediawiki/php-1.37.0-wmf.4/includes/MediaWiki.php(575): MediaWiki->doPostOutputShutdown()
#15 /srv/mediawiki/php-1.37.0-wmf.4/index.php(53): MediaWiki->run()
#16 /srv/mediawiki/php-1.37.0-wmf.4/index.php(46): wfIndexMain()
#17 /srv/mediawiki/w/index.php(3): require(string)
#18 {main}
Error
normalized_message
[{reqId}] {exception_url}   PHP Notice: Trying to get property 'target' of non-object
exception.trace
from /srv/mediawiki/php-1.37.0-wmf.4/extensions/Flow/includes/Import/TemplateHelper.php(49)
#0 /srv/mediawiki/php-1.37.0-wmf.4/extensions/Flow/includes/Import/TemplateHelper.php(49): MWExceptionHandler::handleError(integer, string, string, integer, array)
#1 /srv/mediawiki/php-1.37.0-wmf.4/extensions/Flow/includes/Import/TemplateHelper.php(27): Flow\Import\TemplateHelper::getTemplateName(string)
#2 /srv/mediawiki/php-1.37.0-wmf.4/extensions/Flow/includes/Import/OptInController.php(593): Flow\Import\TemplateHelper::removeFromHtml(string, string)
#3 /srv/mediawiki/php-1.37.0-wmf.4/extensions/Flow/includes/Import/OptInController.php(188): Flow\Import\OptInController->removeArchiveTemplateFromWikitextTalkpage(Title)
#4 /srv/mediawiki/php-1.37.0-wmf.4/extensions/Flow/includes/Import/OptInController.php(120): Flow\Import\OptInController->disable(Title)
#5 /srv/mediawiki/php-1.37.0-wmf.4/includes/deferred/MWCallableUpdate.php(38): Flow\Import\OptInController->Flow\Import\{closure}()
#6 /srv/mediawiki/php-1.37.0-wmf.4/includes/deferred/DeferredUpdates.php(513): MWCallableUpdate->doUpdate()
#7 /srv/mediawiki/php-1.37.0-wmf.4/includes/deferred/DeferredUpdates.php(390): DeferredUpdates::attemptUpdate(MWCallableUpdate, Wikimedia\Rdbms\LBFactoryMulti)
#8 /srv/mediawiki/php-1.37.0-wmf.4/includes/deferred/DeferredUpdates.php(221): DeferredUpdates::run(MWCallableUpdate, Wikimedia\Rdbms\LBFactoryMulti, Monolog\Logger, BufferingStatsdDataFactory, string)
#9 /srv/mediawiki/php-1.37.0-wmf.4/includes/deferred/DeferredUpdatesScope.php(267): DeferredUpdates::{closure}(MWCallableUpdate, integer)
#10 /srv/mediawiki/php-1.37.0-wmf.4/includes/deferred/DeferredUpdatesScope.php(196): DeferredUpdatesScope->processStageQueue(integer, integer, Closure)
#11 /srv/mediawiki/php-1.37.0-wmf.4/includes/deferred/DeferredUpdates.php(242): DeferredUpdatesScope->processUpdates(integer, Closure)
#12 /srv/mediawiki/php-1.37.0-wmf.4/includes/MediaWiki.php(1127): DeferredUpdates::doUpdates(string)
#13 /srv/mediawiki/php-1.37.0-wmf.4/includes/MediaWiki.php(837): MediaWiki->restInPeace()
#14 /srv/mediawiki/php-1.37.0-wmf.4/includes/MediaWiki.php(575): MediaWiki->doPostOutputShutdown()
#15 /srv/mediawiki/php-1.37.0-wmf.4/index.php(53): MediaWiki->run()
#16 /srv/mediawiki/php-1.37.0-wmf.4/index.php(46): wfIndexMain()
#17 /srv/mediawiki/w/index.php(3): require(string)
#18 {main}

Details

Request URL
https://www.wikidata.org/wiki/Special:Preferences
Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Suppress notices in TemplateHelpermediawiki/extensions/Flowmaster+3 -2
Customize query in gerrit

Related Objects

Event Timeline

Etonkovidova created this task.May 6 2021, 12:17 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 6 2021, 12:17 AM
Reedy added a project: StructuredDiscussions.May 6 2021, 12:51 AM
Tgr renamed this task from PHP Notice: Trying to get property [...] of non-object to Flow: PHP Notice: Trying to get property [...] of non-object.May 6 2021, 11:49 AM
kostajh moved this task from Inbox to Needs Discussion on the Growth-Team board.May 7 2021, 7:40 AM
Krinkle moved this task from Untriaged to May 2021 on the Wikimedia-production-error board.May 12 2021, 6:30 PM
Krinkle awarded a token.
Krinkle mentioned this in Blog Post: Production Excellence #32: May 2021.Jun 21 2021, 1:31 AM
Tgr subscribed.EditedJun 29 2021, 1:44 PM

The relevant code is

$name = self::getTemplateName( $templateNode->getAttribute( 'data-mw' ) );

and then

$mwAttr = json_decode( $dataMW );
return $mwAttr->parts[0]->template->target->wt;

This is somehow related to Parsoid (which puts JSON-serialized objects into the data-mw property; the code tries to extract data from that object and fails, maybe because parts is empty). The whole code is in a try-catch block with an empty catch handler so the errors are presumably ignorable; we just need to figure out why they are not ignored (PHP Exception -> Throwable transition, maybe?). Potentially an easy fix.

• Rileych added a subscriber: DMburugu.Jul 28 2021, 7:18 PM

@DMburugu

• mewoph moved this task from Needs Discussion to Triaged on the Growth-Team board.Sep 14 2021, 9:50 PM
• mewoph subscribed.

These errors haven't occurred in the last 90 days. Lowering the priority & moving to triaged

• mewoph triaged this task as Low priority.Sep 14 2021, 9:50 PM
Aklapper added a comment.Sep 15 2021, 6:44 AM

@mewoph: If noone can reproduce an error at all anymore, is there a reason to keep its ticket open?

kostajh closed this task as Resolved.Sep 15 2021, 8:51 AM
kostajh claimed this task.
dancy reopened this task as Open.Oct 14 2021, 4:31 PM
dancy subscribed.

Saw another instance of these today.

Error
normalized_message
[{reqId}] {exception_url}   PHP Notice: Trying to get property 'target' of non-object
exception.trace
from /srv/mediawiki/php-1.38.0-wmf.4/extensions/Flow/includes/Import/TemplateHelper.php(49)
#0 /srv/mediawiki/php-1.38.0-wmf.4/extensions/Flow/includes/Import/TemplateHelper.php(49): MWExceptionHandler::handleError(integer, string, string, integer, array)
#1 /srv/mediawiki/php-1.38.0-wmf.4/extensions/Flow/includes/Import/TemplateHelper.php(27): Flow\Import\TemplateHelper::getTemplateName(string)
#2 /srv/mediawiki/php-1.38.0-wmf.4/extensions/Flow/includes/Import/OptInController.php(686): Flow\Import\TemplateHelper::removeFromHtml(string, string)
#3 /srv/mediawiki/php-1.38.0-wmf.4/extensions/Flow/includes/Import/OptInController.php(528): Flow\Import\OptInController::Flow\Import\{closure}(string)
#4 /srv/mediawiki/php-1.38.0-wmf.4/extensions/Flow/includes/Import/OptInController.php(689): Flow\Import\OptInController->editBoardDescription(Title, Closure, string)
#5 /srv/mediawiki/php-1.38.0-wmf.4/extensions/Flow/includes/Import/OptInController.php(183): Flow\Import\OptInController->archiveFlowBoard(Title)
#6 /srv/mediawiki/php-1.38.0-wmf.4/extensions/Flow/includes/Import/OptInController.php(120): Flow\Import\OptInController->disable(Title)
#7 /srv/mediawiki/php-1.38.0-wmf.4/includes/deferred/MWCallableUpdate.php(38): Flow\Import\OptInController->Flow\Import\{closure}()
#8 /srv/mediawiki/php-1.38.0-wmf.4/includes/deferred/DeferredUpdates.php(515): MWCallableUpdate->doUpdate()
#9 /srv/mediawiki/php-1.38.0-wmf.4/includes/deferred/DeferredUpdates.php(391): DeferredUpdates::attemptUpdate(MWCallableUpdate, Wikimedia\Rdbms\LBFactoryMulti)
#10 /srv/mediawiki/php-1.38.0-wmf.4/includes/deferred/DeferredUpdates.php(221): DeferredUpdates::run(MWCallableUpdate, Wikimedia\Rdbms\LBFactoryMulti, Monolog\Logger, BufferingStatsdDataFactory, string)
#11 /srv/mediawiki/php-1.38.0-wmf.4/includes/deferred/DeferredUpdatesScope.php(267): DeferredUpdates::{closure}(MWCallableUpdate, integer)
#12 /srv/mediawiki/php-1.38.0-wmf.4/includes/deferred/DeferredUpdatesScope.php(196): DeferredUpdatesScope->processStageQueue(integer, integer, Closure)
#13 /srv/mediawiki/php-1.38.0-wmf.4/includes/deferred/DeferredUpdates.php(242): DeferredUpdatesScope->processUpdates(integer, Closure)
#14 /srv/mediawiki/php-1.38.0-wmf.4/includes/MediaWiki.php(1136): DeferredUpdates::doUpdates()
#15 /srv/mediawiki/php-1.38.0-wmf.4/includes/MediaWiki.php(846): MediaWiki->restInPeace()
#16 /srv/mediawiki/php-1.38.0-wmf.4/includes/MediaWiki.php(584): MediaWiki->doPostOutputShutdown()
#17 /srv/mediawiki/php-1.38.0-wmf.4/index.php(53): MediaWiki->run()
#18 /srv/mediawiki/php-1.38.0-wmf.4/index.php(46): wfIndexMain()
#19 /srv/mediawiki/w/index.php(3): require(string)
#20 {main}
Notes

Showed up as a series of three errors, one each for "wt", "template", and "target".

Tgr edited projects, added: Growth-Team (Sprint 0 (Growth Team)); removed: Growth-Team.Oct 14 2021, 11:49 PM
Tgr moved this task from Incoming to Ready for Development on the Growth-Team (Sprint 0 (Growth Team)) board.
gerritbot added a comment.Oct 15 2021, 12:15 AM

Change 730947 had a related patch set uploaded (by Gergő Tisza; author: Gergő Tisza):

[mediawiki/extensions/Flow@master] Suppress notices in TemplateHelper

https://gerrit.wikimedia.org/r/730947

gerritbot added a project: Patch-For-Review.Oct 15 2021, 12:15 AM
Tgr claimed this task.Oct 15 2021, 12:15 AM
Tgr moved this task from Ready for Development to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.
kostajh moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Oct 18 2021, 7:31 AM
gerritbot added a comment.Oct 18 2021, 7:51 AM

Change 730947 merged by jenkins-bot:

[mediawiki/extensions/Flow@master] Suppress notices in TemplateHelper

https://gerrit.wikimedia.org/r/730947

Maintenance_bot removed a project: Patch-For-Review.Oct 18 2021, 8:11 AM
ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.5; 2021-10-19).Oct 18 2021, 3:00 PM
Etonkovidova moved this task from QA to Test in Production | Watching on the Growth-Team (Sprint 0 (Growth Team)) board.Oct 19 2021, 12:50 AM
Etonkovidova closed this task as Resolved.Oct 21 2021, 8:01 PM

Checked wmf.5 - the error(s) are not present anymore.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits