@RHo @MMiller_WMF Should we prevent the escape key from closing the recommended link toolbar dialog? Normally I would say no, both because it's inconsistent with how other VE dialogs & tools operate. But in this case, the dialog should remain open for as long as the article is in machineSuggestions mode, and further pressing escape and switching to read mode might be confusing for the user.

In T282179#7068663, @kostajh wrote:

@RHo @MMiller_WMF Should we prevent the escape key from closing the recommended link toolbar dialog? Normally I would say no, both because it's inconsistent with how other VE dialogs & tools operate. But in this case, the dialog should remain open for as long as the article is in machineSuggestions mode, and further pressing escape and switching to read mode might be confusing for the user.

hi @kostajh - I agree that the link inspector should not be closed when esc is pressed (either with or without machine suggestions reviewed). However, it seems there is no other keyboard action that allows a person to exit out of edit mode besides using the esc key, so I do think it's important to show an "are you sure you want to leave" dialog (appearing over the still open link inspector) that gives the user the option to exit or continue. We could use the standard "you are exiting the editor" dialog per the comment @MMiller_WMF made on T269653#7040330:

In T269653#7040330, @MMiller_WMF wrote:

@kostajh -- for wikis that have multiple edit tabs, yes, the "Edit source" tab should do the same thing as the edit mode toggle (show the special dialog, etc.)

But for all other ways to exit the experience (e.g. clicking "Read", clicking a left nav item, clicking the Wikipedia logo, etc.) we should hand the user the standard "you are exiting the editor" experience.

I see that in some cases, like clicking the left nav, that looks like this:

And in other cases, like clicking "Read", that looks like this:

Inheriting all of that is fine. If this sounds good, please say so and I'll add it to the task description. Or feel free to add it yourself.

@kostajh -- I think I agree (though I'm not sure which element you mean by "recommended link toolbar dialog"). I'm thinking it should try to follow how VE operates now, like:

• If the user has not not tapped "yes" or "no": esc goes right to read mode.
• If the user has tapped "yes" or "no": esc brings up an "are you sure" dialog, and another esc makes that dialog go away and the user is back with the link inspector.

Are we all saying the same thing?

In T282179#7071044, @MMiller_WMF wrote:

@kostajh -- I think I agree (though I'm not sure which element you mean by "recommended link toolbar dialog").

That's technically what the link inspector was transformed into when we did T267706: Add a link in VE: Use a permanent context instead of VE's built-in context, instead of a transient link inspector that's created & destroyed as individual links are interacted with, it's a toolbar dialog that is permanently open. In practice, it's probably OK for us to use those terms interchangeably as long as we all know that we are referring to the same thing :)

I'm thinking it should try to follow how VE operates now, like:

• If the user has not not tapped "yes" or "no": esc goes right to read mode.
• If the user has tapped "yes" or "no": esc brings up an "are you sure" dialog, and another esc makes that dialog go away and the user is back with the link inspector.

Are we all saying the same thing?

Yes, that makes sense. I'll update the task description.

Change 690754 had a related patch set uploaded (by Gergő Tisza; author: Gergő Tisza):

[mediawiki/extensions/GrowthExperiments@master] Add Link: close editor on Esc key

https://gerrit.wikimedia.org/r/690754

Change 690755 had a related patch set uploaded (by Gergő Tisza; author: Gergő Tisza):

[mediawiki/extensions/GrowthExperiments@master] Add Link: Keep focus on the link inspector dialog

https://gerrit.wikimedia.org/r/690755

Change 690754 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Add Link: close editor on Esc key

https://gerrit.wikimedia.org/r/690754

Change 690755 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Add Link: Keep focus on the link inspector dialog

https://gerrit.wikimedia.org/r/690755