Steps to reproduce:
On desktop, you'll see the post-edit dialog. On mobile, there's a console error logged indicating that ve.init.target.tryTeardown is not a promise. We need to use a different mechanism to switch to the read-only mode of the article.
This should probably be fixed in VisualEditor like it was for save (rEVEDb902b0978415: Fix ve.init.mw.MobileArticleTarget.save return value).
Change 689088 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):
[mediawiki/extensions/GrowthExperiments@master] PostEdit: Don't reset suggested edit session if task was cancelled
Change 689269 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):
[mediawiki/extensions/VisualEditor@master] Fix ve.init.mw.MobileArticleTarget.tryTeardown return value
This should be fixed in VE but given its slower release cycle that won't happen in time. IMO we should just add some quick and dirty temporary solution like
-ve.init.target.tryTeardown( true, 'navigate-read' ).then( function () { +( ve.init.target.tryTeardown( true, 'navigate-read' ) || $.Deferred().resolve() ).then( function () {
Change 689086 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):
[mediawiki/extensions/GrowthExperiments@master] PostEdit: Fix skip all suggestions on mobile, and don't reset session if task was cancelled
Change 689088 abandoned by Kosta Harlan:
[mediawiki/extensions/GrowthExperiments@master] PostEdit: Don't reset suggested edit session if task was cancelled
Reason:
squashed
Change 695038 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):
[mediawiki/extensions/GrowthExperiments@wmf/1.37.0-wmf.6] PostEdit: Fix skip all suggestions on mobile, and don't reset session if task was cancelled
Change 695039 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):
[mediawiki/extensions/GrowthExperiments@wmf/1.37.0-wmf.7] PostEdit: Fix skip all suggestions on mobile, and don't reset session if task was cancelled
Change 689086 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] PostEdit: Fix skip all suggestions on mobile, and don't reset session if task was cancelled
Change 695038 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@wmf/1.37.0-wmf.6] PostEdit: Fix skip all suggestions on mobile, and don't reset session if task was cancelled
Change 695039 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@wmf/1.37.0-wmf.7] PostEdit: Fix skip all suggestions on mobile, and don't reset session if task was cancelled
Mentioned in SAL (#wikimedia-operations) [2021-05-26T11:26:29Z] <urbanecm@deploy1002> Synchronized php-1.37.0-wmf.6/extensions/GrowthExperiments/: GrowthExperiments backports (T283544; T282899; T282546) (duration: 01m 19s)
Mentioned in SAL (#wikimedia-operations) [2021-05-26T11:27:45Z] <urbanecm@deploy1002> Synchronized php-1.37.0-wmf.7/extensions/GrowthExperiments/: GrowthExperiments backports (T283544; T282899; T282546) (duration: 01m 06s)
Change 689269 abandoned by Kosta Harlan:
[mediawiki/extensions/VisualEditor@master] Fix ve.init.mw.MobileArticleTarget.tryTeardown return value
Reason: