Page MenuHomePhabricator
Create Task
Maniphest T283544

Add a link: both "Yes" and "No" can be selected
Closed, ResolvedPublicBUG REPORT
Actions

Description

In the screenshot below, I have selected both the "Yes" and "No" options in Test Wikipedia. @Dyolf77_WMF also produced this in arwiki. I did this by first selecting "No", and then clicking "Yes".

image.png (601×1 px, 326 KB)

Details

SubjectRepoBranchLines +/-
Add a link: update button states after acceptance changesmediawiki/extensions/GrowthExperimentswmf/1.37.0-wmf.6+2 -3
Add a link: update button states after acceptance changesmediawiki/extensions/GrowthExperimentswmf/1.37.0-wmf.7+2 -3
Add a link: update button states after acceptance changesmediawiki/extensions/GrowthExperimentsmaster+2 -3
Customize query in gerrit

Related Objects
Search...

Event Timeline

MMiller_WMF created this task.May 24 2021, 9:29 PM
Frostly subscribed.May 24 2021, 9:31 PM

Can repro.

• mewoph claimed this task.May 24 2021, 10:37 PM
• mewoph moved this task from Incoming to In Progress on the Growth-Team (Sprint 0 (Growth Team)) board.
• mewoph moved this task from Backlog to May 24 – May 28 on the Add-Link board.
gerritbot added a comment.May 24 2021, 10:57 PM

Change 693975 had a related patch set uploaded (by MewOphaswongse; author: MewOphaswongse):

[mediawiki/extensions/GrowthExperiments@master] Add a link: update button states after acceptance changes

https://gerrit.wikimedia.org/r/693975

gerritbot added a project: Patch-For-Review.May 24 2021, 10:57 PM
• mewoph added a comment.May 24 2021, 11:04 PM

With latest changes:

addlink_toggle.gif (1×2 px, 3 MB)

• mewoph moved this task from In Progress to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.May 24 2021, 11:04 PM
Tgr moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.May 25 2021, 8:07 PM
gerritbot added a comment.May 25 2021, 8:23 PM

Change 693975 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Add a link: update button states after acceptance changes

https://gerrit.wikimedia.org/r/693975

Maintenance_bot removed a project: Patch-For-Review.May 25 2021, 9:10 PM
Etonkovidova moved this task from QA to Test in Production | Watching on the Growth-Team (Sprint 0 (Growth Team)) board.May 25 2021, 9:23 PM
gerritbot added a comment.May 26 2021, 8:02 AM

Change 695031 had a related patch set uploaded (by Kosta Harlan; author: MewOphaswongse):

[mediawiki/extensions/GrowthExperiments@wmf/1.37.0-wmf.7] Add a link: update button states after acceptance changes

https://gerrit.wikimedia.org/r/695031

gerritbot added a project: Patch-For-Review.May 26 2021, 8:02 AM

Change 695032 had a related patch set uploaded (by Kosta Harlan; author: MewOphaswongse):

[mediawiki/extensions/GrowthExperiments@wmf/1.37.0-wmf.6] Add a link: update button states after acceptance changes

https://gerrit.wikimedia.org/r/695032

kostajh triaged this task as Medium priority.May 26 2021, 8:37 AM
kostajh moved this task from May 24 – May 28 to Done / QA on the Add-Link board.
gerritbot added a comment.May 26 2021, 11:12 AM

Change 695031 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@wmf/1.37.0-wmf.7] Add a link: update button states after acceptance changes

https://gerrit.wikimedia.org/r/695031

gerritbot added a comment.May 26 2021, 11:15 AM

Change 695032 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@wmf/1.37.0-wmf.6] Add a link: update button states after acceptance changes

https://gerrit.wikimedia.org/r/695032

Stashbot added a comment.May 26 2021, 11:26 AM

Mentioned in SAL (#wikimedia-operations) [2021-05-26T11:26:29Z] <urbanecm@deploy1002> Synchronized php-1.37.0-wmf.6/extensions/GrowthExperiments/: GrowthExperiments backports (T283544; T282899; T282546) (duration: 01m 19s)

Stashbot mentioned this in T282546: AddLink: Skipped all dialog throws exception on ve.init.target.tryTeardown.then on mobile.May 26 2021, 11:26 AM
Stashbot mentioned this in T282899: [wmf.5] Add link: Unresponsive controls when context item overlaps templates .

Mentioned in SAL (#wikimedia-operations) [2021-05-26T11:27:45Z] <urbanecm@deploy1002> Synchronized php-1.37.0-wmf.7/extensions/GrowthExperiments/: GrowthExperiments backports (T283544; T282899; T282546) (duration: 01m 06s)

Maintenance_bot removed a project: Patch-For-Review.May 26 2021, 12:11 PM
Etonkovidova closed this task as Resolved.Jun 5 2021, 9:25 PM

Checked on testwiki wmf.7.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits