Page MenuHomePhabricator

[wmf.5] Add link: Unresponsive controls when context item overlaps templates
Closed, ResolvedPublic

Description

Testing was done with ge.utils.setUserVariant( 'linkrecommendation' )
The issue is encountered on viwiki much more frequent than on other pilot wikis (bnwiki, arwiki, and cswiki).

When a context item overlaps the info template, the controls ('Next', 'Yes') cannot be clicked. The Console doesn't display any errors.
The examples

viwiki
https://vi.wikipedia.org/w/index.php?title=Treasure_(b%C3%A0i_h%C3%A1t_c%E1%BB%A7a_Bruno_Mars)&veaction=edit
There is an additional issue with displaying template properties on hover-up (should be gone when wmf.5 patches will be deployed
https://vi.wikipedia.org/w/index.php?title=Carnotaurus&veaction=edit

One instance on arwiki

Event Timeline

Etonkovidova renamed this task from [testing task] Add link: Unresponsive controls when context item overlaps templates to [wmf.5] Add link: Unresponsive controls when context item overlaps templates .May 18 2021, 12:44 AM
Etonkovidova removed Etonkovidova as the assignee of this task.
Etonkovidova triaged this task as High priority.
Etonkovidova updated the task description. (Show Details)
Etonkovidova moved this task from QA to Incoming on the Growth-Team (Current Sprint) board.
Etonkovidova added subscribers: kostajh, mewoph, Tgr, MMiller_WMF.

With Infoboxes, the entire highlighted area is not clickable, not just link inspectors (annotations also can't be clicked)

Change 693941 had a related patch set uploaded (by MewOphaswongse; author: MewOphaswongse):

[mediawiki/extensions/GrowthExperiments@master] Add a link: Hide surface highlight overlay

https://gerrit.wikimedia.org/r/693941

Same in bnwiki.
When the suggestion window is overlapping with the infobox:


Not overlapping with the infobox, but frozen. After hovering the cursor around the suggestion window, it shows the infobox's name sometimes (see the following figure); and most of the time it remains frozen, doesn't show anything.

Change 693941 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Add a link: Hide surface highlight overlay

https://gerrit.wikimedia.org/r/693941

Same in bnwiki.
When the suggestion window is overlapping with the infobox:


Not overlapping with the infobox, but frozen. After hovering the cursor around the suggestion window, it shows the infobox's name sometimes (see the following figure); and most of the time it remains frozen, doesn't show anything.

Yes, " Not overlapping with the infobox, but frozen" it was a part of the issue. The fix works in betalabs; moving to Test in Production.

Change 695033 had a related patch set uploaded (by Kosta Harlan; author: MewOphaswongse):

[mediawiki/extensions/GrowthExperiments@wmf/1.37.0-wmf.7] Add a link: Hide surface highlight overlay

https://gerrit.wikimedia.org/r/695033

Change 695034 had a related patch set uploaded (by Kosta Harlan; author: MewOphaswongse):

[mediawiki/extensions/GrowthExperiments@wmf/1.37.0-wmf.6] Add a link: Hide surface highlight overlay

https://gerrit.wikimedia.org/r/695034

Change 695033 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@wmf/1.37.0-wmf.7] Add a link: Hide surface highlight overlay

https://gerrit.wikimedia.org/r/695033

Change 695034 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@wmf/1.37.0-wmf.6] Add a link: Hide surface highlight overlay

https://gerrit.wikimedia.org/r/695034

Mentioned in SAL (#wikimedia-operations) [2021-05-26T11:26:29Z] <urbanecm@deploy1002> Synchronized php-1.37.0-wmf.6/extensions/GrowthExperiments/: GrowthExperiments backports (T283544; T282899; T282546) (duration: 01m 19s)

Mentioned in SAL (#wikimedia-operations) [2021-05-26T11:27:45Z] <urbanecm@deploy1002> Synchronized php-1.37.0-wmf.7/extensions/GrowthExperiments/: GrowthExperiments backports (T283544; T282899; T282546) (duration: 01m 06s)

Tested in betalabs and `testwiki wmf.7. The task needs a quick check on group 2 pilot wikis.

Tested in betalabs and `testwiki wmf.7. The task needs a quick check on group 2 pilot wikis.

Checked on viwiki and arwiki (wmf.7).