Page MenuHomePhabricator

[minor] Add link: user selection of Editing mode options make source editor reachable from Add link surface
Closed, DeclinedPublic

Description

The issue is minor, the scenarios below are only for users who change their option for a default editor (which can be done via the popup on some wikis).

  • it's possible to switch from Add link surface to the source editor if a user has changed the default editor option, so Add link mode is not entirely isolated.
  • in #1, "Edit source" tab flickers when a user clicks on "View history"

(1) if "Show me both editor tabs" is selected, the "Edit source" tab will be shown briefly when switching between tabs -"Edit", 'View history" and "Read"

  • when hover the cursor changes to a hand icon implying that "Edit" tab is an active link (no effect though when clicking on it)
  • from suggested Add link surface click on "View history", "Edit source" will momentarily displayed. On slow connection, it's possible to click on it.
  • when "Edit source" is clicked, an article is displayed in the source editor with the Help panel properly prompting a user to switch to VE. The switching to VE works as expected - the suggested links are displayed.

(click to animate the gif)

edit_switch.gif (729×1 px, 1 MB)

(2) if "Always give me the source editor" is selected, then clicking on "Edit" tab from Add link suggested mode will bring "Edit source" mode. The Help panel will display the suggestion to switch back to VE.

Event Timeline

Thanks for finding this, @Etonkovidova. I think we should address #1 after initial deployment and I think we should address #2 when we work on T269653: Add a link: edit mode toggle (machine suggestions & visual) also after initial deployment.

kostajh moved this task from Backlog to Post-release backlog on the Add-Link board.

Thanks for finding this, @Etonkovidova. I think we should address #1 after initial deployment and I think we should address #2 when we work on T269653: Add a link: edit mode toggle (machine suggestions & visual) also after initial deployment.

Addressing the first issue is probably going to be non-trivial, so I would propose we decline this task and roll up this work into T269653: Add a link: edit mode toggle (machine suggestions & visual).

Flicker-proof hiding of the link is only possible on the server side, but we are tracking suggested edit sessions on the client side. I'm not sure there is a good solution to #1, unless we change session criteria. #2 seems easy to fix, if we don't mind the user confusion resulting from the "Edit" button doing a different thing from what it does on other pages.