Page MenuHomePhabricator

TypeError: Argument 2 passed to UploadStash::__construct() must implement interface MediaWiki\User\UserIdentity or be null, boolean given, called in /srv/mediawiki/php-1.37.0-wmf.6/includes/upload/UploadFromStash.php on line 66
Closed, ResolvedPublicPRODUCTION ERROR

Description

Error
normalized_message
[{reqId}] {exception_url}   TypeError: Argument 2 passed to UploadStash::__construct() must implement interface MediaWiki\User\UserIdentity or be null, boolean given, called in /srv/mediawiki/php-1.37.0-wmf.6/includes/upload/UploadFromStash.php on line 66
exception.trace
from /srv/mediawiki/php-1.37.0-wmf.6/includes/upload/UploadStash.php(88)
#0 /srv/mediawiki/php-1.37.0-wmf.6/includes/upload/UploadFromStash.php(66): UploadStash->__construct(LocalRepo, boolean)
#1 /srv/mediawiki/php-1.37.0-wmf.6/includes/upload/UploadBase.php(220): UploadFromStash->__construct()
#2 /srv/mediawiki/php-1.37.0-wmf.6/includes/specials/SpecialUpload.php(127): UploadBase::createFromRequest(WebRequest)
#3 /srv/mediawiki/php-1.37.0-wmf.6/includes/specials/SpecialUpload.php(231): SpecialUpload->loadRequest()
#4 /srv/mediawiki/php-1.37.0-wmf.6/includes/specialpage/SpecialPage.php(646): SpecialUpload->execute(NULL)
#5 /srv/mediawiki/php-1.37.0-wmf.6/includes/specialpage/SpecialPageFactory.php(1390): SpecialPage->run(NULL)
#6 /srv/mediawiki/php-1.37.0-wmf.6/includes/MediaWiki.php(314): MediaWiki\SpecialPage\SpecialPageFactory->executePath(string, RequestContext)
#7 /srv/mediawiki/php-1.37.0-wmf.6/includes/MediaWiki.php(917): MediaWiki->performRequest()
#8 /srv/mediawiki/php-1.37.0-wmf.6/includes/MediaWiki.php(551): MediaWiki->main()
#9 /srv/mediawiki/php-1.37.0-wmf.6/index.php(53): MediaWiki->run()
#10 /srv/mediawiki/php-1.37.0-wmf.6/index.php(46): wfIndexMain()
#11 /srv/mediawiki/w/index.php(3): require(string)
#12 {main}
Impact

Notes

Event Timeline

Krinkle triaged this task as Unbreak Now! priority.May 19 2021, 6:49 PM
Krinkle moved this task from Untriaged to May 2021 on the Wikimedia-production-error board.

Change 692965 had a related patch set uploaded (by Ppchelko; author: Ppchelko):

[mediawiki/core@master] UploadFromStash: convert default user from false to null

https://gerrit.wikimedia.org/r/692965

Change 692965 merged by jenkins-bot:

[mediawiki/core@master] UploadFromStash: convert default user from false to null

https://gerrit.wikimedia.org/r/692965

Change 693030 had a related patch set uploaded (by Jforrester; author: Ppchelko):

[mediawiki/core@wmf/1.37.0-wmf.6] UploadFromStash: convert default user from false to null

https://gerrit.wikimedia.org/r/693030

Change 693030 merged by jenkins-bot:

[mediawiki/core@wmf/1.37.0-wmf.6] UploadFromStash: convert default user from false to null

https://gerrit.wikimedia.org/r/693030

Mentioned in SAL (#wikimedia-operations) [2021-05-20T13:52:11Z] <hashar@deploy1002> Synchronized php-1.37.0-wmf.6/includes/upload/UploadFromStash.php: UploadFromStash: convert default user from false to null - T283196 (duration: 01m 05s)

hashar added a subscriber: hashar.

I have deployed the patch and promoted group 1 wikis.

Annoymous604 lowered the priority of this task from Unbreak Now! to Lowest.Tue, May 25, 6:45 PM
Annoymous604 raised the priority of this task from Lowest to High.
Annoymous604 raised the priority of this task from High to Needs Triage.
Annoymous604 triaged this task as Unbreak Now! priority.
Annoymous604 reassigned this task from Pchelolo to D063520.
Annoymous604 lowered the priority of this task from Unbreak Now! to Lowest.
Annoymous604 raised the priority of this task from Lowest to High.
Annoymous604 raised the priority of this task from High to Unbreak Now!.
Annoymous604 lowered the priority of this task from Unbreak Now! to High.
Annoymous604 added a subscriber: D05227103.
Annoymous604 raised the priority of this task from High to Needs Triage.
Annoymous604 changed the subtype of this task from "Production Error" to "Task".
Annoymous604 edited subscribers, added: D063520; removed: D05227103, hashar, Agusbou2015 and 3 others.
Annoymous604 removed a subscriber: D063520.
Zabe assigned this task to Pchelolo.
Zabe triaged this task as Unbreak Now! priority.
Zabe added subscribers: thcipriani, hashar, Pchelolo, Agusbou2015.
Zabe added a subscriber: Aklapper.
Zppix changed the subtype of this task from "Task" to "Production Error".Tue, May 25, 6:59 PM
Zppix removed a subscriber: Pchelolo.
Zppix added subscribers: Pchelolo, Zppix.

(Unsure why it unsubscribed)

Leoyon8 changed the task status from Resolved to Declined.Wed, May 26, 5:56 AM
Leoyon8 removed Pchelolo as the assignee of this task.
Leoyon8 lowered the priority of this task from Unbreak Now! to Needs Triage.
Leoyon8 updated the task description. (Show Details)
Leoyon8 removed subscribers: Zppix, Pchelolo, Aklapper and 3 others.
Legoktm changed the task status from Declined to Resolved.Wed, May 26, 6:12 AM
Legoktm assigned this task to Pchelolo.
Legoktm triaged this task as Unbreak Now! priority.