Page MenuHomePhabricator
Create Task
Maniphest T283196

TypeError: Argument 2 passed to UploadStash::__construct() must implement interface MediaWiki\User\UserIdentity or be null, boolean given, called in /srv/mediawiki/php-1.37.0-wmf.6/includes/upload/UploadFromStash.php on line 66
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Error
normalized_message
[{reqId}] {exception_url}   TypeError: Argument 2 passed to UploadStash::__construct() must implement interface MediaWiki\User\UserIdentity or be null, boolean given, called in /srv/mediawiki/php-1.37.0-wmf.6/includes/upload/UploadFromStash.php on line 66
exception.trace
from /srv/mediawiki/php-1.37.0-wmf.6/includes/upload/UploadStash.php(88)
#0 /srv/mediawiki/php-1.37.0-wmf.6/includes/upload/UploadFromStash.php(66): UploadStash->__construct(LocalRepo, boolean)
#1 /srv/mediawiki/php-1.37.0-wmf.6/includes/upload/UploadBase.php(220): UploadFromStash->__construct()
#2 /srv/mediawiki/php-1.37.0-wmf.6/includes/specials/SpecialUpload.php(127): UploadBase::createFromRequest(WebRequest)
#3 /srv/mediawiki/php-1.37.0-wmf.6/includes/specials/SpecialUpload.php(231): SpecialUpload->loadRequest()
#4 /srv/mediawiki/php-1.37.0-wmf.6/includes/specialpage/SpecialPage.php(646): SpecialUpload->execute(NULL)
#5 /srv/mediawiki/php-1.37.0-wmf.6/includes/specialpage/SpecialPageFactory.php(1390): SpecialPage->run(NULL)
#6 /srv/mediawiki/php-1.37.0-wmf.6/includes/MediaWiki.php(314): MediaWiki\SpecialPage\SpecialPageFactory->executePath(string, RequestContext)
#7 /srv/mediawiki/php-1.37.0-wmf.6/includes/MediaWiki.php(917): MediaWiki->performRequest()
#8 /srv/mediawiki/php-1.37.0-wmf.6/includes/MediaWiki.php(551): MediaWiki->main()
#9 /srv/mediawiki/php-1.37.0-wmf.6/index.php(53): MediaWiki->run()
#10 /srv/mediawiki/php-1.37.0-wmf.6/index.php(46): wfIndexMain()
#11 /srv/mediawiki/w/index.php(3): require(string)
#12 {main}
Impact

Notes

Details

Request URL
https://commons.wikimedia.org/wiki/Special:Upload
Related Changes in Gerrit:
SubjectRepoBranchLines +/-
UploadFromStash: convert default user from false to nullmediawiki/corewmf/1.37.0-wmf.6+2 -2
UploadFromStash: convert default user from false to nullmediawiki/coremaster+2 -2
Customize query in gerrit

Related Objects
Search...

Event Timeline

thcipriani created this task.May 19 2021, 6:38 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 19 2021, 6:38 PM
Krinkle triaged this task as Unbreak Now! priority.May 19 2021, 6:49 PM
Krinkle added a parent task: T281147: 1.37.0-wmf.6 deployment blockers.
Krinkle moved this task from Untriaged to May 2021 on the Wikimedia-production-error board.
gerritbot added a comment.May 19 2021, 6:57 PM

Change 692965 had a related patch set uploaded (by Ppchelko; author: Ppchelko):

[mediawiki/core@master] UploadFromStash: convert default user from false to null

https://gerrit.wikimedia.org/r/692965

gerritbot added a project: Patch-For-Review.May 19 2021, 6:57 PM
• Pchelolo claimed this task.May 19 2021, 6:58 PM
• Pchelolo edited projects, added Platform Team Workboards (MW Expedition); removed Platform Engineering.
gerritbot added a comment.May 19 2021, 8:11 PM

Change 692965 merged by jenkins-bot:

[mediawiki/core@master] UploadFromStash: convert default user from false to null

https://gerrit.wikimedia.org/r/692965

Aklapper added a project: MediaWiki-Uploading.May 19 2021, 8:39 PM
ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.7; 2021-05-25).May 19 2021, 9:00 PM
Maintenance_bot removed a project: Patch-For-Review.May 19 2021, 9:10 PM
• Agusbou2015 subscribed.May 19 2021, 11:10 PM
gerritbot added a comment.May 20 2021, 1:35 AM

Change 693030 had a related patch set uploaded (by Jforrester; author: Ppchelko):

[mediawiki/core@wmf/1.37.0-wmf.6] UploadFromStash: convert default user from false to null

https://gerrit.wikimedia.org/r/693030

gerritbot added a project: Patch-For-Review.May 20 2021, 1:35 AM
gerritbot added a comment.May 20 2021, 1:24 PM

Change 693030 merged by jenkins-bot:

[mediawiki/core@wmf/1.37.0-wmf.6] UploadFromStash: convert default user from false to null

https://gerrit.wikimedia.org/r/693030

Stashbot added a comment.May 20 2021, 1:52 PM

Mentioned in SAL (#wikimedia-operations) [2021-05-20T13:52:11Z] <hashar@deploy1002> Synchronized php-1.37.0-wmf.6/includes/upload/UploadFromStash.php: UploadFromStash: convert default user from false to null - T283196 (duration: 01m 05s)

ReleaseTaggerBot edited projects, added MW-1.37-notes (1.37.0-wmf.6; 2021-05-18); removed MW-1.37-notes (1.37.0-wmf.7; 2021-05-25).May 20 2021, 2:00 PM
Maintenance_bot removed a project: Patch-For-Review.May 20 2021, 2:10 PM
hashar closed this task as Resolved.May 20 2021, 2:10 PM
hashar subscribed.

I have deployed the patch and promoted group 1 wikis.

• Annoymous604 lowered the priority of this task from Unbreak Now! to Lowest.May 25 2021, 6:45 PM
• Annoymous604 raised the priority of this task from Lowest to High.
• Annoymous604 raised the priority of this task from High to Needs Triage.
• Annoymous604 triaged this task as Unbreak Now! priority.
• Annoymous604 reopened this task as Open.May 25 2021, 6:51 PM
• Annoymous604 reassigned this task from • Pchelolo to D063520.
• Annoymous604 lowered the priority of this task from Unbreak Now! to Lowest.
• Annoymous604 raised the priority of this task from Lowest to High.
• Annoymous604 raised the priority of this task from High to Unbreak Now!.
• Annoymous604 lowered the priority of this task from Unbreak Now! to High.
• Annoymous604 added a subscriber: D05227103.
• Annoymous604 removed D063520 as the assignee of this task.May 25 2021, 6:54 PM
• Annoymous604 raised the priority of this task from High to Needs Triage.
• Annoymous604 changed the subtype of this task from "Production Error" to "Task".
• Annoymous604 removed projects: MW-1.37-notes (1.37.0-wmf.6; 2021-05-18), MediaWiki-Uploading, Platform Team Workboards (MW Expedition), Wikimedia-production-error.
• Annoymous604 edited subscribers, added: D063520; removed: D05227103, hashar, • Agusbou2015 and 3 others.
• Annoymous604 removed a subscriber: D063520.
Zabe closed this task as Resolved.May 25 2021, 6:57 PM
Zabe assigned this task to • Pchelolo.
Zabe triaged this task as Unbreak Now! priority.
Zabe added subscribers: thcipriani, hashar, • Pchelolo, • Agusbou2015.
Zabe added a subscriber: Aklapper.
Zppix changed the subtype of this task from "Task" to "Production Error".May 25 2021, 6:59 PM
Zppix removed a subscriber: • Pchelolo.
Zppix added subscribers: • Pchelolo, Zppix.

(Unsure why it unsubscribed)

Zabe added projects: MW-1.37-notes (1.37.0-wmf.6; 2021-05-18), MediaWiki-Uploading, Platform Team Workboards (MW Expedition), Wikimedia-production-error.May 25 2021, 7:00 PM
• Leoyon8 changed the task status from Resolved to Declined.May 26 2021, 5:56 AM
• Leoyon8 removed • Pchelolo as the assignee of this task.
• Leoyon8 lowered the priority of this task from Unbreak Now! to Needs Triage.
• Leoyon8 updated the task description. (Show Details)
• Leoyon8 edited projects, added KaiOS-Wikipedia-app (Jio2); removed Wikimedia-production-error, Platform Team Workboards (MW Expedition), MediaWiki-Uploading, MW-1.37-notes (1.37.0-wmf.6; 2021-05-18).
• Leoyon8 removed subscribers: Zppix, • Pchelolo, Aklapper and 3 others.
Legoktm changed the task status from Declined to Resolved.May 26 2021, 6:12 AM
Legoktm assigned this task to • Pchelolo.
Legoktm triaged this task as Unbreak Now! priority.
Legoktm edited projects, added Wikimedia-production-error, Platform Team Workboards (MW Expedition), MediaWiki-Uploading, MW-1.37-notes (1.37.0-wmf.6; 2021-05-18); removed KaiOS-Wikipedia-app (Jio2).
Zabe updated the task description. (Show Details)May 26 2021, 6:15 AM
Krinkle mentioned this in Blog Post: Production Excellence #32: May 2021.Jun 21 2021, 1:31 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits