1.37.0-wmf.6 deployment blockers
Closed, ResolvedPublicRelease
Actions

Assigned To

Authored By

	thcipriani
	Apr 26 2021, 3:14 PM

Details

Backup Train Conductor: dancy
Release Version: 1.37.0-wmf.6
Release Date: May 17 2021, 12:00 AM

2021 week 20 1.37-wmf.6 Changes wmf/1.37.0-wmf.6

This MediaWiki Train Deployment is scheduled for the week of Monday, May 17th:

Monday May 17th	Tuesday, May 18th	Wednesday, May 19th	Thursday, May 20th	Friday
Backports only.	Branch `wmf.6` and deploy to Group 0 Wikis.	Deploy `wmf.6` to Group 1 Wikis.	Deploy `wmf.6` to all Wikis.	No deployments on fridays

See https://wikitech.wikimedia.org/wiki/Deployments for full schedule.

How this works

Any serious bugs affecting wmf.6 should be added as subtasks beneath this one.
- Use this form to create one.
Any open subtask(s) block the train from moving forward. This means no further deployments until the blockers are resolved.
If something is serious enough to warrant a rollback then you should bring it to the attention of deployers on the #wikimedia-operations IRC channel.
If you have a risky change in this week's train add a comment to this task using the Risky patch template
For more info about deployment blockers, see Holding the train.

Other Deployments

Previous: 1.37.0-wmf.5

Next: 1.37.0-wmf.7

	Subject	Repo	Branch	Lines +/-
	Revert "group1 wikis to 1.37.0-wmf.6"	operations/mediawiki-config	master	+524 -524

Customize query in gerrit

Revisions and Commits

rOMWC Wikimedia - MediaWiki Config
	rOMWCf95bd0535ae4 testwikis wikis to 1.37.0-wmf.6
	rOMWCbf70451c7914 group0 wikis to 1.37.0-wmf.6
	rOMWC0b669633ed2a group1 wikis to 1.37.0-wmf.6
	rOMWC182d1a7d5bac Revert "group1 wikis to 1.37.0-wmf.6"
	rOMWC9c4db087ce9b group1 wikis to 1.37.0-wmf.6
	rOMWCe852a3b3870b all wikis to 1.37.0-wmf.6
rEGRE extension-GrowthExperiments
	rEGREf4bed4884fbf Merge "Add a link: Hide surface highlight overlay" into wmf/1.37.0-wmf.6
rMW MediaWiki
	rMWfea8f37a95d6 Branch commit for wmf/1.37.0-wmf.6

Related Objects
Search...

Status	Subtype	Assigned	Task
Resolved	Release	hashar	T281147 1.37.0-wmf.6 deployment blockers
Resolved	PRODUCTION ERROR	Zabe	T282825 PHP Deprecated: Use of RevisionListBase::$title was deprecated in MediaWiki 1.37. [Called from RevDelRevisionItem::getHTML]
Resolved	PRODUCTION ERROR	Zabe	T283167 InvalidArgumentException: Unable to normalize the provided actor name x.y.z.v/16
Resolved	PRODUCTION ERROR	None	T283170 Special:RecentChanges in it.wikiversity dies with an internal error
Duplicate	PRODUCTION ERROR	None	T283171 Wikimedia\Assert\PreconditionException: Precondition failed: This Title instance does not represent a proper page, but merely a link target.
Resolved	PRODUCTION ERROR	• Pchelolo	T283196 TypeError: Argument 2 passed to UploadStash::__construct() must implement interface MediaWiki\User\UserIdentity or be null, boolean given, called in /srv/mediawiki/php-1.37.0-wmf.6/includes/upload/UploadFromStash.php on line 66

Event Timeline

thcipriani created this task.Apr 26 2021, 3:14 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 26 2021, 3:14 PM

thcipriani assigned this task to hashar.Apr 26 2021, 3:22 PM

thcipriani triaged this task as Medium priority.

thcipriani updated Other Assignee, added: dancy.

thcipriani added a project: Release-Engineering-Team (Doing).

dancy added a subtask: T282825: PHP Deprecated: Use of RevisionListBase::$title was deprecated in MediaWiki 1.37. [Called from RevDelRevisionItem::getHTML].May 13 2021, 8:20 PM

Zabe subscribed.May 14 2021, 4:10 PM

Umherirrender closed subtask T282825: PHP Deprecated: Use of RevisionListBase::$title was deprecated in MediaWiki 1.37. [Called from RevDelRevisionItem::getHTML] as Resolved.May 14 2021, 5:45 PM

Jdforrester-WMF added a subtask: T283014: Font and font-sizes broken in VE.May 17 2021, 5:38 PM

ppelberg subscribed.May 17 2021, 5:43 PM

Jdlrobson removed a subtask: T283014: Font and font-sizes broken in VE.May 17 2021, 7:28 PM

Just noting this as a "risky" change the train deployers should eb aware of,.

Change: https://gerrit.wikimedia.org/r/c/mediawiki/core/+/682773/

What it does/What it's risky:
This standardizes HTML markup for all skins. There is a small risk that for gadgets/extensions trying to replicate skins that there may be visual regressions like the one raised in T283014 relating to font-size changes.

Test Plan:
We didn't have automated visual regression testing so most testing has been done manually. We think we've covered most of them.

Places to Watch for Breakage
Village pumps, Phabricator.

Revert Plan: No need to take any action, or to block train for these issues. Please merge any tickets into T283014 and set expectations they will be dealt with in the next train.

Wikis Affected: All

ovasileva subscribed.May 17 2021, 7:36 PM

I haven't followed the finish up of 1.37.0-wmf.5 today but it got pushed to all wikis so that is a thing. I will catch up with the events from last week and the risky patch (thank you @Jdlrobson !).

Mentioned in SAL (#wikimedia-operations) [2021-05-18T12:04:26Z] <hashar> scap clean 1.37.0-wmf.1 1.37.0-wmf.3 and 1.37.0-wmf.4 # T281147

It is now on group0 wikis.

group1 wikis have been promoted an hour ago. There were a few of T283167

Zabe added a subtask: T283170: Special:RecentChanges in it.wikiversity dies with an internal error.May 19 2021, 3:29 PM

dancy added a subtask: T283171: Wikimedia\Assert\PreconditionException: Precondition failed: This Title instance does not represent a proper page, but merely a link target..May 19 2021, 3:33 PM

Change 692951 had a related patch set uploaded (by Hashar; author: Hashar):

[operations/mediawiki-config@master] Revert "group1 wikis to 1.37.0-wmf.6"

https://gerrit.wikimedia.org/r/692951

Change 692951 merged by jenkins-bot:

[operations/mediawiki-config@master] Revert "group1 wikis to 1.37.0-wmf.6"

https://gerrit.wikimedia.org/r/692951

Mentioned in SAL (#wikimedia-operations) [2021-05-19T18:20:48Z] <hashar@deploy1002> rebuilt and synchronized wikiversions files: Revert group1 wikis to 1.37.0-wmf.6 T281147

Galessandroni closed subtask T283170: Special:RecentChanges in it.wikiversity dies with an internal error as Resolved.May 19 2021, 6:33 PM

Zabe reopened subtask T283170: Special:RecentChanges in it.wikiversity dies with an internal error as Open.May 19 2021, 6:34 PM

Krinkle added a subtask: T283196: TypeError: Argument 2 passed to UploadStash::__construct() must implement interface MediaWiki\User\UserIdentity or be null, boolean given, called in /srv/mediawiki/php-1.37.0-wmf.6/includes/upload/UploadFromStash.php on line 66.May 19 2021, 6:49 PM

Ladsgroup closed subtask T283170: Special:RecentChanges in it.wikiversity dies with an internal error as Resolved.May 20 2021, 6:29 AM

I have been delayed by some other things. I have +2ed the two backports patches , once merged I will deploy them and promote group 1 wikis again.

13:58 	<hashar@deploy1002> 	Synchronized php: group1 wikis to 1.37.0-wmf.6 (duration: 01m 05s)

I have pushed it to the rest of the wikis. I have found T283282: PHP Deprecated: ignored an error originally raised from WikiPage::insertOn (Lock wait timeout exceeded) which is a deprecation warning and as such does not seem to be a blocker.

In the list of blocker there is T283240 but that is a subtask / followable action to the blocker T283170 which has been resolved. So it is merely a follow actionable, at least that is how I understand it and got confirmed to me by @Lucas_Werkmeister_WMDE (Danke!).

Backend log errors are quiet. The client side log dashboard does not seem to show any surge or spike as part of the new version reaching the rest of wikis. So I guess we are set.

If any issue arise please reopen and reach out to release engineering (on Libera chat irc network) to get it rolled back.

I am not there on Monday (holiday).

• Annoymous604 reopened subtask T283196: TypeError: Argument 2 passed to UploadStash::__construct() must implement interface MediaWiki\User\UserIdentity or be null, boolean given, called in /srv/mediawiki/php-1.37.0-wmf.6/includes/upload/UploadFromStash.php on line 66 as Open.May 25 2021, 6:52 PM

Zabe closed subtask T283196: TypeError: Argument 2 passed to UploadStash::__construct() must implement interface MediaWiki\User\UserIdentity or be null, boolean given, called in /srv/mediawiki/php-1.37.0-wmf.6/includes/upload/UploadFromStash.php on line 66 as Resolved.May 25 2021, 6:57 PM

• Leoyon8 changed the status of subtask T283196: TypeError: Argument 2 passed to UploadStash::__construct() must implement interface MediaWiki\User\UserIdentity or be null, boolean given, called in /srv/mediawiki/php-1.37.0-wmf.6/includes/upload/UploadFromStash.php on line 66 from Resolved to Declined.May 26 2021, 5:56 AM

Legoktm changed the status of subtask T283196: TypeError: Argument 2 passed to UploadStash::__construct() must implement interface MediaWiki\User\UserIdentity or be null, boolean given, called in /srv/mediawiki/php-1.37.0-wmf.6/includes/upload/UploadFromStash.php on line 66 from Declined to Resolved.May 26 2021, 6:12 AM