Page MenuHomePhabricator
Create Task
Maniphest T284584

Remove UserMenu template in favor of using the Menu template
Closed, ResolvedPublic3 Estimated Story Points
Actions

Assigned To
ovasileva
Authored By
bwang
Jun 8 2021, 5:32 PM
Tags
Referenced Files
F34564068: Screen Recording 2021-07-26 at 6.25.59 AM.mov.gif
Jul 26 2021, 1:28 PM
F34519854: Screen Recording 2021-06-21 at 8.17.50 PM.mov.gif
Jun 22 2021, 3:20 AM
F34514102: Screen Shot 2021-06-19 at 11.14.29 AM.png
Jun 19 2021, 6:23 PM
F34514109: Screen Shot 2021-06-19 at 11.22.05 AM.png
Jun 19 2021, 6:23 PM
F34514105: Screen Shot 2021-06-19 at 11.18.48 AM.png
Jun 19 2021, 6:23 PM
Subscribers
Aklapper
bwang
Edtadros
Jdlrobson

Description

Background

The UserMenu template was created for the User links feature, but it is mostly a copy of the Menu template. We want to replace usage of UserMenu with the Menu template to avoid duplicating code and the risk of the two Menus diverging.

AC

  • html-before-portlet is added to the Menu template
  • User links feature uses the updated Menu template instead of UserMenu template
  • Storybook and typing is updated

QA

Load the storybook instance for "user links" and report any potential UI problems.

An engineer can perform QA if this makes more sense
This doesn't need to be QAed in production.

QA Results - Storybook

ACStatusDetails
1❌T284584#7163714

QA Results - Storybook/Beta

ACStatusDetails
1✅T284584#7236200

Details

SubjectRepoBranchLines +/-
Consolidate user links outside of the user menu dropdown into a single new menumediawiki/skins/Vectormaster+98 -103
Update user links storybookmediawiki/skins/Vectormaster+44 -4
Update user links storybookmediawiki/skins/Vectormaster+23 -5
Remove UserMenu and use Menu template insteadmediawiki/skins/Vectormaster+113 -102
Customize query in gerrit

Related Objects

Event Timeline

bwang created this task.Jun 8 2021, 5:32 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 8 2021, 5:32 PM
bwang updated the task description. (Show Details)Jun 8 2021, 5:33 PM
bwang added a project: Web-Team-Backlog (Kanbanana-FY-2020-21).Jun 8 2021, 5:35 PM
Jdlrobson triaged this task as Medium priority.Jun 8 2021, 5:42 PM
Jdlrobson set the point value for this task to 3.
ovasileva moved this task from Needs Analysis to Ready for Development on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.Jun 8 2021, 5:42 PM
LGoto moved this task from Ready for Development to Code Review on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.Jun 8 2021, 5:42 PM
Jdlrobson removed bwang as the assignee of this task.Jun 9 2021, 3:53 PM
Jdlrobson moved this task from Code Review to Needs More Work on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.
gerritbot added a comment.Jun 9 2021, 3:54 PM

Change 698587 had a related patch set uploaded (by Jdlrobson; author: Bernard Wang):

[mediawiki/skins/Vector@master] Remove UserMenu and use Menu template instead

https://gerrit.wikimedia.org/r/698587

gerritbot added a project: Patch-For-Review.Jun 9 2021, 3:54 PM
gerritbot added a comment.Jun 9 2021, 10:02 PM

Change 698587 restored by Bernard Wang:

[mediawiki/skins/Vector@master] Remove UserMenu and use Menu template instead

https://gerrit.wikimedia.org/r/698587

bwang moved this task from Needs More Work to Code Review on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.Jun 9 2021, 10:22 PM
Jdlrobson claimed this task.Jun 10 2021, 5:27 PM
gerritbot added a comment.Jun 11 2021, 4:03 PM

Change 698587 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Remove UserMenu and use Menu template instead

https://gerrit.wikimedia.org/r/698587

Jdlrobson reassigned this task from Jdlrobson to Edtadros.Jun 11 2021, 4:15 PM
Jdlrobson moved this task from Code Review to QA on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.
Jdlrobson updated the task description. (Show Details)
Jdlrobson subscribed.
ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.11; 2021-06-21).Jun 11 2021, 5:00 PM
Edtadros reassigned this task from Edtadros to Jdlrobson.Jun 16 2021, 11:56 PM
Edtadros subscribed.

@Jdlrobson the only storybook link I have doesn't have any user menu components.

Jdlrobson reassigned this task from Jdlrobson to Edtadros.Jun 17 2021, 4:48 PM

@Edtadros looks like the name is "user links" not "user menu"
you can use https://doc.wikimedia.org/mediawiki-skins-Vector/master/js/ui/?path=/story/userlinks--logged-in-user-links

Edtadros added a comment.Jun 19 2021, 5:50 PM

@Jdlrobson thanks. That's an entirely different link than I had. Looks like I need some storybook tutoring.

Edtadros reassigned this task from Edtadros to Jdlrobson.Jun 19 2021, 6:23 PM
Edtadros moved this task from QA to Needs More Work on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.

Test Result - Storybook

Status: ❌ Fail
Environment: Storybook
OS: macOS Big Sur
Browser: Chrome
Device: MBP
Emulated Device: NA

Test Artifact(s):

QA Steps

❌ AC1: Load the storybook instance for "user links" and report any potential UI problems.

I compared the links in story book to beta. Everything checks out except for Logged Out User Links:

The Menu in Beta only contains Login, Talk, and Contributions links

Talk:

Screen Shot 2021-06-19 at 11.14.29 AM.png (400×859 px, 60 KB)

In storybook this points to a logged in user page, WikiUser instead of MyTalk which uses IP address

Sandbox:

Screen Shot 2021-06-19 at 11.18.48 AM.png (400×859 px, 61 KB)

Points to WikiUser sandbox. In beta and prod it doesn't exist.

Preferences, Beta, Watchlist:
These links require you to log in. They don't make sense in a logged out user menu.

Contributions:

Screen Shot 2021-06-19 at 11.22.05 AM.png (400×859 px, 62 KB)

Points to WikiUser contributions instead of MyContributions.

Edtadros updated the task description. (Show Details)Jun 19 2021, 6:24 PM
Jdlrobson reassigned this task from Jdlrobson to bwang.Jun 21 2021, 2:15 PM

@bwang can you update the storybook to reflect the logged out case?

bwang added a comment.Jun 21 2021, 7:09 PM

@Jdlrobson Yep can do!

gerritbot added a comment.Jun 21 2021, 7:33 PM

Change 700686 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):

[mediawiki/skins/Vector@master] Update user links storybook

https://gerrit.wikimedia.org/r/700686

bwang removed bwang as the assignee of this task.Jun 21 2021, 7:34 PM
bwang moved this task from Needs More Work to Code Review on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.
Jdlrobson assigned this task to Edtadros.Jun 21 2021, 8:55 PM
Jdlrobson moved this task from Code Review to QA on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.
gerritbot added a comment.Jun 21 2021, 9:51 PM

Change 700686 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Update user links storybook

https://gerrit.wikimedia.org/r/700686

Edtadros reassigned this task from Edtadros to Jdlrobson.Jun 22 2021, 3:20 AM

@Jdlrobson / @bwang I'm still seeing the same behavior. Let me know if I'm doing something wrong here:

Screen Recording 2021-06-21 at 8.17.50 PM.mov.gif (902×762 px, 496 KB)

bwang added a comment.Jun 22 2021, 3:34 PM

@Edtadros Ah that's my bad, I fixed the login/logout button but I forgot to remove the Login, Talk, and Contributions link for logged out. I'll put in another patch for that

gerritbot added a comment.Jun 22 2021, 4:33 PM

Change 700951 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):

[mediawiki/skins/Vector@master] Remove logged in links from logged out user links storybook

https://gerrit.wikimedia.org/r/700951

bwang claimed this task.Jun 22 2021, 5:07 PM
bwang moved this task from QA to Doing on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.
gerritbot added a comment.Jun 22 2021, 7:12 PM

Change 700951 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Update user links storybook

https://gerrit.wikimedia.org/r/700951

ReleaseTaggerBot edited projects, added MW-1.37-notes (1.37.0-wmf.12; 2021-06-28); removed MW-1.37-notes (1.37.0-wmf.11; 2021-06-21).Jun 22 2021, 8:00 PM
bwang reassigned this task from bwang to Edtadros.Jun 23 2021, 2:30 PM
bwang moved this task from Doing to QA on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.
Edtadros reassigned this task from Edtadros to bwang.Jun 23 2021, 11:34 PM

@bwang the menu items are correct. The issue now is where they link.

Talk:
In Beta and Prod, this links to ../wiki/Special:MyTalk
in Storybook, it links to ../wiki/User_talk:WikiUser

Contributions:
In Beta and Prod, this links to ../wiki/Special:MyContributions
in Storybook, it links to ../wiki/Special:Contributions/WikiUser

Let me know if this is an issue or not.

Jdlrobson moved this task from QA to Needs More Work on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.Jun 30 2021, 4:43 PM

For completeness, Bernard let's fix the links here.

bwang removed bwang as the assignee of this task.Jun 30 2021, 6:22 PM
bwang moved this task from Needs More Work to Code Review on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.
Jdlrobson moved this task from Code Review to Needs More Work on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.Jul 1 2021, 4:25 PM

(needs rebase)

LGoto assigned this task to bwang.Jul 12 2021, 5:25 PM
bwang removed bwang as the assignee of this task.Jul 13 2021, 3:36 PM
bwang moved this task from Needs More Work to Code Review on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.
Jdlrobson claimed this task.Jul 13 2021, 5:09 PM
gerritbot added a comment.Jul 13 2021, 5:20 PM

Change 698024 had a related patch set uploaded (by Bernard Wang; author: Jdlrobson):

[mediawiki/skins/Vector@master] Consolidate user links outside of the user menu dropdown into a single new menu

https://gerrit.wikimedia.org/r/698024

Jdlrobson removed Jdlrobson as the assignee of this task.Jul 14 2021, 8:32 PM
Jdlrobson moved this task from Code Review to Needs More Work on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.
• nray mentioned this in T284242: Search: treatment at smaller resolutions.Jul 14 2021, 9:08 PM
bwang assigned this task to Jdlrobson.Jul 15 2021, 3:33 PM
bwang moved this task from Needs More Work to Code Review on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.
gerritbot added a comment.Jul 15 2021, 8:48 PM

Change 698024 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Consolidate user links outside of the user menu dropdown into a single new menu

https://gerrit.wikimedia.org/r/698024

bwang reassigned this task from Jdlrobson to Edtadros.Jul 15 2021, 8:55 PM
bwang moved this task from Code Review to QA on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.
ReleaseTaggerBot edited projects, added MW-1.37-notes (1.37.0-wmf.15; 2021-07-19); removed MW-1.37-notes (1.37.0-wmf.12; 2021-06-28).Jul 15 2021, 9:00 PM
Edtadros reassigned this task from Edtadros to ovasileva.Jul 26 2021, 1:28 PM
Edtadros moved this task from QA to Ready for Signoff on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.

Test Result - Storybook

Status: ✅ Pass
Environment: Storybook
OS: macOS Big Sur
Browser: Chrome
Device: MBP
Emulated Device: NA

Test Artifact(s):

QA Steps

✅ AC1: Load the storybook instance for "user links" and report any potential UI problems.

These check out in Storybook and in Beta (not sure if that was testable, but I check it)

Screen Recording 2021-07-26 at 6.25.59 AM.mov.gif (812×1 px, 472 KB)

Edtadros updated the task description. (Show Details)Jul 26 2021, 1:29 PM
ovasileva closed this task as Resolved.Jul 26 2021, 9:45 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits