Page MenuHomePhabricator

Verify manual topic subscriptions supports muting
Closed, ResolvedPublic

Description

This task is about verifying manual topic subscriptions supports muting in expected ways.

Testing instructions

Testing environment

  • Wiki: Beta Cluster
  • Platform: mobile or desktop
  • Browser: not specified
  • Accounts needed: 3
    • Account 1
    • Account 2
    • Account 3

Steps

  1. Log into Account 1 the Beta Cluster
  2. Visit a talk page (e.g. https://en.wikipedia.beta.wmflabs.org/wiki/Talk:Cats)
    • Make sure it is not a user talk page, or a subpage of a user talk page. Muting is ignored on your own user talk page (intentionally, as documented) and its subpages (due to an unrelated bug: T288112).
  3. Subscribe to a conversation (read: section) on that page
  4. Visit: https://en.wikipedia.beta.wmflabs.org/wiki/Special:Preferences#mw-prefsection-echo
  5. Add Account 2 to the Muted users field at the bottom of Special:Preferences#mw-prefsection-echo
  6. Click Save
  7. Log into Account 2
  8. Post a comment to the same section you subscribed to in "Step 3.", using Account 1
  9. Log back into Account 1
  10. ✅Verify you were NOT notified about the comment you posted using Account 2 in "Step 9."
  11. Log into Account 3
  12. Post a comment to the same section you subscribed to in "Step 3.", using Account 1
  13. Log back into Account 1
  14. ✅Verify you were notified about the comment you posted using Account 3 in "Step 13."

Done

  • File tickets for any behavior NOT described in the "Steps" section above

Event Timeline

Checked this on Beta and Production (nl.wiki). In both cases Account A is getting notified about a comment from a muted user Account B.

Checked this on Beta and Production (nl.wiki). In both cases Account A is getting notified about a comment from a muted user Account B.

Next steps

  • Editing Engineering to determine what extension the issue is in (e.g. Echo, DiscussionTools, etc.)

I can't reproduce, I don't get the notification for the comment by muted user.

(Although I can see that edit on my watchlist if I'm watching the page, and I get an email about the edit if I enabled "Email me when a page or a file on my watchlist is changed". Perhaps that's not great, but these are not part of the notifications system, and muting only applies to notifications.)

@Ryasmeen Can you please include:

  • Screenshot of the notifications you received as user 1
  • Screenshot of your notification preferences as user 1
  • Link to the comment you posted as user 2

Also, according to https://www.mediawiki.org/wiki/Help:Notifications#mute: "You will still receive notifications if a muted user writes or participates on your user talk page".

I can't reproduce, I don't get the notification for the comment by muted user.

(Although I can see that edit on my watchlist if I'm watching the page, and I get an email about the edit if I enabled "Email me when a page or a file on my watchlist is changed". Perhaps that's not great, but these are not part of the notifications system, and muting only applies to notifications.)

@Ryasmeen Can you please include:

  • Screenshot of the notifications you received as user 1
  • Screenshot of your notification preferences as user 1
  • Link to the comment you posted as user 2

Hey @matmarex: It was on user1's sandbox talk page. Here are the screenshots:

Screenshot of the notifications you received as user 1

Screen Shot 2021-08-03 at 1.15.22 PM.png (392×1 px, 56 KB)

Screenshot of your notification preferences as user 1

Screen Shot 2021-08-03 at 12.56.01 PM.png (1×1 px, 166 KB)

Link to the comment you posted as user 2:

Screen Shot 2021-08-03 at 1.08.32 PM.png (1×1 px, 356 KB)

Thanks for the details. I've read some Echo code, and it turns out that this is a bug in Echo: it's supposed to ignore mutes only for actions on your own user talk page, but it also ignores them on the subpages of it.

The code looks like this, with a helpful comment too: (unchanged since it was added in 2017 for T150419: Allow users to restrict who can send them notifications)

[mediawiki/extensions/Echo]/includes/controller/NotificationController.php
						// Still notify for posts anywhere in
						// user's talk space
						$title->getRootText() === $user->getName() &&
						$title->getNamespace() === NS_USER_TALK

But all of the documentation I could find states that muting only has no effect on your own user talk page:

You will still receive notifications if a muted user writes or participates on your user talk page (no matter if the page uses Flow or unstructured wikitext) […]

If Bananas writes a message on User_talk:Apples or participates on their Flow page, Apples will receive a notification. This is the only type of notification that Apples will receive.

As I understand, the purpose of the muting exception is to prevent users from muting everyone else and pretending that they don't see messages (the same reason why the "Talk page message" notifications can't be disabled). If that's the case, there's no reason to ignore muting on the subpages.

I filed a separate task about this: T288112. We might want to work on that (it's a trivial fix), or coordinate it, but it should not block topic subscriptions, as the bug has been there since 2017.
@Ryasmeen Please test on a different page (not a user talk or a user talk subpage).

I filed a separate task about this: T288112. We might want to work on that (it's a trivial fix), or coordinate it, but it should not block topic subscriptions, as the bug has been there since 2017.
@Ryasmeen Please test on a different page (not a user talk or a user talk subpage).

@matmarex: Just did that and it works on other pages. Thanks!

We're also fixing the behavior with the subpages (see T288112), so thanks for spotting that @Ryasmeen!