Regression: Link tooltips overlap previews
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Jdlrobson
	Jul 21 2021, 8:38 PM

Description

Expected: The title attribute should never show when hovering over a page preview.

Developer notes

It looks like this regression occurring during the implementation of T277639 cc @Lena_WMDE @WMDE-Fisch

The issue is happening because of the line commented here: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Popups/+/677512/comment/306e0417_be9ecf7c/

One potential solution is:

		const previewType = newState.preview.previewType || 'page';

		if ( !newState.preview.enabled[ previewType ] ) {
			return;
		}

We should add a unit test case to cover this.

QA Results - Beta

AC	Status	Details
1	✅	T287119#7307039

QA Results - Prod

AC	Status	Details
1	✅	T287119#7307045

Details

	Subject	Repo	Branch	Lines +/-
	Rewrite linkTitle change listener for clarity/easier expansion	mediawiki/extensions/Popups	master	+29 -46

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		• alexhollender_WMF	T284095 [GOAL] Fix page previews visual bugs and remove unnecessary code before end of quarter
		Resolved		ovasileva	T287119 Regression: Link tooltips overlap previews

Event Timeline

Jdlrobson created this task.Jul 21 2021, 8:38 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 21 2021, 8:38 PM

Jdlrobson updated the task description. (Show Details)Jul 21 2021, 8:39 PM

• alexhollender_WMF awarded a token.Jul 21 2021, 8:41 PM

ovasileva triaged this task as Medium priority.Jul 22 2021, 1:51 PM

ovasileva added a parent task: T284095: [GOAL] Fix page previews visual bugs and remove unnecessary code before end of quarter.

ovasileva added a project: Web-Team-Backlog.

I guess this should be a video? I neither see a preview nor a title on this screenshot. But I get the issue though and could reproduce it.

In T287119#7229850, @WMDE-Fisch wrote:
I guess this should be a video? I neither see a preview nor a title on this screenshot. But I get the issue though and could reproduce it.

@WMDE-Fisch replaced with a GIF

Jdlrobson moved this task from Incoming to Not ready to estimate on the Web-Team-Backlog board.Jul 22 2021, 5:26 PM

Jdlrobson merged a task: T287466: Distracting tooltip appears when hovering with cursor over a Wikipedia-internal link with MinervaNeue theme.Jul 27 2021, 3:27 PM

Jdlrobson added subscribers: Liubomirwm, Masumrezarock100.

ovasileva edited projects, added Web-Team-Backlog (Kanbanana-FY-2021-22); removed Web-Team-Backlog.Aug 3 2021, 4:15 PM

Jdlrobson claimed this task.Aug 3 2021, 5:36 PM

Jdlrobson removed Jdlrobson as the assignee of this task.Aug 5 2021, 7:22 PM

Jdlrobson updated the task description. (Show Details)

Jdlrobson moved this task from Needs Analysis to Upcoming on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.

Change 678220 had a related patch set uploaded (by Jdlrobson; author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Popups@master] Rewrite linkTitle change listener for clarity/easier expansion

https://gerrit.wikimedia.org/r/678220