Page MenuHomePhabricator

Revise the editing toolbar's setting language
Closed, ResolvedPublic

Description

Behavior

  1. Visit: Special:Preferences#mw-prefsection-editing
  2. Scroll to the Discussion pages section

Current

  1. Notice a setting that reads Enable experimental tools in the quick replying and quick topic adding features' source modes

Desired

  1. ✅ Notice the setting now reads Enable editing tools in source mode / This will add a toolbar to the quick replying and quick topic adding features’ source modes that includes shortcuts for pinging and adding links.

Deployment

@matmarex is going to deploy this via backport along with T287927.

Done

  • "Desired" copy change is made to Special:Preferences#mw-prefsection-editing

Event Timeline

  1. ✅Notice the setting now reads Enable editing tools in source mode / […]

Source mode of what? While dropping “experimental” is understandable and needed, but dropping the reference for the tools would make it confusing even if the description was clear (the description is for those who are unfamiliar with the topic, and should not be needed by those who are fairly familiar with the tool the preference governs). Either the current wording should be kept (except for “experimental”):

Enable tools in the quick replying and quick topic adding features' source modes

or, if you want to keep it short, referring to DiscussionTools is also fine as long as the description explains what DT is:

Enable tools in DiscussionTools’ source mode


[…] / This will add a toolbar that includes shortcuts for pinging and adding links when drafting comments and new discussion topics.

This description covers the usage of the full-page editor as well—one can draft comments and new discussion topics there. Something like this would be clearer:

This will add a toolbar to the quick replying and quick topic adding features’ source modes that includes shortcuts for pinging and adding links.

@Tacsipacsi What if we added "…in these features" (or something similar) instead? I think that should make it clear enough, given the context of the preferences page.

image.png (2×3 px, 392 KB)

(Also, it should say "editing toolbar" instead of "editing tools", for consistency.)

@Tacsipacsi What if we added "…in these features" (or something similar) instead?

Where? In the “title” or in the description? In the title, it may make sense (although “DiscussionTools” is just as short and more accurate); in the description, I’d explain explicitly what features it affects—clarity is more important there than brevity.

@Tacsipacsi What if we added "…in these features" (or something similar) instead?

Where? In the “title” or in the description? In the title, it may make sense (although “DiscussionTools” is just as short and more accurate); in the description, I’d explain explicitly what features it affects—clarity is more important there than brevity.

@Tacsipacsi I think the revised language you proposed in T287315#7234800 makes it clear to people: A) what parts of their experience will be impacted by this setting and B) what that impact will be.

I've updated the task description to reflect this.

As always, we appreciate you keeping a close eye on this work and sharing valuable feedback about how it can be improved.

@ppelberg You didn’t touch the “title” part, was that intentional? I still think that some reference to DiscussionTools or the actual tools (RT & NDT) would be necessary.

@ppelberg You didn’t touch the “title” part, was that intentional? I still think that some reference to DiscussionTools or the actual tools (RT & NDT) would be necessary.

It was intentional.

Reasons:

  • To make the page easy to scan quickly, I'd like to keep the setting title brief
  • I think the description language is now explicit and clear enough to resolve any ambiguity the title might introduce

I figure we can iterate on the language if any of the above proves incorrect.

Change 710071 had a related patch set uploaded (by DLynch; author: DLynch):

[mediawiki/extensions/DiscussionTools@master] Update preferences language for source mode toolbar

https://gerrit.wikimedia.org/r/710071

@ppelberg this winds up being our only preference whose help doesn't include the "You can learn more about this feature by reading the feature summary." blurb. Should I include it?

@ppelberg this winds up being our only preference whose help doesn't include the "You can learn more about this feature by reading the feature summary." blurb. Should I include it?

Good call out, @DLynch.

I think it's fine to exclude the "You can learn more about this feature by reading the feature summary." blurb it because it is included in the settings for the two features this setting impacts/modifies.

Change 710071 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] Update preferences language for source mode toolbar

https://gerrit.wikimedia.org/r/710071

Change 710096 had a related patch set uploaded (by Bartosz Dziewoński; author: DLynch):

[mediawiki/extensions/DiscussionTools@wmf/1.37.0-wmf.16] Update preferences language for source mode toolbar

https://gerrit.wikimedia.org/r/710096

Change 710097 had a related patch set uploaded (by Bartosz Dziewoński; author: DLynch):

[mediawiki/extensions/DiscussionTools@wmf/1.37.0-wmf.17] Update preferences language for source mode toolbar

https://gerrit.wikimedia.org/r/710097

Change 710096 abandoned by Bartosz Dziewoński:

[mediawiki/extensions/DiscussionTools@wmf/1.37.0-wmf.16] Update preferences language for source mode toolbar

Reason:

Per Urbanecm on IRC, backporting changes to localisation is very slow and thus inconvenient. I'll create a local override on English Wikipedia instead.

https://gerrit.wikimedia.org/r/710096

Change 710097 abandoned by Bartosz Dziewoński:

[mediawiki/extensions/DiscussionTools@wmf/1.37.0-wmf.17] Update preferences language for source mode toolbar

Reason:

Per Urbanecm on IRC, backporting changes to localisation is very slow and thus inconvenient. I'll create a local override on English Wikipedia instead.

https://gerrit.wikimedia.org/r/710097

ppelberg reopened this task as Open.

(Leaving this open until this change lands on all wikis on Thursday, 12 August)