Page MenuHomePhabricator
Create Task
Maniphest T287501

Check RTL support on the developer portal
Closed, ResolvedPublic
Actions

Description

Have a quick check / walkthrough on RTL support.

Proposal

With the current setup, we can use placeholder content to get some early feedback and see whether there are any major issues. To do this, we'll need to add an RTL language on the Dev Portal demo site manually with placeholder content from Google Translate which we'll delete after the review is complete.

Known issues
To do
  • Test search after merging; search isn't working locally

Details

SubjectRepoBranchLines +/-
i18n: Add placeholder content to test RTLwikimedia/developer-portalmain+1 K -31
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedAklapperT265018 Update redirect target of dev.wikimedia.org to Developer Portal
 ResolvedAklapperT265019 Update several on-wiki link targets for "Developers" links (sidebars, footer, pages)
 ResolvedAklapperT286568 Communicate launch
 ResolvedAklapperT302809 Add dev portal to list of microsites on doc.wikimedia.org
 ResolvedNoneT299923 Update Zulip's welcomebot message and GSoC organization contact to point to dev portal
 ResolvedAklapperT287030 Update or remove meta:Wikimedia_Resource_Center/For_developers
 ResolvedAklapperT265017 Once developer.wikimedia.org is up, make https://www.mediawiki.org/wiki/API:Web_APIs_hub redirect to it
 ResolvedAklapperT261510 Launch MVP of Developer Portal on https://developer.wikimedia.org/
 ResolvedAklapperT306832 Create documentation for contributors
 ResolvedAklapperT290254 Workflow how to add/edit content
 ResolvedAklapperT276702 Workflow how to propose content changes
 ResolvedAklapperT303987 Create documentation for translators
 ResolvedNoneT290256 Workflow for translators how to translate content
 Resolvedbd808T276700 Content localization infrastructure setup (export, import, deploy)
 Resolvedbd808T276708 Define content storage format (levels, data structure, hierarchy, categorization, etc)
 ResolvedBUG REPORTbd808T309113 Static pages fail to build when the active locale is not also supported by mkdocs-material theme
 Resolvedabi_T308236 Add "Wikimedia Developer Portal" to translatewiki.net
 Resolvedbd808T297168 Write localization/internationalization mkdocs plugin
 ResolvedSpikebd808T295832 Evaluate improving/replacing mkdocs-mdpo-plugin to better support TWN integration
 ResolvedapaskulinT287501 Check RTL support on the developer portal

Event Timeline

Aklapper changed the task status from Open to Stalled.Jul 27 2021, 4:44 PM
Aklapper created this task.
Restricted Application added a project: I18n. · View Herald TranscriptJul 27 2021, 4:44 PM
Aklapper added a parent task: T261510: Launch MVP of Developer Portal on https://developer.wikimedia.org/.Jul 27 2021, 4:44 PM
Aklapper moved this task from Inbox to Implementation on the Wikimedia-Developer-Portal board.
Amire80 renamed this task from Check RTL support to Check RTL support on the developer portal.Jul 27 2021, 5:15 PM
Amire80 subscribed.

Just tell me where it is and I'll be happy to make a quick first assessment.

Aklapper added a comment.Jul 27 2021, 5:40 PM

@Amire80: Thanks, this is still months ahead - just trying to sort out all our tasks early :)

Amire80 added a comment.Jul 27 2021, 5:48 PM

OK, whenever ready, just ask.

Aklapper triaged this task as Low priority.Aug 3 2021, 5:30 PM
Aklapper moved this task from Implementation to Pre-Launch on the Wikimedia-Developer-Portal board.Aug 31 2021, 2:53 PM
apaskulin moved this task from Pre-Launch to Launch on the Wikimedia-Developer-Portal board.Apr 19 2022, 6:02 PM
Aklapper added a comment.Apr 20 2022, 9:28 AM

For the records and transparency: Per T287176, we went for a dedicated language switch dropdown UI element and not for reading the accept-language request HTTP header. A test instance is up on https://developer-portal.wmcloud.org/ (this is not the final URL!) but we have no RTL languages yet to test, so this task remains stalled for the time being.

apaskulin changed the task status from Stalled to Open.Apr 20 2022, 11:56 PM
apaskulin claimed this task.
apaskulin raised the priority of this task from Low to High.
apaskulin updated the task description. (Show Details)
apaskulin updated the task description. (Show Details)Apr 21 2022, 12:31 AM
apaskulin updated the task description. (Show Details)Apr 21 2022, 12:34 AM
apaskulin updated the task description. (Show Details)
gerritbot added a comment.Apr 21 2022, 12:37 AM

Change 784796 had a related patch set uploaded (by Alex Paskulin; author: Alex Paskulin):

[wikimedia/developer-portal@main] WIP Add placeholder content to test RTL

https://gerrit.wikimedia.org/r/784796

gerritbot added a project: Patch-For-Review.Apr 21 2022, 12:37 AM
apaskulin updated the task description. (Show Details)Apr 21 2022, 11:33 PM
apaskulin updated the task description. (Show Details)Apr 21 2022, 11:55 PM
apaskulin updated the task description. (Show Details)Apr 22 2022, 10:31 PM
apaskulin updated the task description. (Show Details)Apr 25 2022, 3:11 PM
apaskulin updated the task description. (Show Details)Apr 25 2022, 10:19 PM
gerritbot added a comment.Apr 28 2022, 5:06 PM

Change 784796 merged by jenkins-bot:

[wikimedia/developer-portal@main] i18n: Add placeholder content to test RTL

https://gerrit.wikimedia.org/r/784796

apaskulin mentioned this in rWDPOc0a90a510b03: i18n: Add placeholder content to test RTL.Apr 28 2022, 5:06 PM
apaskulin updated the task description. (Show Details)Apr 28 2022, 5:09 PM
apaskulin added a comment.Apr 28 2022, 5:17 PM

@Amire80 Thanks for offering to do a quick assessment! I've added placeholder content from Google Translate to populate a few pages to review. (Apologies for the bad translations! I'll delete this content after the assessment.)

apaskulin updated the task description. (Show Details)Apr 28 2022, 5:26 PM
Maintenance_bot removed a project: Patch-For-Review.Apr 28 2022, 5:31 PM
apaskulin reassigned this task from apaskulin to Amire80.May 3 2022, 4:07 PM
apaskulin subscribed.
Aklapper added a comment.May 12 2022, 10:26 AM

Non-translated (=English) strings displayed as fallback in RTL langs have their full stops in the wrong place. We only set a global <html lang="he" class="no-js">, there is no lang or dir on a per-string level (<p>Help build the Wikimedia ecosystem with open source software.</p>):

Screenshot from 2022-05-12 12-14-27.png (285×751 px, 27 KB)

I wonder if there's a way to check for the global lang, at some stage identify strings that lack translations, and set dir="ltr" on them. (However that seems to also change the alignment of that element as a side effect.) On the other hand this sounds quite upstream but I didn't find something in the mkdocs upstream (?) docs.

Aklapper added a parent task: T308236: Add "Wikimedia Developer Portal" to translatewiki.net.May 12 2022, 2:38 PM
apaskulin removed Amire80 as the assignee of this task.May 12 2022, 2:57 PM

Placeholder pages have been deleted as we prepare for integration with translatewiki

bd808 subscribed.May 13 2022, 8:29 PM
In T287501#7923979, @Aklapper wrote:

I wonder if there's a way to check for the global lang, at some stage identify strings that lack translations, and set dir="ltr" on them.

This is a wish for fancier behavior than literally any l10n system I have ever personally used. Even adding dir="auto" and letting the browser sort it out at a paragraph level would require patching the third-party markdown->html generator used by mkdocs. I'd vote WONTFIX.

Aklapper added a comment.May 13 2022, 8:49 PM

Makes sense.

apaskulin closed this task as Resolved.May 25 2022, 6:05 PM
apaskulin claimed this task.

In April, I used placeholder content in Hebrew to evaluate the site's support for RTL. This revealed a few issues with the translation system in general that were resolved, and a few issues with RTL styles that were also resolved. Now that the integration with translatewiki has been enabled and the placeholder content has been removed, we cannot do an evaluation with an RTL language speaker until the site has content in that language. Closing this as complete for the MVP

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL