Page MenuHomePhabricator

[regression-wmf.16] mobile - VE toolbar displayed incorrectly
Closed, ResolvedPublic

Description

The issue is present on testwiki wmf.16 (and betalabs).

Open VE on any article on mobile (or Minerva Neue skin). The VE toolbar is displayed incorrectly.

Screen Shot 2021-07-27 at 3.11.58 PM.png (1×764 px, 54 KB)

Note: for add link tasks articles for GrowthExperiments it's displayed broken too.

Screen Shot 2021-07-27 at 3.00.18 PM.png (1×770 px, 129 KB)

Event Timeline

Caused by rSMINca18ad75d311: minerva-header class is now in cached HTML, remove old header class, which removed various styles from the .header class that we apparently relied on.

The loading "fake toolbar" is also broken, in a different way.

Screenshots from https://en.m.wikipedia.beta.wmflabs.org/wiki/Lorem_ipsum#/editor/1:

Loading toolbarEditor toolbar
Phone
Opera Snapshot_2021-07-30_111400_en.m.wikipedia.beta.wmflabs.org.png (1×640 px, 138 KB)
Opera Snapshot_2021-07-30_111458_en.m.wikipedia.beta.wmflabs.org.png (1×640 px, 148 KB)
Tablet
Opera Snapshot_2021-07-30_111433_en.m.wikipedia.beta.wmflabs.org.png (2×3 px, 275 KB)
Opera Snapshot_2021-07-30_111444_en.m.wikipedia.beta.wmflabs.org.png (2×3 px, 222 KB)

Change 709033 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/MobileFrontend@master] Styling fixes for mobile visual editor (and editor loading overlay)

https://gerrit.wikimedia.org/r/709033

Test wiki created on Patch Demo by Jdlrobson using patch(es) linked to this task:

https://patchdemo.wmflabs.org/wikis/08c85f40b9/w/

Change 708990 had a related patch set uploaded (by Jdlrobson; author: Bartosz Dziewoński):

[mediawiki/extensions/MobileFrontend@wmf/1.37.0-wmf.16] Styling fixes for mobile visual editor (and editor loading overlay)

https://gerrit.wikimedia.org/r/708990

Change 709033 merged by jenkins-bot:

[mediawiki/extensions/MobileFrontend@master] Styling fixes for mobile visual editor (and editor loading overlay)

https://gerrit.wikimedia.org/r/709033

Presumably this should be backported? Possibly even today? @matmarex can I leave that with your team to decide?

I have no power to make that happen today.

Thank you @matmarex - I checked betalabs, looks good. I wish there were a way to add an appreciation token for a patch.

Change 708990 merged by jenkins-bot:

[mediawiki/extensions/MobileFrontend@wmf/1.37.0-wmf.16] Styling fixes for mobile visual editor (and editor loading overlay)

https://gerrit.wikimedia.org/r/708990

Mentioned in SAL (#wikimedia-operations) [2021-08-02T12:10:31Z] <reedy@deploy1002> Synchronized php-1.37.0-wmf.16/extensions/MobileFrontend/: T287528 (duration: 00m 57s)

matmarex added a project: Editing QA.

The backport is deployed to production now.

The backport is deployed to production now.

Excellent. Thank you, Bartosz.

Checked in production (wmf.16)- the issue has been fixed.