[regression-wmf.16] mobile - VE toolbar displayed incorrectly
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Etonkovidova
	Jul 27 2021, 10:16 PM

Description

The issue is present on testwiki wmf.16 (and betalabs).

Open VE on any article on mobile (or Minerva Neue skin). The VE toolbar is displayed incorrectly.

Screen Shot 2021-07-27 at 3.11.58 PM.png (1×764 px, 54 KB)

Note: for add link tasks articles for GrowthExperiments it's displayed broken too.

Screen Shot 2021-07-27 at 3.00.18 PM.png (1×770 px, 129 KB)

Details

	Subject	Repo	Branch	Lines +/-
	Styling fixes for mobile visual editor (and editor loading overlay)	mediawiki/extensions/MobileFrontend	wmf/1.37.0-wmf.16	+11 -4
	Styling fixes for mobile visual editor (and editor loading overlay)	mediawiki/extensions/MobileFrontend	master	+11 -4

Customize query in gerrit

Related Objects

Mentioned Here: rSMINca18ad75d311: minerva-header class is now in cached HTML, remove old header class

Event Timeline

Etonkovidova created this task.Jul 27 2021, 10:16 PM

Restricted Application added subscribers: Masumrezarock100, Aklapper. · View Herald TranscriptJul 27 2021, 10:16 PM

Etonkovidova added a subscriber: matmarex.Jul 30 2021, 12:01 AM

matmarex added a project: VisualEditor.Jul 30 2021, 7:35 AM

Caused by rSMINca18ad75d311: minerva-header class is now in cached HTML, remove old header class, which removed various styles from the .header class that we apparently relied on.

The loading "fake toolbar" is also broken, in a different way.

Screenshots from https://en.m.wikipedia.beta.wmflabs.org/wiki/Lorem_ipsum#/editor/1:

	Loading toolbar	Editor toolbar
Phone
Tablet

matmarex claimed this task.Jul 30 2021, 9:18 AM

matmarex added a project: Editing-team (Kanban Board).

Change 709033 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/MobileFrontend@master] Styling fixes for mobile visual editor (and editor loading overlay)

https://gerrit.wikimedia.org/r/709033

gerritbot added a project: Patch-For-Review.Jul 30 2021, 12:50 PM

matmarex moved this task from Incoming to Code Review on the Editing-team (Kanban Board) board.Jul 30 2021, 12:53 PM

Thank you for finding this @Etonkovidova!

Thank you <3

Test wiki created on Patch Demo by Jdlrobson using patch(es) linked to this task:

https://patchdemo.wmflabs.org/wikis/08c85f40b9/w/

Change 708990 had a related patch set uploaded (by Jdlrobson; author: Bartosz Dziewoński):

[mediawiki/extensions/MobileFrontend@wmf/1.37.0-wmf.16] Styling fixes for mobile visual editor (and editor loading overlay)

https://gerrit.wikimedia.org/r/708990

Change 709033 merged by jenkins-bot:

[mediawiki/extensions/MobileFrontend@master] Styling fixes for mobile visual editor (and editor loading overlay)

https://gerrit.wikimedia.org/r/709033

Presumably this should be backported? Possibly even today? @matmarex can I leave that with your team to decide?

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.17; 2021-08-02).Jul 30 2021, 3:00 PM

I have no power to make that happen today.

matmarex moved this task from Code Review to Doing on the Editing-team (Kanban Board) board.Jul 30 2021, 3:40 PM

ppelberg subscribed.Jul 30 2021, 3:44 PM

Thank you @matmarex - I checked betalabs, looks good. I wish there were a way to add an appreciation token for a patch.

• mewoph moved this task from Inbox to Triaged on the Growth-Team board.Jul 30 2021, 9:14 PM

• mewoph edited projects, added Growth-Team (Sprint 0 (Growth Team)); removed Growth-Team.

• mewoph moved this task from Incoming to Test in Production | Watching on the Growth-Team (Sprint 0 (Growth Team)) board.

Change 708990 merged by jenkins-bot:

[mediawiki/extensions/MobileFrontend@wmf/1.37.0-wmf.16] Styling fixes for mobile visual editor (and editor loading overlay)

https://gerrit.wikimedia.org/r/708990

Maintenance_bot removed a project: Patch-For-Review.Aug 2 2021, 12:10 PM

Mentioned in SAL (#wikimedia-operations) [2021-08-02T12:10:31Z] <reedy@deploy1002> Synchronized php-1.37.0-wmf.16/extensions/MobileFrontend/: T287528 (duration: 00m 57s)

The backport is deployed to production now.

ReleaseTaggerBot edited projects, added MW-1.37-notes (1.37.0-wmf.16; 2021-07-26); removed MW-1.37-notes (1.37.0-wmf.17; 2021-08-02).Aug 2 2021, 1:00 PM

In T287528#7251682, @matmarex wrote:

The backport is deployed to production now.

Excellent. Thank you, Bartosz.

Jdlrobson awarded a token.Aug 2 2021, 8:25 PM

Checked in production (wmf.16)- the issue has been fixed.

Test wiki on Patch demo by Jdlrobson using patch(es) linked to this task was deleted:

~~https://patchdemo.wmflabs.org/wikis/08c85f40b9/w/~~

	F34570256: Opera Snapshot_2021-07-30_111458_en.m.wikipedia.beta.wmflabs.org.png
	Jul 30 2021, 9:18 AM

	F34570255: Opera Snapshot_2021-07-30_111400_en.m.wikipedia.beta.wmflabs.org.png
	Jul 30 2021, 9:18 AM

	F34570257: Opera Snapshot_2021-07-30_111433_en.m.wikipedia.beta.wmflabs.org.png
	Jul 30 2021, 9:18 AM

	F34570254: Opera Snapshot_2021-07-30_111444_en.m.wikipedia.beta.wmflabs.org.png
	Jul 30 2021, 9:18 AM

	F34567328: Screen Shot 2021-07-27 at 3.00.18 PM.png
	Jul 27 2021, 10:16 PM

	F34567325: Screen Shot 2021-07-27 at 3.11.58 PM.png
	Jul 27 2021, 10:16 PM

[regression-wmf.16] mobile - VE toolbar displayed incorrectlyClosed, ResolvedPublicActions

Description

Details

Related Objects

Event Timeline

[regression-wmf.16] mobile - VE toolbar displayed incorrectly
Closed, ResolvedPublic
Actions