Page MenuHomePhabricator
Create Task
Maniphest T287533

The ULS language button doesn't collapse where it should
Closed, ResolvedPublic3 Estimated Story Points
Actions

Assigned To
ovasileva
Authored By
Jdlrobson
Jul 27 2021, 11:24 PM
Tags
Referenced Files
F34585385: Screen Recording 2021-08-05 at 8.03.10 AM.mov.gif
Aug 5 2021, 3:06 PM
F34585380: Screen Recording 2021-08-05 at 7.58.54 AM.mov.gif
Aug 5 2021, 3:01 PM
F34568614: Screen Shot 2021-07-28 at 3.44.06 PM.png
Jul 28 2021, 10:44 PM
F34567361: Screen Shot 2021-07-27 at 4.18.52 PM.png
Jul 27 2021, 11:24 PM
Subscribers
Aklapper
bwang
Edtadros
Jdlrobson
ovasileva

Description

When resizing the window to say 567px the language button doesn't collapse on Office Wiki

Screen Shot 2021-07-27 at 4.18.52 PM.png (690×924 px, 120 KB)

Developer notes

This looks another load order race condition. The issue is the user-links-collapsible-item class is not getting applied to the button.

I can replicate it when I do:

wfLoadSkin( 'Vector' );
wfLoadExtension('UniversalLanguageSelector');

I think the solution here is to stop using the hook in Vector and moving this to SkinVector::getTemplateData where ordering is better guaranteed.

QA steps

QA Results - Beta

ACStatusDetails
1✅T287533#7263606
2✅T287533#7263606

QA Results - Prod

ACStatusDetails
1✅T287533#7263619
2✅T287533#7263619

Details

SubjectRepoBranchLines +/-
Use buildContentNavigationUrls() override instead of odd hook callingmediawiki/skins/Vectormaster+76 -93
Run Vector's SkinTemplateNavigation hook lastmediawiki/skins/Vectormaster+13 -2
SkinTemplate: Factor out SkinTemplateNavigation hooksmediawiki/coremaster+25 -8
Tests should use Universal hookmediawiki/skins/Vectormaster+8 -2
Customize query in gerrit

Related Objects
Search...

Event Timeline

Jdlrobson created this task.Jul 27 2021, 11:24 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 27 2021, 11:24 PM
Jdlrobson added a subscriber: ovasileva.Jul 27 2021, 11:24 PM

cc @ovasileva potential blocker for rolling out further?

ovasileva triaged this task as High priority.Jul 27 2021, 11:29 PM
In T287533#7241382, @Jdlrobson wrote:

cc @ovasileva potential blocker for rolling out further?

Yeah, I think we should fix this before deploying further

Jdlrobson claimed this task.Jul 28 2021, 4:43 PM

current plan: refactor core to allow skins to extend the class and register the hook by overriding the protected function to guarantee it running last.

LGoto set the point value for this task to 3.Jul 28 2021, 4:50 PM
LGoto moved this task from Upcoming to Ready for Development on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.
Jdlrobson moved this task from Ready for Development to Doing on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.Jul 28 2021, 5:02 PM
gerritbot added a comment.Jul 28 2021, 5:03 PM

Change 708570 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/core@master] SkinTemplate: Factor out SkinTemplateNavigation hooks

https://gerrit.wikimedia.org/r/708570

gerritbot added a project: Patch-For-Review.Jul 28 2021, 5:03 PM
gerritbot added a comment.Jul 28 2021, 6:15 PM

Change 708578 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Vector@master] Tests should use Universal hook

https://gerrit.wikimedia.org/r/708578

gerritbot added a comment.Jul 28 2021, 6:24 PM

Change 708580 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Vector@master] Run Vector's SkinTemplateNavigation hook last

https://gerrit.wikimedia.org/r/708580

Jdlrobson removed Jdlrobson as the assignee of this task.Jul 28 2021, 6:27 PM
Jdlrobson mentioned this in T287622: Skin hooks should run after extension hooks.
Jdlrobson moved this task from Doing to Code Review on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.
Jdlrobson added a parent task: T287637: [GOAL] Deploy the new user links feature to all wikis.Jul 28 2021, 9:26 PM
Jdlrobson assigned this task to bwang.Jul 28 2021, 10:01 PM
Jdlrobson added a comment.Jul 28 2021, 10:44 PM

I think this will also fix the inconsistency between the "Uploaded media"/"Translation" labels in:

Screen Shot 2021-07-28 at 3.44.06 PM.png (616×458 px, 38 KB)

ovasileva added a project: Desktop Improvements (Vector 2022).Jul 29 2021, 2:29 PM
gerritbot added a comment.Jul 29 2021, 6:50 PM

Change 708578 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Tests should use Universal hook

https://gerrit.wikimedia.org/r/708578

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.17; 2021-08-02).Jul 29 2021, 7:00 PM
gerritbot added a comment.Jul 29 2021, 10:36 PM

Change 708570 merged by jenkins-bot:

[mediawiki/core@master] SkinTemplate: Factor out SkinTemplateNavigation hooks

https://gerrit.wikimedia.org/r/708570

Jdlrobson updated the task description. (Show Details)Jul 29 2021, 11:07 PM
gerritbot added a comment.Jul 29 2021, 11:42 PM

Change 708580 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Run Vector's SkinTemplateNavigation hook last

https://gerrit.wikimedia.org/r/708580

Jdlrobson reassigned this task from bwang to Edtadros.Jul 29 2021, 11:57 PM
Jdlrobson moved this task from Code Review to QA on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.
Jdlrobson added a subscriber: bwang.
LGoto edited projects, added Web-Team-Backlog (Kanbanana-FY-2021-22); removed Web-Team-Backlog (Kanbanana-FY-2020-21).Aug 2 2021, 9:30 PM
LGoto moved this task from Needs Analysis to QA on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.
Edtadros moved this task from QA to QA in Prod on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.Aug 5 2021, 3:01 PM

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Big Sur
Browser: Chrome
Device: MBP
Emulated Device: NA

Test Artifact(s):

QA Steps

Test on https://wikidata.beta.wmflabs.org/wiki/Q356553
✅ AC1: Resize browser. When the screen gets too small the language button should disappear.
✅ AC2: Expanding the browser window should make the language button appear again.

Screen Recording 2021-08-05 at 7.58.54 AM.mov.gif (434×780 px, 779 KB)

Edtadros updated the task description. (Show Details)Aug 5 2021, 3:03 PM
Edtadros reassigned this task from Edtadros to ovasileva.Aug 5 2021, 3:06 PM
Edtadros moved this task from QA in Prod to Ready for Signoff on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.
Edtadros subscribed.

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Big Sur
Browser: Chrome
Device: MBP
Emulated Device: NA

Test Artifact(s):

QA Steps

Test on https://www.wikidata.org/wiki/Wikidata:Main_Page?vectoruserlinks=1
✅ AC1: Resize browser. When the screen gets too small the language button should disappear.
✅ AC2: Expanding the browser window should make the language button appear again.

Screen Recording 2021-08-05 at 8.03.10 AM.mov.gif (396×740 px, 701 KB)

Edtadros updated the task description. (Show Details)Aug 5 2021, 3:06 PM
Edtadros updated the task description. (Show Details)
ovasileva closed this task as Resolved.Aug 5 2021, 3:59 PM

Looks good!

gerritbot added a comment.Sep 9 2021, 6:16 PM

Change 720080 had a related patch set uploaded (by Krinkle; author: Krinkle):

[mediawiki/skins/Vector@master] Use buildContentNavigationUrls() override instead of odd hook calling

https://gerrit.wikimedia.org/r/720080

gerritbot added a comment.Jan 16 2023, 5:23 PM

Change 720080 abandoned by Krinkle:

[mediawiki/skins/Vector@master] Use buildContentNavigationUrls() override instead of odd hook calling

Reason:

https://gerrit.wikimedia.org/r/720080

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits