The class is not newable, but callers have no choice but to instantiate it, which several extensions (+ core) are doing. It should be a proper service instead.
The general plan for this is to have:
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T288958 Make PageArchive a proper service | |||
| Resolved | Daimona | T290021 Create a new UndeletePage command object | |||
| Resolved | matej_suchanek | T290022 Create a new ArchivedRevisionLookup service to replace the relevant parts of PageArchive | |||
| Open | None | T294629 Create PageArchiveSearch service which will support paging |
I don't think something like new PageArchive( $title, /* ... */ ) can simply become a service (i.e. it's instantiated with a title object).
See also this todo remark in its constructor:
// TODO: Refactor: delete()/undeleteAsUser() should live in a PageStore service; // Methods in PageArchive and RevisionStore that deal with archive revisions // should move into an ArchiveStore service (but could still be implemented // together with RevisionStore).
Anyway, yes, it's a mess.
Good point. If the title is really necessary in the constructor, there should be a PageArchiveFactory.
See also this todo remark in its constructor:
// TODO: Refactor: delete()/undeleteAsUser() should live in a PageStore service; // Methods in PageArchive and RevisionStore that deal with archive revisions // should move into an ArchiveStore service (but could still be implemented // together with RevisionStore).
That's also a good point, I'll get back on this once T288242 is done to see what we can do.