Page MenuHomePhabricator
Create Task
Maniphest T290021

Create a new UndeletePage command object
Closed, ResolvedPublic3 Estimated Story Points
Actions

Description

This will replace PageArchive::undeleteAsUser (and dependencies).

Details

Show related patches Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 OpenNoneT288958 Make PageArchive a proper service
 ResolvedDaimonaT290021 Create a new UndeletePage command object

Event Timeline

Daimona created this task.Aug 30 2021, 4:43 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 30 2021, 4:43 PM
Daimona added a parent task: T288958: Make PageArchive a proper service.Aug 30 2021, 4:44 PM
Daimona mentioned this in T290022: Create a new ArchivedRevisionLookup service to replace the relevant parts of PageArchive.
Daimona set the point value for this task to 3.
gerritbot added a comment.Aug 30 2021, 5:12 PM

Change 715565 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/core@master] Move code from PageArchive to a new DeletePage command

https://gerrit.wikimedia.org/r/715565

gerritbot added a project: Patch-For-Review.Aug 30 2021, 5:12 PM
gerritbot added a comment.Aug 30 2021, 5:31 PM

Change 715567 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/core@master] DeletePage cleanup, part 1

https://gerrit.wikimedia.org/r/715567

gerritbot added a comment.Aug 30 2021, 6:35 PM

Change 715578 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/core@master] Change return format of UndeletePage::undeleteAsUser

https://gerrit.wikimedia.org/r/715578

gerritbot added a comment.Aug 30 2021, 8:13 PM

Change 715592 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/core@master] Use fluent setters instead of optional params in UndeletePage

https://gerrit.wikimedia.org/r/715592

ldelench_wmf moved this task from Backlog to 🌟Top Priority on the Undelete-Associated-Talk-Page (2021) board.Aug 30 2021, 8:51 PM
gerritbot added a comment.Aug 30 2021, 8:56 PM

Change 715596 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/core@master] Add perm checks to UndeletePage and make it a real service

https://gerrit.wikimedia.org/r/715596

Daimona moved this task from Ready 🎬 to Review/Feedback 💬 on the Community-Tech (CommTech-Sprint-8) board.Aug 30 2021, 8:59 PM
ldelench_wmf edited projects, added Community-Tech (CommTech-Sprint-9); removed Community-Tech (CommTech-Sprint-8).Sep 13 2021, 7:41 PM
ldelench_wmf moved this task from Ready 🎬 to Review/Feedback 💬 on the Community-Tech (CommTech-Sprint-9) board.
gerritbot added a comment.Sep 27 2021, 2:22 PM

Change 715565 merged by jenkins-bot:

[mediawiki/core@master] Move code from PageArchive to a new UndeletePage command

https://gerrit.wikimedia.org/r/715565

gerritbot added a comment.Sep 27 2021, 2:24 PM

Change 715567 merged by jenkins-bot:

[mediawiki/core@master] UndeletePage cleanup, part 1

https://gerrit.wikimedia.org/r/715567

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.2; 2021-09-28).Sep 27 2021, 3:00 PM
gerritbot added a comment.Sep 27 2021, 4:26 PM

Change 715578 merged by jenkins-bot:

[mediawiki/core@master] Change return format of UndeletePage::undelete()

https://gerrit.wikimedia.org/r/715578

ldelench_wmf edited projects, added Community-Tech (CommTech-Sprint-10); removed Community-Tech (CommTech-Sprint-9).Sep 27 2021, 8:36 PM
ldelench_wmf moved this task from Ready 🎬 to Review/Feedback 💬 on the Community-Tech (CommTech-Sprint-10) board.
gerritbot added a comment.Sep 27 2021, 10:16 PM

Change 724197 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/core@master] Use UndeletePage from ApiUndelete

https://gerrit.wikimedia.org/r/724197

gerritbot added a comment.Sep 27 2021, 11:14 PM

Change 724208 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/core@REL1_37] Deprecate the UndeleteForm::showRevision hook

https://gerrit.wikimedia.org/r/724208

gerritbot added a comment.Sep 27 2021, 11:17 PM

Change 724208 abandoned by Daimona Eaytoy:

[mediawiki/core@REL1_37] Deprecate the UndeleteForm::showRevision hook

Reason:

Urgh, I should have written this against master instead

https://gerrit.wikimedia.org/r/724208

gerritbot added a comment.Sep 28 2021, 12:04 AM

Change 724211 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/extensions/Newsletter@master] Switch to new PageUndelete hook

https://gerrit.wikimedia.org/r/724211

gerritbot added a comment.Sep 28 2021, 12:07 AM

Change 724204 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/core@master] Deprecate the UndeleteForm::showRevision hook

https://gerrit.wikimedia.org/r/724204

gerritbot added a comment.Sep 28 2021, 12:24 AM

Change 724213 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/core@master] Remove UndeleteForm::undelete hook

https://gerrit.wikimedia.org/r/724213

gerritbot added a comment.Sep 28 2021, 11:49 AM

Change 724408 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/core@master] Use UndeletePage from Special:Undelete

https://gerrit.wikimedia.org/r/724408

Daimona mentioned this in T246408: Video undeletion hook is non-functional.Sep 28 2021, 12:08 PM
Daimona added a comment.Sep 28 2021, 2:06 PM

I think at this point, everything needed for this task should be up for review on gerrit. There are still a few things that can be improved (e.g. moving more code to UndeletePage that is executed in both ApiUndelete and SpecialUndelete), but that can be done later.

gerritbot added a comment.Sep 28 2021, 7:21 PM

Change 724204 merged by jenkins-bot:

[mediawiki/core@master] Deprecate the UndeleteForm::undelete hook

https://gerrit.wikimedia.org/r/724204

ReleaseTaggerBot edited projects, added MW-1.38-notes (1.38.0-wmf.3; 2021-10-05); removed MW-1.38-notes (1.38.0-wmf.2; 2021-09-28).Sep 28 2021, 8:00 PM
gerritbot added a comment.Sep 28 2021, 9:15 PM

Change 724384 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/core@REL1_37] Deprecate the UndeleteForm::undelete hook

https://gerrit.wikimedia.org/r/724384

gerritbot added a comment.Sep 29 2021, 4:29 PM

Change 724384 merged by jenkins-bot:

[mediawiki/core@REL1_37] Deprecate the UndeleteForm::undelete hook

https://gerrit.wikimedia.org/r/724384

ReleaseTaggerBot added a project: MW-1.37-notes.Sep 29 2021, 5:00 PM
gerritbot added a comment.Sep 30 2021, 4:42 PM

Change 724211 merged by jenkins-bot:

[mediawiki/extensions/Newsletter@master] Switch to new PageUndelete hook

https://gerrit.wikimedia.org/r/724211

gerritbot added a comment.Sep 30 2021, 5:04 PM

Change 724975 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/extensions/Newsletter@REL1_37] Switch to new PageUndelete hook

https://gerrit.wikimedia.org/r/724975

gerritbot added a comment.Sep 30 2021, 5:48 PM

Change 724975 merged by jenkins-bot:

[mediawiki/extensions/Newsletter@REL1_37] Switch to new PageUndelete hook

https://gerrit.wikimedia.org/r/724975

gerritbot added a comment.Oct 1 2021, 12:57 AM

Change 724213 merged by jenkins-bot:

[mediawiki/core@master] Remove UndeleteForm::undelete hook

https://gerrit.wikimedia.org/r/724213

gerritbot added a comment.Oct 1 2021, 6:09 PM

Change 715592 merged by jenkins-bot:

[mediawiki/core@master] Use fluent setters instead of optional params in UndeletePage

https://gerrit.wikimedia.org/r/715592

gerritbot added a comment.Oct 4 2021, 9:00 PM

Change 715596 merged by jenkins-bot:

[mediawiki/core@master] Add perm checks to UndeletePage and make it a real service

https://gerrit.wikimedia.org/r/715596

ldelench_wmf edited projects, added Community-Tech (CommTech-Sprint-11); removed Community-Tech (CommTech-Sprint-10).Oct 11 2021, 1:51 PM
ldelench_wmf moved this task from Ready 🎬 to Review/Feedback 💬 on the Community-Tech (CommTech-Sprint-11) board.
ldelench_wmf moved this task from CommTech-Sprint-11 to CommTech-Sprint-12 on the Community-Tech board.Oct 25 2021, 8:01 PM
ldelench_wmf edited projects, added Community-Tech (CommTech-Sprint-12); removed Community-Tech (CommTech-Sprint-11).
ldelench_wmf moved this task from Ready 🎬 to Review/Feedback 💬 on the Community-Tech (CommTech-Sprint-12) board.
gerritbot added a comment.Oct 28 2021, 5:05 AM

Change 724197 merged by jenkins-bot:

[mediawiki/core@master] Use UndeletePage from ApiUndelete

https://gerrit.wikimedia.org/r/724197

ReleaseTaggerBot edited projects, added MW-1.38-notes (1.38.0-wmf.7; 2021-11-02); removed MW-1.38-notes (1.38.0-wmf.3; 2021-10-05).Oct 28 2021, 6:00 AM
ldelench_wmf moved this task from CommTech-Sprint-12 to CommTech-Sprint-13 on the Community-Tech board.Nov 8 2021, 9:59 PM
ldelench_wmf edited projects, added Community-Tech (CommTech-Sprint-13); removed Community-Tech (CommTech-Sprint-12).
ldelench_wmf moved this task from Ready 🎬 to Review/Feedback 💬 on the Community-Tech (CommTech-Sprint-13) board.
ldelench_wmf edited projects, added Community-Tech (CommTech-Sprint-14); removed Community-Tech (CommTech-Sprint-13).Nov 22 2021, 9:34 PM
ldelench_wmf moved this task from Ready 🎬 to Review/Feedback 💬 on the Community-Tech (CommTech-Sprint-14) board.Nov 22 2021, 9:37 PM
matej_suchanek merged a task: T279153: PageArchive::undeleteAsUser has to become a command.Nov 29 2021, 1:51 PM
matej_suchanek added a subscriber: • Pchelolo.
gerritbot added a comment.Nov 29 2021, 5:54 PM

Change 724408 merged by jenkins-bot:

[mediawiki/core@master] Use UndeletePage from Special:Undelete

https://gerrit.wikimedia.org/r/724408

ReleaseTaggerBot edited projects, added MW-1.38-notes (1.38.0-wmf.12; 2021-12-06); removed MW-1.38-notes (1.38.0-wmf.7; 2021-11-02).Nov 29 2021, 6:00 PM
Daimona moved this task from Review/Feedback 💬 to QA 🐛 on the Community-Tech (CommTech-Sprint-14) board.Nov 30 2021, 11:17 AM

No new features were added, so we would like to make sure that Special:Undelete and the undelete API module are still working as expected; a few suggestions:

  • Ensure consistency when undeleting files (as opposed to articles)
  • Test behaviour when selectively restoring only some file versions and/or page revisions
  • No need to test this on pages with many deleted revisions; in fact, that will probably timeout and fail
  • Ensure that errors are displayed correctly, for instance if there are no revisions to undelete (e.g. submit the form twice)
ldelench_wmf edited projects, added Community-Tech (CommTech-Sprint-15); removed Community-Tech (CommTech-Sprint-14).Dec 3 2021, 7:49 PM
ldelench_wmf moved this task from Ready 🎬 to QA 🐛 on the Community-Tech (CommTech-Sprint-15) board.Dec 3 2021, 7:52 PM
dom_walden moved this task from QA 🐛 to Product sign-off 🤘 on the Community-Tech (CommTech-Sprint-15) board.EditedDec 10 2021, 4:03 PM
dom_walden subscribed.

Sorry I don't have time to do a comprehensive write up, I will just bullet list broadly what I did:

What I didn't test:

  • That the information on the Special:Undelete form itself was correct (although I saw nothing obviously wrong)
  • Other parts of the software that do undelete/restore (if these exist, I didn't have time to look)

Where I was unsure about the behaviour, I compared to what the behaviour was like before the start of this project.

I also had logstash open the whole time to check any errors on testwiki. I saw none.

Test environment: https://test.wikipedia.org MediaWiki 1.38.0-wmf.12 (rMW365159bc6352) 12:49, 9 December 2021.

• NRodriguez closed this task as Resolved.Dec 16 2021, 4:34 PM
ldelench_wmf moved this task from Product sign-off 🤘 to Done 🏁 on the Community-Tech (CommTech-Sprint-15) board.Dec 20 2021, 3:04 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL