Page MenuHomePhabricator

Make PropertyId into an interface and introduce NumericPropertyId
Open, Needs TriagePublic

Description

  • Introduce NumericPropertyId
  • Replace PropertyId instantiations in all libraries and extensions with it (remember to release the libraries at some point)
  • Make a patch in Wikibase which deletes PropertyId the class and adds the interface. Look through all the errors and figure out which ones are a NumericPropertyId and replace them
  • Rename FederatedPropertyId to URIPropertyId and think about moving it to the data-model package

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/WikibaseLexememaster+6 -5
mediawiki/extensions/WikibaseMediaInfomaster+8 -7
mediawiki/extensions/Wikibasemaster+228 -21
mediawiki/extensions/WikibaseQualityConstraintsmaster+4 -2
mediawiki/extensions/Wikibasemaster+2 -1
mediawiki/extensions/Wikibasemaster+15 -272
mediawiki/extensions/Wikibasemaster+135 -135
mediawiki/extensions/Wikibasemaster+28 -28
mediawiki/extensions/Wikibasemaster+8 -8
mediawiki/extensions/Wikibasemaster+30 -30
mediawiki/extensions/WikibaseLexememaster+0 -1
mediawiki/extensions/WikibaseQualityConstraintsmaster+0 -5
mediawiki/extensions/WikibaseQualityConstraintsmaster+19 -15
mediawiki/extensions/Wikibasemaster+208 -202
mediawiki/extensions/Wikibasemaster+222 -222
mediawiki/extensions/MathSearchmaster+8 -8
mediawiki/extensions/MachineVisionmaster+2 -2
mediawiki/extensions/Mathmaster+7 -7
mediawiki/extensions/Wikisourcemaster+19 -19
mediawiki/extensions/WikimediaBadgesmaster+7 -7
mediawiki/extensions/WikibaseLexemeCirrusSearchmaster+11 -11
mediawiki/extensions/ArticlePlaceholdermaster+8 -8
mediawiki/extensions/WikibaseMediaInfomaster+34 -34
mediawiki/extensions/WikibaseQualityConstraintsmaster+0 -2
mediawiki/extensions/WikibaseCirrusSearchmaster+8 -8
mediawiki/extensions/WikibaseMediaInfomaster+865 -770
mediawiki/extensions/Wikibasemaster+303 -296
mediawiki/extensions/WikibaseMediaInfomaster+295 -290
mediawiki/extensions/WikibaseQualityConstraintsmaster+621 -566
mediawiki/extensions/PropertySuggestermaster+64 -62
mediawiki/extensions/Wikibasemaster+549 -532
mediawiki/extensions/Wikibasemaster+282 -0
Show related patches Customize query in gerrit

Event Timeline

Change 719267 had a related patch set uploaded (by Tonina Zhelyazkova; author: Tonina Zhelyazkova):

[mediawiki/extensions/Wikibase@master] Introduce NumericPropertyId to data-model

https://gerrit.wikimedia.org/r/719267

Change 719286 had a related patch set uploaded (by Tonina Zhelyazkova; author: Tonina Zhelyazkova):

[mediawiki/extensions/Wikibase@master] Replace usage of PropertyId with NumericPropertyId

https://gerrit.wikimedia.org/r/719286

Change 719525 had a related patch set uploaded (by Tonina Zhelyazkova; author: Tonina Zhelyazkova):

[mediawiki/extensions/Wikibase@master] FP: Change PropertyId to NumericPropertyId

https://gerrit.wikimedia.org/r/719525

Change 719267 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Introduce NumericPropertyId to data-model

https://gerrit.wikimedia.org/r/719267

Change 719525 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] FP: Change PropertyId to NumericPropertyId

https://gerrit.wikimedia.org/r/719525

Change 720999 had a related patch set uploaded (by Tonina Zhelyazkova; author: Tonina Zhelyazkova):

[mediawiki/extensions/Wikibase@master] FP: Wikibase/lib - replace PropertyId with NumericPropertyId

https://gerrit.wikimedia.org/r/720999

Change 721329 had a related patch set uploaded (by Tonina Zhelyazkova; author: Tonina Zhelyazkova):

[mediawiki/extensions/WikibaseQualityConstraints@master] FP: Change PropertyId to NumericPropertyId

https://gerrit.wikimedia.org/r/721329

Change 721499 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/PropertySuggester@master] FP: Change PropertyId to NumericPropertyId

https://gerrit.wikimedia.org/r/721499

Change 721499 merged by jenkins-bot:

[mediawiki/extensions/PropertySuggester@master] FP: Change PropertyId to NumericPropertyId

https://gerrit.wikimedia.org/r/721499

Change 721521 had a related patch set uploaded (by Tonina Zhelyazkova; author: Tonina Zhelyazkova):

[mediawiki/extensions/WikibaseQualityConstraints@master] Re-enable ConstraintParameterParserTest

https://gerrit.wikimedia.org/r/721521

Change 721558 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/WikibaseCirrusSearch@master] FP: Change PropertyId to NumericPropertyId

https://gerrit.wikimedia.org/r/721558

Change 721559 had a related patch set uploaded (by Tonina Zhelyazkova; author: Tonina Zhelyazkova):

[mediawiki/extensions/WikibaseMediaInfo@master] FP: Change PropertyId to NumericPropertyId

https://gerrit.wikimedia.org/r/721559

Change 721329 merged by jenkins-bot:

[mediawiki/extensions/WikibaseQualityConstraints@master] FP: Change PropertyId to NumericPropertyId

https://gerrit.wikimedia.org/r/721329

Change 720999 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] FP: Wikibase/lib - replace PropertyId with NumericPropertyId

https://gerrit.wikimedia.org/r/720999

Change 721576 had a related patch set uploaded (by Tonina Zhelyazkova; author: Tonina Zhelyazkova):

[mediawiki/extensions/WikibaseMediaInfo@master] FP: Change PropertyId to NumericPropertyId

https://gerrit.wikimedia.org/r/721576

Change 721559 abandoned by Tonina Zhelyazkova:

[mediawiki/extensions/WikibaseMediaInfo@master] FP: Change PropertyId to NumericPropertyId

Reason:

too many code style changes. see I36854741e91a2cc5f4864bbfb23fae74393dd77f

https://gerrit.wikimedia.org/r/721559

Change 721576 abandoned by Tonina Zhelyazkova:

[mediawiki/extensions/WikibaseMediaInfo@master] FP: Change PropertyId to NumericPropertyId

Reason:

https://gerrit.wikimedia.org/r/721576

Change 721580 had a related patch set uploaded (by Tonina Zhelyazkova; author: Tonina Zhelyazkova):

[mediawiki/extensions/WikibaseMediaInfo@master] FP: Change PropertyId to NumericPropertyId

https://gerrit.wikimedia.org/r/721580

Change 721521 merged by jenkins-bot:

[mediawiki/extensions/WikibaseQualityConstraints@master] Re-enable ConstraintParameterParserTest

https://gerrit.wikimedia.org/r/721521

Change 721558 merged by jenkins-bot:

[mediawiki/extensions/WikibaseCirrusSearch@master] FP: Change PropertyId to NumericPropertyId

https://gerrit.wikimedia.org/r/721558

Change 721759 had a related patch set uploaded (by Tonina Zhelyazkova; author: Tonina Zhelyazkova):

[mediawiki/extensions/ArticlePlaceholder@master] FP: Change PropertyId to NumericPropertyId

https://gerrit.wikimedia.org/r/721759

Change 721762 had a related patch set uploaded (by Tonina Zhelyazkova; author: Tonina Zhelyazkova):

[mediawiki/extensions/WikimediaBadges@master] FP: Change PropertyId to NumericPropertyId

https://gerrit.wikimedia.org/r/721762

Change 721580 merged by jenkins-bot:

[mediawiki/extensions/WikibaseMediaInfo@master] FP: Change PropertyId to NumericPropertyId

https://gerrit.wikimedia.org/r/721580

Change 721764 had a related patch set uploaded (by Tonina Zhelyazkova; author: Tonina Zhelyazkova):

[mediawiki/extensions/WikibaseLexemeCirrusSearch@master] FP: Change PropertyId to NumericPropertyId

https://gerrit.wikimedia.org/r/721764

Change 721765 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/Math@master] FP: Change PropertyId to NumericPropertyId

https://gerrit.wikimedia.org/r/721765

Change 721759 merged by jenkins-bot:

[mediawiki/extensions/ArticlePlaceholder@master] FP: Change PropertyId to NumericPropertyId

https://gerrit.wikimedia.org/r/721759

Change 721769 had a related patch set uploaded (by Rosalie Perside (WMDE); author: Rosalie Perside (WMDE)):

[mediawiki/extensions/Wikisource@master] FP: Change PropertyId to NumericPropertyId

https://gerrit.wikimedia.org/r/721769

Change 721764 merged by jenkins-bot:

[mediawiki/extensions/WikibaseLexemeCirrusSearch@master] FP: Change PropertyId to NumericPropertyId

https://gerrit.wikimedia.org/r/721764

Change 721762 merged by jenkins-bot:

[mediawiki/extensions/WikimediaBadges@master] FP: Change PropertyId to NumericPropertyId

https://gerrit.wikimedia.org/r/721762

Change 721778 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/WikibaseQualityConstraints@master] FP: Prepare for data-model switch to NumericPropertyId

https://gerrit.wikimedia.org/r/721778

Change 721769 merged by jenkins-bot:

[mediawiki/extensions/Wikisource@master] FP: Change PropertyId to NumericPropertyId

https://gerrit.wikimedia.org/r/721769

Change 721785 had a related patch set uploaded (by Tonina Zhelyazkova; author: Tonina Zhelyazkova):

[mediawiki/extensions/MathSearch@master] FP: Change PropertyId to NumericPropertyId

https://gerrit.wikimedia.org/r/721785

Change 721765 merged by jenkins-bot:

[mediawiki/extensions/Math@master] FP: Change PropertyId to NumericPropertyId

https://gerrit.wikimedia.org/r/721765

Change 721807 had a related patch set uploaded (by Tonina Zhelyazkova; author: Tonina Zhelyazkova):

[mediawiki/extensions/MachineVision@master] FP: Change PropertyId to NumericPropertyId

https://gerrit.wikimedia.org/r/721807

Change 721270 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/Wikibase@master] FP: Change PropertyId to NumericPropertyId in data-model

https://gerrit.wikimedia.org/r/721270

Change 721816 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/WikibaseQualityConstraints@master] FP: Unskip skipped tests after migration

https://gerrit.wikimedia.org/r/721816

Change 721817 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/WikibaseLexeme@master] FP: Unskip skipped tests after migration

https://gerrit.wikimedia.org/r/721817

Change 721807 merged by jenkins-bot:

[mediawiki/extensions/MachineVision@master] FP: Change PropertyId to NumericPropertyId

https://gerrit.wikimedia.org/r/721807

Change 721785 abandoned by Tonina Zhelyazkova:

[mediawiki/extensions/MathSearch@master] FP: Change PropertyId to NumericPropertyId

Reason:

The CI of this extension has been broken for a while => we can't verify our changes.

https://gerrit.wikimedia.org/r/721785

Change 719286 abandoned by Tonina Zhelyazkova:

[mediawiki/extensions/Wikibase@master] Replace usage of PropertyId with NumericPropertyId

Reason:

I57e89a760a9c45b3a0e8788b07777c022e850679

https://gerrit.wikimedia.org/r/719286

Change 722359 had a related patch set uploaded (by Tonina Zhelyazkova; author: Tonina Zhelyazkova):

[mediawiki/extensions/Wikibase@master] FP: Change PropertyId to NumericPropertyId

https://gerrit.wikimedia.org/r/722359

Change 721778 merged by jenkins-bot:

[mediawiki/extensions/WikibaseQualityConstraints@master] FP: Prepare for data-model switch to NumericPropertyId

https://gerrit.wikimedia.org/r/721778

Change 721270 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] FP: Change PropertyId to NumericPropertyId in data-model

https://gerrit.wikimedia.org/r/721270

Change 721817 merged by jenkins-bot:

[mediawiki/extensions/WikibaseLexeme@master] FP: Unskip skipped tests after migration

https://gerrit.wikimedia.org/r/721817

Change 721816 merged by jenkins-bot:

[mediawiki/extensions/WikibaseQualityConstraints@master] FP: Unskip skipped tests after migration

https://gerrit.wikimedia.org/r/721816

Change 722369 had a related patch set uploaded (by Tonina Zhelyazkova; author: Tonina Zhelyazkova):

[mediawiki/extensions/Wikibase@master] FP: Change PropertyId to NumericPropertyId

https://gerrit.wikimedia.org/r/722369

Change 722359 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] FP: Change PropertyId to NumericPropertyId

https://gerrit.wikimedia.org/r/722359

Change 722369 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] FP: Change PropertyId to NumericPropertyId

https://gerrit.wikimedia.org/r/722369

Change 722570 had a related patch set uploaded (by Tonina Zhelyazkova; author: Tonina Zhelyazkova):

[mediawiki/extensions/Wikibase@master] FP: Change PropertyId instances

https://gerrit.wikimedia.org/r/722570

Change 722641 had a related patch set uploaded (by Tonina Zhelyazkova; author: Tonina Zhelyazkova):

[mediawiki/extensions/Wikibase@master] FP: Change PropertyId to NumericPropertyId

https://gerrit.wikimedia.org/r/722641

Change 722570 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] FP: Change PropertyId instances

https://gerrit.wikimedia.org/r/722570

Change 722641 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] FP: Change PropertyId to NumericPropertyId

https://gerrit.wikimedia.org/r/722641

Change 722839 had a related patch set uploaded (by Tonina Zhelyazkova; author: Tonina Zhelyazkova):

[mediawiki/extensions/Wikibase@master] Make PropertyId an interface

https://gerrit.wikimedia.org/r/722839

Change 723182 had a related patch set uploaded (by Tonina Zhelyazkova; author: Tonina Zhelyazkova):

[mediawiki/extensions/Wikibase@master] Create an EntityId interface

https://gerrit.wikimedia.org/r/723182

Change 723438 had a related patch set uploaded (by Tonina Zhelyazkova; author: Tonina Zhelyazkova):

[mediawiki/extensions/WikibaseLexeme@master] Use SerializableEntityId instead of EntityId

https://gerrit.wikimedia.org/r/723438

Change 723469 had a related patch set uploaded (by Tonina Zhelyazkova; author: Tonina Zhelyazkova):

[mediawiki/extensions/WikibaseMediaInfo@master] Use SerializableEntityId instead of EntityId

https://gerrit.wikimedia.org/r/723469

Change 723472 had a related patch set uploaded (by Tonina Zhelyazkova; author: Tonina Zhelyazkova):

[mediawiki/extensions/WikibaseQualityConstraints@master] Use SerializableEntityId instead of EntityId

https://gerrit.wikimedia.org/r/723472

Change 723486 had a related patch set uploaded (by Tonina Zhelyazkova; author: Tonina Zhelyazkova):

[mediawiki/extensions/Wikibase@master] Replace the last instance of EntityId with SerializableEntityId

https://gerrit.wikimedia.org/r/723486

Change 723486 abandoned by Tonina Zhelyazkova:

[mediawiki/extensions/Wikibase@master] Replace the last instance of EntityId with SerializableEntityId

Reason:

https://gerrit.wikimedia.org/r/723486

Change 723182 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Add SerializableEntityId class

https://gerrit.wikimedia.org/r/723182

Change 723472 merged by jenkins-bot:

[mediawiki/extensions/WikibaseQualityConstraints@master] Use SerializableEntityId instead of EntityId

https://gerrit.wikimedia.org/r/723472

Change 723469 merged by jenkins-bot:

[mediawiki/extensions/WikibaseMediaInfo@master] Use SerializableEntityId instead of EntityId

https://gerrit.wikimedia.org/r/723469

Change 723438 merged by jenkins-bot:

[mediawiki/extensions/WikibaseLexeme@master] Use SerializableEntityId instead of EntityId

https://gerrit.wikimedia.org/r/723438