- Introduce NumericPropertyId
- Replace PropertyId instantiations in all libraries and extensions with it (remember to release the libraries at some point)
- Make a patch in Wikibase which deletes PropertyId the class and adds the interface. Look through all the errors and figure out which ones are a NumericPropertyId and replace them
Description
Details
Status | Subtype | Assigned | Task | ||
---|---|---|---|---|---|
Resolved | None | T288234 Create a Property ID interface and use it | |||
Resolved | • Tonina_Zhelyazkova_WMDE | T289125 Make PropertyId into an interface and introduce NumericPropertyId | |||
Resolved | Jakob_WMDE | T290980 Use NumericPropertyId in WikibaseLexeme | |||
Resolved | Jakob_WMDE | T291810 Change the abstract class EntityId into an interface | |||
Open | None | T291811 Rename `FederatedPropertyId` to `URIPropertyId` |
Event Timeline
Change 719525 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] FP: Change PropertyId to NumericPropertyId
Change 720999 had a related patch set uploaded (by Tonina Zhelyazkova; author: Tonina Zhelyazkova):
[mediawiki/extensions/Wikibase@master] FP: Wikibase/lib - replace PropertyId with NumericPropertyId
Change 721329 had a related patch set uploaded (by Tonina Zhelyazkova; author: Tonina Zhelyazkova):
[mediawiki/extensions/WikibaseQualityConstraints@master] FP: Change PropertyId to NumericPropertyId
Change 721499 had a related patch set uploaded (by Jakob; author: Jakob):
[mediawiki/extensions/PropertySuggester@master] FP: Change PropertyId to NumericPropertyId
Change 721499 merged by jenkins-bot:
[mediawiki/extensions/PropertySuggester@master] FP: Change PropertyId to NumericPropertyId
Change 721521 had a related patch set uploaded (by Tonina Zhelyazkova; author: Tonina Zhelyazkova):
[mediawiki/extensions/WikibaseQualityConstraints@master] Re-enable ConstraintParameterParserTest
Change 721558 had a related patch set uploaded (by Jakob; author: Jakob):
[mediawiki/extensions/WikibaseCirrusSearch@master] FP: Change PropertyId to NumericPropertyId
Change 721559 had a related patch set uploaded (by Tonina Zhelyazkova; author: Tonina Zhelyazkova):
[mediawiki/extensions/WikibaseMediaInfo@master] FP: Change PropertyId to NumericPropertyId
Change 721329 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] FP: Change PropertyId to NumericPropertyId
Change 720999 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] FP: Wikibase/lib - replace PropertyId with NumericPropertyId
Change 721576 had a related patch set uploaded (by Tonina Zhelyazkova; author: Tonina Zhelyazkova):
[mediawiki/extensions/WikibaseMediaInfo@master] FP: Change PropertyId to NumericPropertyId
Change 721559 abandoned by Tonina Zhelyazkova:
[mediawiki/extensions/WikibaseMediaInfo@master] FP: Change PropertyId to NumericPropertyId
Reason:
too many code style changes. see I36854741e91a2cc5f4864bbfb23fae74393dd77f
Change 721576 abandoned by Tonina Zhelyazkova:
[mediawiki/extensions/WikibaseMediaInfo@master] FP: Change PropertyId to NumericPropertyId
Reason:
Change 721580 had a related patch set uploaded (by Tonina Zhelyazkova; author: Tonina Zhelyazkova):
[mediawiki/extensions/WikibaseMediaInfo@master] FP: Change PropertyId to NumericPropertyId
Change 721521 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Re-enable ConstraintParameterParserTest
Change 721558 merged by jenkins-bot:
[mediawiki/extensions/WikibaseCirrusSearch@master] FP: Change PropertyId to NumericPropertyId
Change 721759 had a related patch set uploaded (by Tonina Zhelyazkova; author: Tonina Zhelyazkova):
[mediawiki/extensions/ArticlePlaceholder@master] FP: Change PropertyId to NumericPropertyId
Change 721762 had a related patch set uploaded (by Tonina Zhelyazkova; author: Tonina Zhelyazkova):
[mediawiki/extensions/WikimediaBadges@master] FP: Change PropertyId to NumericPropertyId
Change 721580 merged by jenkins-bot:
[mediawiki/extensions/WikibaseMediaInfo@master] FP: Change PropertyId to NumericPropertyId
Change 721764 had a related patch set uploaded (by Tonina Zhelyazkova; author: Tonina Zhelyazkova):
[mediawiki/extensions/WikibaseLexemeCirrusSearch@master] FP: Change PropertyId to NumericPropertyId
Change 721765 had a related patch set uploaded (by Jakob; author: Jakob):
[mediawiki/extensions/Math@master] FP: Change PropertyId to NumericPropertyId
Change 721759 merged by jenkins-bot:
[mediawiki/extensions/ArticlePlaceholder@master] FP: Change PropertyId to NumericPropertyId
Change 721769 had a related patch set uploaded (by Rosalie Perside (WMDE); author: Rosalie Perside (WMDE)):
[mediawiki/extensions/Wikisource@master] FP: Change PropertyId to NumericPropertyId
Change 721764 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexemeCirrusSearch@master] FP: Change PropertyId to NumericPropertyId
Change 721762 merged by jenkins-bot:
[mediawiki/extensions/WikimediaBadges@master] FP: Change PropertyId to NumericPropertyId
Change 721778 had a related patch set uploaded (by Jakob; author: Jakob):
[mediawiki/extensions/WikibaseQualityConstraints@master] FP: Prepare for data-model switch to NumericPropertyId
Change 721769 merged by jenkins-bot:
[mediawiki/extensions/Wikisource@master] FP: Change PropertyId to NumericPropertyId
Change 721785 had a related patch set uploaded (by Tonina Zhelyazkova; author: Tonina Zhelyazkova):
[mediawiki/extensions/MathSearch@master] FP: Change PropertyId to NumericPropertyId
Change 721765 merged by jenkins-bot:
[mediawiki/extensions/Math@master] FP: Change PropertyId to NumericPropertyId
Change 721807 had a related patch set uploaded (by Tonina Zhelyazkova; author: Tonina Zhelyazkova):
[mediawiki/extensions/MachineVision@master] FP: Change PropertyId to NumericPropertyId
Change 721270 had a related patch set uploaded (by Jakob; author: Jakob):
[mediawiki/extensions/Wikibase@master] FP: Change PropertyId to NumericPropertyId in data-model
Change 721816 had a related patch set uploaded (by Jakob; author: Jakob):
[mediawiki/extensions/WikibaseQualityConstraints@master] FP: Unskip skipped tests after migration
Change 721817 had a related patch set uploaded (by Jakob; author: Jakob):
[mediawiki/extensions/WikibaseLexeme@master] FP: Unskip skipped tests after migration
Change 721807 merged by jenkins-bot:
[mediawiki/extensions/MachineVision@master] FP: Change PropertyId to NumericPropertyId
Change 721785 abandoned by Tonina Zhelyazkova:
[mediawiki/extensions/MathSearch@master] FP: Change PropertyId to NumericPropertyId
Reason:
The CI of this extension has been broken for a while => we can't verify our changes.
Change 719286 abandoned by Tonina Zhelyazkova:
[mediawiki/extensions/Wikibase@master] Replace usage of PropertyId with NumericPropertyId
Reason:
I57e89a760a9c45b3a0e8788b07777c022e850679
Change 722359 had a related patch set uploaded (by Tonina Zhelyazkova; author: Tonina Zhelyazkova):
[mediawiki/extensions/Wikibase@master] FP: Change PropertyId to NumericPropertyId
Change 721778 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] FP: Prepare for data-model switch to NumericPropertyId
Change 721270 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] FP: Change PropertyId to NumericPropertyId in data-model
Change 721817 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] FP: Unskip skipped tests after migration
Change 721816 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] FP: Unskip skipped tests after migration
Change 722369 had a related patch set uploaded (by Tonina Zhelyazkova; author: Tonina Zhelyazkova):
[mediawiki/extensions/Wikibase@master] FP: Change PropertyId to NumericPropertyId
Change 722359 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] FP: Change PropertyId to NumericPropertyId
Change 722369 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] FP: Change PropertyId to NumericPropertyId
Change 722570 had a related patch set uploaded (by Tonina Zhelyazkova; author: Tonina Zhelyazkova):
[mediawiki/extensions/Wikibase@master] FP: Change PropertyId instances
Change 722641 had a related patch set uploaded (by Tonina Zhelyazkova; author: Tonina Zhelyazkova):
[mediawiki/extensions/Wikibase@master] FP: Change PropertyId to NumericPropertyId
Change 722570 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] FP: Change PropertyId instances
Change 722641 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] FP: Change PropertyId to NumericPropertyId
Change 722839 had a related patch set uploaded (by Tonina Zhelyazkova; author: Tonina Zhelyazkova):
[mediawiki/extensions/Wikibase@master] Make PropertyId an interface
Change 723182 had a related patch set uploaded (by Tonina Zhelyazkova; author: Tonina Zhelyazkova):
[mediawiki/extensions/Wikibase@master] Create an EntityId interface
Change 723438 had a related patch set uploaded (by Tonina Zhelyazkova; author: Tonina Zhelyazkova):
[mediawiki/extensions/WikibaseLexeme@master] Use SerializableEntityId instead of EntityId
Change 723469 had a related patch set uploaded (by Tonina Zhelyazkova; author: Tonina Zhelyazkova):
[mediawiki/extensions/WikibaseMediaInfo@master] Use SerializableEntityId instead of EntityId
Change 723472 had a related patch set uploaded (by Tonina Zhelyazkova; author: Tonina Zhelyazkova):
[mediawiki/extensions/WikibaseQualityConstraints@master] Use SerializableEntityId instead of EntityId
Change 723486 had a related patch set uploaded (by Tonina Zhelyazkova; author: Tonina Zhelyazkova):
[mediawiki/extensions/Wikibase@master] Replace the last instance of EntityId with SerializableEntityId
Change 723486 abandoned by Tonina Zhelyazkova:
[mediawiki/extensions/Wikibase@master] Replace the last instance of EntityId with SerializableEntityId
Reason:
Change 723182 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Add SerializableEntityId class
Change 723472 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Use SerializableEntityId instead of EntityId
Change 723469 merged by jenkins-bot:
[mediawiki/extensions/WikibaseMediaInfo@master] Use SerializableEntityId instead of EntityId
Change 723438 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Use SerializableEntityId instead of EntityId
Change 724016 had a related patch set uploaded (by Jakob; author: Jakob):
[mediawiki/extensions/Wikibase@master] Make PropertyId an interface
Change 724018 had a related patch set uploaded (by Jakob; author: Jakob):
[mediawiki/extensions/Wikibase@master] FP: Change PropertyId to NumericPropertyId
Change 724018 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] FP: Change PropertyId to NumericPropertyId
Change 722839 abandoned by Tonina Zhelyazkova:
[mediawiki/extensions/Wikibase@master] Make PropertyId an interface
Reason:
done in Ic1a965f4e0ad331cd77d6a5a7d99da041f06da89
Change 724939 had a related patch set uploaded (by Jakob; author: Jakob):
[mediawiki/extensions/Wikibase@master] LabelUniquenessValidatorTest: use NumericPropertyId
Change 724939 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] LabelUniquenessValidatorTest: use NumericPropertyId
Change 724016 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Make PropertyId an interface
Change 726979 had a related patch set uploaded (by Zabe; author: Zabe):
[mediawiki/extensions/WikidataPageBanner@master] Change PropertyId to NumericPropertyId
Change 726979 merged by jenkins-bot:
[mediawiki/extensions/WikidataPageBanner@master] Change PropertyId to NumericPropertyId
Change 727188 had a related patch set uploaded (by Zabe; author: Zabe):
[mediawiki/extensions/WikidataPageBanner@wmf/1.38.0-wmf.3] Change PropertyId to NumericPropertyId
Change 727188 merged by jenkins-bot:
[mediawiki/extensions/WikidataPageBanner@wmf/1.38.0-wmf.3] Change PropertyId to NumericPropertyId
Mentioned in SAL (#wikimedia-operations) [2021-10-07T11:44:44Z] <lucaswerkmeister-wmde@deploy1002> Synchronized php-1.38.0-wmf.3/extensions/WikidataPageBanner/includes/WikidataPageBannerFunctions.php: Backport: [[gerrit:727188|Change PropertyId to NumericPropertyId (T289125, T292667)]] (duration: 01m 05s)
Change 730537 had a related patch set uploaded (by Jakob; author: Jakob):
[mediawiki/extensions/PropertySuggester@master] Typehint NumericPropertyId where necessary
Change 730537 merged by jenkins-bot:
[mediawiki/extensions/PropertySuggester@master] Typehint NumericPropertyId where necessary
This is kinda painful for anything outside of Wikibase that relies on this PHP code such as extensions or tools. Firstly there is no deprecation period, the breaking change just instantly happens. Secondly, and more painfully, the new alternative is only introduce at time of breaking change, making it super difficult to support both old and new Wikibase.