Hi @Samwalton9, can I work on this?

@Ajay47 This depends on T270115 being worked on first, which we plan to do ourselves. Maybe you could work on T289255?

Thank you, @Samwalton9.

I moved the explanatory string to the Key in the design for T270115 so we don't need that to be next to the filter anymore.

@Samwalton9 can I work on this?

@Himanshunitw This is something that our team is going to work on. Perhaps you want to take T291487 instead?

Ya Sure!

GitHub PR: https://github.com/WikipediaLibrary/TWLight/pull/824

We discussed this at engineering meeting and decided that three checkboxes would be a better way of enabling this filter:

• Fully searchable
• Partially searchable
• Not searchable

They should all be selected by default.

I commented in that PR, but wanted to surface it for @Samwalton9. Would this be acceptable?
https://github.com/WikipediaLibrary/TWLight/pull/826#discussion_r719559680

If there's no other obvious solution I'd say it's better than not having the boxes checked by default :)

Django filters has lots of ways you can override things, but doing so increases the likelihood of creating bugs. Doing it this way has the advantage of using django filters exactly the way it was meant to be used. I guess my question is this: is there a problem with this solution? Is it big enough to compel us to spend time finding another solution?

I spent some time fiddling with it and got it working (at least it looks like it's working at first blush), will update review

I just kicked off a new build for staging with this change. Will update when it's live.

This looks to be working really well, I wasn't able to break anything :)