VisualEditor `create`/`edit` link is irregular font-size when collapsed at lower resolutions
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	Jdlrobson
	Sep 29 2021, 9:29 PM

Description

For some reason the VisualEditor create link is rendering without the span that is meant to wrap the label.

QA steps

Load a page that doesn't exist with VisualEditor enabled
Shrink the page so that the "create" link collapses into the more menu

Expected: The edit link font-size matches the other links
Actual:

Screen Shot 2021-09-29 at 2.22.46 PM.png (498×1 px, 109 KB)

Developer notes

The HTML generated looks like:

<li id="ca-ve-edit" class="mw-list-item collapsible" style="display: block;"><a href="/w/index.php?title=Supporting_Indian_Language_Wikipedias_Program/Support/sulthan90&amp;veaction=edit" title="Edit this page [⌃⌥v]" accesskey="v">
Edit
</a></li>

but it should be

<li id="ca-ve-edit" class="mw-list-item collapsible" style="display: block;"><a href="/w/index.php?title=Supporting_Indian_Language_Wikipedias_Program/Support/sulthan90&amp;veaction=edit" title="Edit this page [⌃⌥v]" accesskey="v">
<span>Edit</span>
</a></li>

For comparison the edit source link looks fine:

<li id="ca-edit" class="collapsible mw-list-item"><a href="/w/index.php?title=Learning_and_Evaluation/Evaluation_reports/2015/Writing_Contests/Limitations&amp;action=edit" title="Edit this page [⌃⌥e]" accesskey="e"><span>Edit source</span></a></li>

Note the span is added inside Skin::makeLink when $options['text-wrapper'] is set.
I'm not sure why this is not triggering for this particular link.

Could be an issue in VisualEditor or the core Skin code.

Details

	Subject	Repo	Branch	Lines +/-
	DesktopArticleTarget.init: Remove code for updating edit links	mediawiki/extensions/VisualEditor	REL1_39	+4 -129
	DesktopArticleTarget.init: Remove code for updating edit links	mediawiki/extensions/VisualEditor	master	+4 -163

Customize query in gerrit

Event Timeline

Jdlrobson created this task.Sep 29 2021, 9:29 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 29 2021, 9:29 PM

We don't do anything special for Vector. The link is added in the 'SkinTemplateNavigation' hook handler: https://github.com/wikimedia/mediawiki-extensions-VisualEditor/blob/master/includes/VisualEditorHooks.php#L516. This code has worked fine for years, so I suspect a bug in core or in Vector.

I debugged this some more and this is only a problem with JavaScript enabled. The problem disappears when I remove the ext.visualEditor.desktopArticleTarget.init module so this is definitely originating in VisualEditor.

Some code in VisualEditor's ext.visualEditor.desktopArticleTarget.init module is making assumptions about how menu items in Vector are structured and appears to be rewritting the DOM.

This code has worked fine for years, so I suspect a bug in core or in Vector.

The problem is Vector's HTML has changed and some code in VisualEditor is making assumptions about how menu items in Vector are structured.

I think the issue is this line:
https://github.com/wikimedia/mediawiki-extensions-VisualEditor/blob/master/modules/ve-mw/preinit/ve.init.mw.DesktopArticleTarget.init.js#L701
which rewrites all children.

Given portlet links can have children (via text-wrapper option in core Skin) this code is not future proof. It should check to see if there's a child for broadest skin support. We could also add a method in core to accompany addPortletLink to modifyPortletLink since mediawiki.util module knows how these items are structured.

Jdlrobson moved this task from Backlog to Unused 4 on the MediaWiki-Core-Skin-Architecture board.Oct 4 2021, 9:52 PM

Jdlrobson added a project: Web-Team-Backlog.

Jdlrobson moved this task from Incoming to Not ready to estimate on the Web-Team-Backlog board.

matmarex added a project: Editing-team (Kanban Board).Oct 7 2021, 4:39 PM

matmarex moved this task from To Triage to Triaged on the VisualEditor board.

Jdlrobson removed a project: MediaWiki-Core-Skin-Architecture.Oct 13 2021, 3:31 PM

ovasileva triaged this task as Medium priority.Nov 16 2021, 10:34 AM

ovasileva moved this task from Not ready to estimate to Current Fiscal Year on the Web-Team-Backlog board.

• ppelberg removed a project: Editing-team (Kanban Board).Dec 22 2021, 8:12 PM

This task existing within the Planned future work column on the Web-Team-Backlog board leads me to think the Web Team will be working on this task.

As such, I'm removing this from the Editing Team's current workboard.

• ppelberg moved this task from Backlog to Dependent on others on the Editing-team (Tracking) board.Dec 22 2021, 8:15 PM

@ppelberg this definitely looks something that should be on the editing team workboard (T292125#7391695). I'm not sure why this is in the readers web backlog at all to be honest. We'll have to ask Olga when she's back. It's possible "PLanned future work" means planned by somebody other than web (which would be confusing).

Change 963423 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/VisualEditor@master] DesktopArticleTarget.init: Remove code for updating edit links

https://gerrit.wikimedia.org/r/963423

gerritbot added a project: Patch-For-Review.Oct 5 2023, 1:05 AM

matmarex claimed this task.Oct 5 2023, 1:06 AM

Change 963423 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] DesktopArticleTarget.init: Remove code for updating edit links

https://gerrit.wikimedia.org/r/963423

Maintenance_bot removed a project: Patch-For-Review.Oct 5 2023, 2:12 PM

DLynch edited projects, added Editing-team (Kanban Board); removed Editing-team (Tracking).Oct 5 2023, 2:45 PM

DLynch added a project: Editing QA.

DLynch moved this task from Incoming to QA on the Editing-team (Kanban Board) board.

Ryasmeen moved this task from QA to Ready for Sign Off on the Editing-team (Kanban Board) board.Nov 8 2023, 11:13 PM

Ryasmeen edited projects, added Verified; removed Editing QA.

VPuffetMichel closed this task as Resolved.Dec 4 2023, 6:46 PM

Change 995231 had a related patch set uploaded (by Sophivorus; author: Bartosz Dziewoński):

[mediawiki/extensions/VisualEditor@REL1_39] DesktopArticleTarget.init: Remove code for updating edit links

https://gerrit.wikimedia.org/r/995231

gerritbot added a project: Patch-For-Review.Feb 2 2024, 6:04 PM

Change 995231 merged by jenkins-bot: