Signatures and substitutions remain unparsed in live diff
Closed, ResolvedPublic1 Estimated Story PointsBUG REPORT
Actions

Assigned To

Authored By

	Nardog
	Oct 3 2021, 11:51 AM

Description

List of steps to reproduce:

Enable "Show previews without reloading the page" in Preferences
Open an edit form, e.g. Wikipedia:Sandbox
Enter e.g. ~~~~ or {{subst:unsigned|Example}} in the textbox
Click "Show changes"

What happens?:
The diff shows ~~~~, {{subst:unsigned|Example}}, etc. as entered.

What should have happened instead?:
The diff shows what they would result in when the edit is saved, as in [[User:Example|Example]] ([[User talk:Example|talk]]) 11:46, 3 October 2021 (UTC) or <span class="autosigned" style="font-size:85%;">— Preceding [[Wikipedia:Signatures|unsigned]] comment added by [[User:Example|Example]] ([[User talk:Example#top|talk]] • [[Special:Contributions/Example|contribs]]) </span>, etc.

This appears to have been introduced in T109166/d0a3ceee1f28. I believe frompst: 1 is needed in diffPar.

Details

	Subject	Repo	Branch	Lines +/-
	Fix API warning in live preview	mediawiki/core	master	+6 -8

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Open		None	T41272 Bugs in "Live preview" feature (tracking)
		Resolved	BUG REPORT	Daimona	T292362 Signatures and substitutions remain unparsed in live diff

Event Timeline

Nardog created this task.Oct 3 2021, 11:51 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 3 2021, 11:51 AM

Nardog added a project: Regression.Oct 3 2021, 12:17 PM

Nardog updated the task description. (Show Details)

This appears to have been introduced in T109166/d0a3ceee1f28. I believe frompst: 1 is needed in diffPar.

That's correct, I missed that param. Already fixed in r725011 for T109166.

Change 725011 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/core@master] Fix API warning in live preview

https://gerrit.wikimedia.org/r/725011

gerritbot added a project: Patch-For-Review.Oct 3 2021, 12:42 PM

Daimona claimed this task.Oct 3 2021, 12:42 PM

Daimona moved this task from Ready 🎬 to Review/Feedback 💬 on the Community-Tech (CommTech-Sprint-10) board.

Change 725011 merged by jenkins-bot:

[mediawiki/core@master] Fix API warning in live preview

https://gerrit.wikimedia.org/r/725011

Daimona moved this task from Review/Feedback 💬 to QA 🐛 on the Community-Tech (CommTech-Sprint-10) board.Oct 4 2021, 4:45 PM

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.3; 2021-10-05).Oct 4 2021, 5:00 PM

Maintenance_bot removed a project: Patch-For-Review.Oct 4 2021, 5:10 PM

ldelench_wmf set the point value for this task to 1.Oct 7 2021, 5:29 PM

ldelench_wmf edited projects, added Community-Tech (CommTech-Sprint-11); removed Community-Tech (CommTech-Sprint-10).Oct 11 2021, 1:47 PM

ldelench_wmf moved this task from Ready 🎬 to QA 🐛 on the Community-Tech (CommTech-Sprint-11) board.

Aklapper merged a task: T292714: Pre-save transform not working with preview of changes when Ajax Preview is enabled.Oct 13 2021, 6:50 AM

Aklapper added a subscriber: SD0001.

I compared the output of the live diff with the normal diff on beta and saw no differences.

As test data, I used the wikitext we use for our parser tests (the .txt files here), which has a large range of different wikitext including signatures and substitutions.

Test environment: https://en.wikipedia.beta.wmflabs.org MediaWiki 1.38.0-alpha (df729bc) 23:52, 14 October 2021.