Page MenuHomePhabricator
Create Task
Maniphest T109166

Live preview "Show changes" indicates no changes in on new pages
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

  1. Enable live preview in Special:Preferences > Editing
  2. Visit new page, click [Create source] to create
  3. Enter lots of text, [Preview] many times
  4. Much later, wonder if you've saved your latest version yet, so click [Show changes]

Result: nothing is displayed, so you assume you've made no changes and quit your browser, and all your work is lost.

Expected result: please please do what regular [Show changes] does and display

  Latest revision       Your text
Line 1: 	    Line 1:
(nothing)           + lots of text
                    + lots more text

so I know that I haven't actually saved the page yet.

From T176558:

Steps to reproduce:

  1. Go to Preferences > Editing , ensure that "Show previews without reloading the page" is checked
  2. Go to edit the source of a non-existing page, e.g. https://en.wikipedia.org/w/index.php?title=asdffdsa&action=edit&debug=true
  3. Enter a few words into the main textbox
  4. Click the button "Show changes"

Expected results:

  • The diff is shown above

Actual results:

  • The spinner is briefly shown, and a warning is logged to the console (see below)

Error in the console:

TypeError: response[0].query.pages[0].revisions is undefined

Details

SubjectRepoBranchLines +/-
Unbreak "show changes" in live preview for page creationsmediawiki/coremaster+26 -20
Fix API warning in live previewmediawiki/coremaster+6 -8
[WIP] API: Compare should be able to deal with textmediawiki/coremaster+83 -28
Customize query in gerrit

Related Objects
Search...

Event Timeline

• Spage created this task.Aug 15 2015, 4:10 AM
• Spage raised the priority of this task from to High.
• Spage updated the task description. (Show Details)
• Spage added a project: MediaWiki-Page-editing.
• Spage subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 15 2015, 4:10 AM
Aklapper added a parent task: T41272: Bugs in "Live preview" feature (tracking).Aug 15 2015, 10:22 AM
TheDJ subscribed.Sep 2 2015, 6:47 AM

Yeah this is a difference in behavior between the api and the edit page.
It mostly has to do with the fact that the diff api is a subpart of the revisions api. And for a new article, there is no revision yet of course...

https://en.wikipedia.org/w/api.php?action=help&modules=query%2Brevisions

TheDJ added a project: MediaWiki-Action-API.Sep 2 2015, 6:48 AM
TheDJ set Security to None.
Anomie subscribed.Sep 2 2015, 1:07 PM

TheDJ added a project: MediaWiki-API.

And the API bug here is?

TheDJ added a comment.Sep 2 2015, 9:19 PM
In T109166#1596720, @Anomie wrote:

TheDJ added a project: MediaWiki-API.

And the API bug here is?

There is a disjunct between editing page abilities and api abilities. That seems to me like a shared problem, that both tags should get an opportunity to discuss.

Anomie moved this task from Unsorted to Needs details or plan on the MediaWiki-Action-API board.Sep 3 2015, 4:17 PM

Probably the thing to do here is to add fromtext and totext (and possibly frompst and topst) to action=compare.

Anomie moved this task from Needs details or plan to Needs Code on the MediaWiki-Action-API board.Sep 3 2015, 4:19 PM
gerritbot subscribed.Sep 4 2015, 7:33 PM

Change 236078 had a related patch set uploaded (by TheDJ):
[WIP] API: Compare should be able to deal with text

https://gerrit.wikimedia.org/r/236078

gerritbot added a project: Patch-For-Review.Sep 4 2015, 7:33 PM
Anomie moved this task from Needs Code to In Dev on the MediaWiki-Action-API board.Sep 10 2015, 2:55 PM
Ricordisamoa renamed this task from Show changes in Live preview indicates no changes in a brand new file, data loss results to Show changes in Live preview indicates no changes in a brand new page, data loss results.Mar 31 2016, 2:33 AM
Ricordisamoa subscribed.
Anomie edited projects, added Patch-Needs-Improvement; removed Patch-For-Review.May 5 2017, 9:38 PM
Liuxinyu970226 subscribed.Jul 17 2017, 5:23 AM
gerritbot added a comment.Aug 10 2017, 10:19 PM

Change 236078 abandoned by TheDJ:
[WIP] API: Compare should be able to deal with text

https://gerrit.wikimedia.org/r/236078

TheDJ added a parent task: T176558: AJAX "Show changes" doesn't work when creating a page: "TypeError: response[0].query.pages[0].revisions is undefined".Feb 8 2018, 5:37 PM
MGChecker moved this task from Backlog to Live preview on the MediaWiki-Page-editing board.Nov 15 2018, 10:21 PM
Aklapper removed subscribers: Anomie, • Spage.Oct 16 2020, 5:01 PM
Restricted Application added a project: Platform Engineering. · View Herald TranscriptOct 16 2020, 5:01 PM
• AMooney removed a project: Platform Engineering.Oct 20 2020, 7:27 PM
MusikAnimal merged a task: T176558: AJAX "Show changes" doesn't work when creating a page: "TypeError: response[0].query.pages[0].revisions is undefined".Sep 8 2021, 10:35 PM
MusikAnimal added subscribers: Skalman, PeterBowman.
MusikAnimal renamed this task from Show changes in Live preview indicates no changes in a brand new page, data loss results to Live preview "Show changes" indicates no changes in on new pages.Sep 8 2021, 10:43 PM
MusikAnimal updated the task description. (Show Details)
MusikAnimal subscribed.
MusikAnimal removed a project: Patch-Needs-Improvement.Sep 23 2021, 3:19 PM
• NRodriguez added a project: Community-Tech (CommTech-Sprint-10).Sep 23 2021, 3:56 PM
gerritbot added a comment.Sep 23 2021, 4:49 PM

Change 723258 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/core@master] Unbreak live preview for page creations

https://gerrit.wikimedia.org/r/723258

gerritbot added a project: Patch-For-Review.Sep 23 2021, 4:49 PM
Daimona claimed this task.Sep 23 2021, 4:52 PM
Daimona edited projects, added Community-Tech (CommTech-Sprint-9); removed Patch-For-Review, Community-Tech (CommTech-Sprint-10).
Daimona added a project: Patch-For-Review.
Daimona moved this task from Ready 🎬 to Review/Feedback 💬 on the Community-Tech (CommTech-Sprint-9) board.
Daimona set the point value for this task to 1.
Daimona changed the point value for this task from 1 to 2.Sep 24 2021, 1:11 PM
Daimona moved this task from Review/Feedback 💬 to QA 🐛 on the Community-Tech (CommTech-Sprint-9) board.Sep 27 2021, 5:07 PM

QA notes: as part of this change, we switched from using ApiQueryRevisions to ApiCompare. As such, it'd be great if you could also ensure that the output live preview is (still) correct and consistent with that of the normal preview. In particular, this includes section edits (create a page with some sections and click the "edit section" link next to a section, instead of the "edit" link at the top), that were changed with the patch above. Thanks!

gerritbot added a comment.Sep 27 2021, 5:26 PM

Change 723258 merged by jenkins-bot:

[mediawiki/core@master] Unbreak \"show changes\" in live preview for page creations

https://gerrit.wikimedia.org/r/723258

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.2; 2021-09-28).Sep 27 2021, 6:00 PM
ldelench_wmf edited projects, added Community-Tech (CommTech-Sprint-10); removed Community-Tech (CommTech-Sprint-9).Sep 27 2021, 8:29 PM
ldelench_wmf moved this task from Ready 🎬 to QA 🐛 on the Community-Tech (CommTech-Sprint-10) board.
dom_walden subscribed.EditedSep 30 2021, 8:56 AM

@Daimona Testing on beta, while editing a pre-existing page (for example), if I click "Show changes" the response from ApiCompare includes:

{"warnings":{"main":{"*":"Unrecognized parameter: fromcontentmodel-main."}} ...

Similarly, while editing a section (for example) the response includes:

{"warnings":{"main":{"*":"Unrecognized parameters: fromcontentmodel-main, fromsection-main."}} ...

There are no warnings when creating a new page.

EDIT:
I am also finding on Commons that the "Show changes" also shows data for the mediainfo slot of a revision (for example, this image). The API response also shows the same warnings as above.

mediainfo_slot_show_changes.png (1×1 px, 122 KB)

It does not appear with "normal" previews.

Hard to tell if this is a regression, because prod Commons is now on the latest version, and I don't have an environment to test the previous version.

Daimona moved this task from QA 🐛 to In Development 💻 on the Community-Tech (CommTech-Sprint-10) board.Sep 30 2021, 1:40 PM
In T109166#7390389, @dom_walden wrote:

@Daimona Testing on beta, while editing a pre-existing page (for example), if I click "Show changes" the response from ApiCompare includes:

{"warnings":{"main":{"*":"Unrecognized parameter: fromcontentmodel-main."}} ...

Similarly, while editing a section (for example) the response includes:

{"warnings":{"main":{"*":"Unrecognized parameters: fromcontentmodel-main, fromsection-main."}} ...

There are no warnings when creating a new page.

EDIT:
I am also finding on Commons that the "Show changes" also shows data for the mediainfo slot of a revision (for example, this image). The API response also shows the same warnings as above.

mediainfo_slot_show_changes.png (1×1 px, 122 KB)

It does not appear with "normal" previews.

Hard to tell if this is a regression, because prod Commons is now on the latest version, and I don't have an environment to test the previous version.

I think all of this issues have the same cause: we're not setting the "fromslots" parameter. This is why "fromcontentmodel-main" is not recognized. And of course it includes all slots from the base page. We're already setting the param for article creations. This should be an easy fix.

gerritbot added a comment.Sep 30 2021, 2:00 PM

Change 725011 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/core@master] Always pass \"fromslot\" to ApiCompare in live preview

https://gerrit.wikimedia.org/r/725011

Daimona moved this task from In Development 💻 to Review/Feedback 💬 on the Community-Tech (CommTech-Sprint-10) board.Sep 30 2021, 2:00 PM
Daimona added a comment.Oct 1 2021, 11:35 PM

I changed the patch above to only avoid the API warning. To fix the issue on commons we would need to only use the main slot from when passing "fromtitle". However, this doesn't seem to be possible, if my understanding of the documentation is correct.

I ran the old API request on commons (link) and it seems to be a regression.

Nardog subscribed.Oct 3 2021, 11:26 AM
Nardog mentioned this in T292362: Signatures and substitutions remain unparsed in live diff.Oct 3 2021, 11:51 AM
Daimona added a comment.Oct 3 2021, 1:17 PM
In T109166#7395961, @Daimona wrote:

To fix the issue on commons we would need to only use the main slot from when passing "fromtitle". However, this doesn't seem to be possible, if my understanding of the documentation is correct.

It is possible, for some reason I didn't notice the "slots" parameter in the documentation. Updated the patch above to use it. So, with the patch above, both the API warnings and the MCR diffs are fixed.

gerritbot added a comment.Oct 4 2021, 4:42 PM

Change 725011 merged by jenkins-bot:

[mediawiki/core@master] Fix API warning in live preview

https://gerrit.wikimedia.org/r/725011

Daimona moved this task from Review/Feedback 💬 to QA 🐛 on the Community-Tech (CommTech-Sprint-10) board.Oct 4 2021, 4:44 PM
ldelench_wmf edited projects, added Community-Tech (CommTech-Sprint-11); removed Community-Tech (CommTech-Sprint-10).Oct 11 2021, 1:47 PM
ldelench_wmf moved this task from Ready 🎬 to QA 🐛 on the Community-Tech (CommTech-Sprint-11) board.
Daimona mentioned this in T293022: LivePreview doesn't work with ProofreadPage pages.Oct 11 2021, 5:57 PM
Daimona mentioned this in T293307: Header of diff in the editor missing when using live preview.Oct 13 2021, 9:53 PM
dom_walden moved this task from QA 🐛 to Product sign-off 🤘 on the Community-Tech (CommTech-Sprint-11) board.Oct 19 2021, 12:35 PM

Bug in the description no longer occurs. While creating a new page, Live Preview will display any changes you have made as appropriate.

In T109166#7380985, @Daimona wrote:

QA notes: as part of this change, we switched from using ApiQueryRevisions to ApiCompare. As such, it'd be great if you could also ensure that the output live preview is (still) correct and consistent with that of the normal preview. In particular, this includes section edits (create a page with some sections and click the "edit section" link next to a section, instead of the "edit" link at the top), that were changed with the patch above. Thanks!

I have compared the output of Live and normal previews. The only differences I found were those mentioned here T293022#7431771 (I will raise a separate bug, as there are a couple of places where a similar thing happens).

I did this also for section edits, new and existing pages, and pages with Multi-Content_Revisions.

Test environment: Various. Most recently: https://en.wikipedia.beta.wmflabs.org MediaWiki 1.38.0-alpha (66e58d1) 03:30, 19 October 2021.

Nardog closed this task as Resolved.Oct 19 2021, 1:47 PM
Nardog removed a project: Patch-For-Review.
Daimona reopened this task as Open.Oct 19 2021, 10:10 PM
Daimona added a subscriber: • NRodriguez.

(Reopening for @NRodriguez to sign off)

• NRodriguez closed this task as Resolved.Oct 20 2021, 7:22 PM

Great work, unable to reproduce, thanks for the great documentation on steps in the ticket

ldelench_wmf moved this task from Product sign-off 🤘 to Done 🏁 on the Community-Tech (CommTech-Sprint-11) board.Oct 21 2021, 3:31 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits