Page MenuHomePhabricator
Create Task
Maniphest T109166

Show changes in Live preview indicates no changes in a brand new page, data loss results
Open, HighPublic
Actions

Description

  1. Enable live preview in Special:Preferences > Editing
  2. Visit new page, click [Create source] to create
  3. Enter lots of text, [Preview] many times
  4. Much later, wonder if you've saved your latest version yet, so click [Show changes]

Result: nothing is displayed, so you assume you've made no changes and quit your browser, and all your work is lost.

Expected result: please please do what regular [Show changes] does and display

  Latest revision       Your text
Line 1: 	    Line 1:
(nothing)           + lots of text
                    + lots more text

so I know that I haven't actually saved the page yet.

Details

ProjectBranchLines +/-Subject
mediawiki/coremaster+83 -28[WIP] API: Compare should be able to deal with text
Customize query in gerrit

Related Objects
Search...

Event Timeline

• Spage created this task.Aug 15 2015, 4:10 AM
• Spage raised the priority of this task from to High.
• Spage updated the task description. (Show Details)
• Spage added a project: MediaWiki-Page-editing.
• Spage added a subscriber: • Spage.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 15 2015, 4:10 AM
Aklapper added a parent task: T41272: Bugs in "Live preview" feature (tracking).Aug 15 2015, 10:22 AM
TheDJ added a subscriber: TheDJ.Sep 2 2015, 6:47 AM

Yeah this is a difference in behavior between the api and the edit page.
It mostly has to do with the fact that the diff api is a subpart of the revisions api. And for a new article, there is no revision yet of course...

https://en.wikipedia.org/w/api.php?action=help&modules=query%2Brevisions

TheDJ added a project: MediaWiki-API.Sep 2 2015, 6:48 AM
TheDJ set Security to None.
Anomie added a subscriber: Anomie.Sep 2 2015, 1:07 PM

TheDJ added a project: MediaWiki-API.

And the API bug here is?

TheDJ added a comment.Sep 2 2015, 9:19 PM
In T109166#1596720, @Anomie wrote:

TheDJ added a project: MediaWiki-API.

And the API bug here is?

There is a disjunct between editing page abilities and api abilities. That seems to me like a shared problem, that both tags should get an opportunity to discuss.

Anomie moved this task from Unsorted to Needs details or plan on the MediaWiki-API board.Sep 3 2015, 4:17 PM

Probably the thing to do here is to add fromtext and totext (and possibly frompst and topst) to action=compare.

Anomie moved this task from Needs details or plan to Needs Code on the MediaWiki-API board.Sep 3 2015, 4:19 PM
gerritbot added a subscriber: gerritbot.Sep 4 2015, 7:33 PM

Change 236078 had a related patch set uploaded (by TheDJ):
[WIP] API: Compare should be able to deal with text

https://gerrit.wikimedia.org/r/236078

gerritbot added a project: Patch-For-Review.Sep 4 2015, 7:33 PM
Anomie moved this task from Needs Code to In Dev on the MediaWiki-API board.Sep 10 2015, 2:55 PM
Ricordisamoa renamed this task from Show changes in Live preview indicates no changes in a brand new file, data loss results to Show changes in Live preview indicates no changes in a brand new page, data loss results.Mar 31 2016, 2:33 AM
Ricordisamoa added a subscriber: Ricordisamoa.
Anomie edited projects, added Patch-Needs-Improvement; removed Patch-For-Review.May 5 2017, 9:38 PM
Liuxinyu970226 added a subscriber: Liuxinyu970226.Jul 17 2017, 5:23 AM
gerritbot added a comment.Aug 10 2017, 10:19 PM

Change 236078 abandoned by TheDJ:
[WIP] API: Compare should be able to deal with text

https://gerrit.wikimedia.org/r/236078

TheDJ added a parent task: T176558: AJAX "Show changes" doesn't work when creating a page: "TypeError: response[0].query.pages[0].revisions is undefined".Feb 8 2018, 5:37 PM
MGChecker moved this task from Backlog to Live preview on the MediaWiki-Page-editing board.Nov 15 2018, 10:21 PM
Aklapper removed subscribers: Anomie, • Spage.Oct 16 2020, 5:01 PM
Restricted Application added a project: Platform Engineering. · View Herald TranscriptOct 16 2020, 5:01 PM
AMooney removed a project: Platform Engineering.Oct 20 2020, 7:27 PM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL