Page MenuHomePhabricator
Create Task
Maniphest T292657

file "link=" syntax broken at some wikis
Closed, ResolvedPublicBUG REPORT
Actions

Description

List of steps to reproduce

  • Copy&paste [[file:example.jpg|link=foo]] into a page on mediawiki-wiki (example) or officewiki

What happens?:

  • Clicking the image will open the image within MediaViewer

What should have happened instead?:

  • Clicking the image should send you to the page "foo". - This is what happens at testwiki (example) and meta-wiki.

Details

SubjectRepoBranchLines +/-
Preserve classes on media wrapper linksmediawiki/extensions/VisualEditorwmf/1.38.0-wmf.25+102 -5
Preserve classes on media wrapper linksmediawiki/extensions/VisualEditormaster+102 -5
Separate processing for Parsoid thumbsmediawiki/extensions/MultimediaViewermaster+95 -23
Bump wikimedia/parsoid to 0.15.0-a23mediawiki/vendormaster+1 K -1 K
Add mw-file-description class on links to the file description pagemediawiki/coremaster+171 -169
Add mw-file-description class on links to the file description pagemediawiki/services/parsoidmaster+401 -400
Revert "Add "resource" attribute to img tags"mediawiki/coremaster+219 -233
Remove querystring params from media resource attributemediawiki/coremaster+20 -14
Add "resource" attribute to img tagsmediawiki/coremaster+234 -220
Add "resource" attribute to img tagsmediawiki/extensions/ImageMapmaster+5 -5
Customize query in gerrit

Related Objects

Event Timeline

Quiddity created this task.Oct 6 2021, 5:16 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 6 2021, 5:16 PM
matmarex added subscribers: Arlolra, matmarex.Oct 6 2021, 5:23 PM

Possibly related to T51097: Use figure and figcaption HTML5 elements when possible

Aklapper edited projects, added Regression, MediaWiki-Parser; removed MediaWiki-General.Oct 6 2021, 6:31 PM
Arlolra claimed this task.Oct 6 2021, 6:53 PM
Arlolra added a project: Parsoid-Read-Views (Phase 0 - Parsoid-Media-Structure).
Restricted Application added a project: Parsoid. · View Herald TranscriptOct 6 2021, 6:53 PM
Arlolra triaged this task as Medium priority.Oct 6 2021, 6:53 PM
gerritbot added a comment.Oct 6 2021, 8:11 PM

Change 726984 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/extensions/MultimediaViewer@master] [WIP] Don't open MediaViewer if we aren't linking to the file page

https://gerrit.wikimedia.org/r/726984

gerritbot added a project: Patch-For-Review.Oct 6 2021, 8:11 PM
Arlolra moved this task from Needs Triage to Media Structure on the Parsoid board.Oct 21 2021, 2:57 PM
Arlolra moved this task from Backlog to In Progress on the Parsoid-Read-Views (Phase 0 - Parsoid-Media-Structure) board.Dec 8 2021, 7:36 PM
gerritbot added a comment.Dec 15 2021, 1:07 AM

Change 747219 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/core@master] [WIP] Add \"resource\" attribute to img tags

https://gerrit.wikimedia.org/r/747219

gerritbot added a comment.Dec 16 2021, 12:16 AM

Change 747642 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/extensions/ImageMap@master] Add \"resource\" attribute to img tags

https://gerrit.wikimedia.org/r/747642

gerritbot added a comment.Jan 7 2022, 7:03 PM

Change 747642 merged by Subramanya Sastry:

[mediawiki/extensions/ImageMap@master] Add \"resource\" attribute to img tags

https://gerrit.wikimedia.org/r/747642

gerritbot added a comment.Jan 7 2022, 7:23 PM

Change 747219 merged by jenkins-bot:

[mediawiki/core@master] Add \"resource\" attribute to img tags

https://gerrit.wikimedia.org/r/747219

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.17; 2022-01-10).Jan 7 2022, 8:00 PM
gerritbot added a comment.Feb 2 2022, 9:01 PM

Change 759332 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/core@master] [WIP] Remove querystring params from media resource attribute

https://gerrit.wikimedia.org/r/759332

BTullis subscribed.Feb 18 2022, 8:39 PM
gerritbot added a comment.Feb 18 2022, 11:21 PM

Change 763858 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/services/parsoid@master] [WIP] Add mw-description class on links to the description page

https://gerrit.wikimedia.org/r/763858

gerritbot added a comment.Feb 18 2022, 11:38 PM

Change 763861 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/core@master] Revert \"Add \"resource\" attribute to img tags\"

https://gerrit.wikimedia.org/r/763861

gerritbot added a comment.Feb 18 2022, 11:38 PM

Change 763862 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/core@master] [WIP] Add mw-description class to media description links

https://gerrit.wikimedia.org/r/763862

gerritbot added a comment.Feb 19 2022, 12:53 AM

Change 759332 abandoned by Arlolra:

[mediawiki/core@master] Remove querystring params from media resource attribute

Reason:

In favour of https://gerrit.wikimedia.org/r/c/mediawiki/core/+/763861

https://gerrit.wikimedia.org/r/759332

gerritbot added a comment.Feb 19 2022, 2:37 PM

Change 763861 merged by jenkins-bot:

[mediawiki/core@master] Revert \"Add \"resource\" attribute to img tags\"

https://gerrit.wikimedia.org/r/763861

gerritbot added a comment.Mar 1 2022, 10:11 PM

Change 763858 merged by jenkins-bot:

[mediawiki/services/parsoid@master] Add mw-file-description class on links to the file description page

https://gerrit.wikimedia.org/r/763858

gerritbot added a comment.Mar 1 2022, 10:14 PM

Change 763862 merged by jenkins-bot:

[mediawiki/core@master] Add mw-file-description class on links to the file description page

https://gerrit.wikimedia.org/r/763862

gerritbot added a comment.Mar 7 2022, 11:12 PM

Change 768825 had a related patch set uploaded (by Subramanya Sastry; author: Subramanya Sastry):

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.15.0-a23

https://gerrit.wikimedia.org/r/768825

gerritbot added a comment.Mar 8 2022, 12:46 AM

Change 768825 merged by jenkins-bot:

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.15.0-a23

https://gerrit.wikimedia.org/r/768825

gerritbot added a comment.Mar 8 2022, 12:46 AM

Change 726984 merged by jenkins-bot:

[mediawiki/extensions/MultimediaViewer@master] Separate processing for Parsoid thumbs

https://gerrit.wikimedia.org/r/726984

ReleaseTaggerBot edited projects, added MW-1.38-notes (1.38.0-wmf.25; 2022-03-07); removed MW-1.38-notes (1.38.0-wmf.17; 2022-01-10).Mar 8 2022, 1:00 AM
Arlolra closed this task as Resolved.Mar 8 2022, 11:29 PM

https://www.mediawiki.org/w/index.php?title=User:Arlolra/sandbox&oldid=5102483

gerritbot added a comment.Mar 9 2022, 7:45 PM

Change 769507 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/extensions/VisualEditor@master] Preserve class on media file description links

https://gerrit.wikimedia.org/r/769507

gerritbot added a comment.Mar 10 2022, 8:35 PM

Change 769507 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Preserve classes on media wrapper links

https://gerrit.wikimedia.org/r/769507

gerritbot added a comment.Mar 10 2022, 8:44 PM

Change 769558 had a related patch set uploaded (by Bartosz Dziewoński; author: Arlolra):

[mediawiki/extensions/VisualEditor@wmf/1.38.0-wmf.25] Preserve classes on media wrapper links

https://gerrit.wikimedia.org/r/769558

gerritbot added a comment.Mar 10 2022, 9:19 PM

Change 769558 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@wmf/1.38.0-wmf.25] Preserve classes on media wrapper links

https://gerrit.wikimedia.org/r/769558

Stashbot mentioned this in T303469: VE should preserve .mw-file-description class in Parsoid HTML.Mar 10 2022, 9:33 PM

Mentioned in SAL (#wikimedia-operations) [2022-03-10T21:33:35Z] <rzl@deploy1002> Synchronized php-1.38.0-wmf.25/extensions/VisualEditor/modules/ve-mw: Backport: [[gerrit:769558|Preserve classes on media wrapper links (T292657 T303469)]] (duration: 00m 49s)

• mewoph mentioned this in T309152: [regression-wmf.13] Add image: Missing "View image details" link .May 24 2022, 11:02 PM
Arlolra moved this task from In Progress to To Verify on the Parsoid-Read-Views (Phase 0 - Parsoid-Media-Structure) board.Jun 15 2022, 3:30 PM
Arlolra mentioned this in T314318: Disable wgParserEnableLegacyMediaDOM on all wikis.Sep 6 2022, 10:22 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits