Page MenuHomePhabricator

[regression-wmf.13] Add image: Missing "View image details" link
Closed, ResolvedPublic

Description

Found by @MMiller_WMF

Steps:

  1. Go to Add image article.
  2. Answer "yes" to accept a suggested image - the "add caption" step will present an image without "View image details" details.

Screen Shot 2022-05-24 at 3.36.25 PM.png (1×598 px, 735 KB)

Notes:

  • Based on T298117 - the caption step should provide the link to see image details:

Screen Shot 2021-12-22 at 11.19.18 AM.png (936×1 px, 630 KB)

  • the image details can be viewed in a different tab by right clicking on it

Regression:
The was broken from 1.38.0-wmf.25 (backported on March 10) due to .image selector being removed upstream via T292657 and T303469.

Event Timeline

Thank you for filing this, @Etonkovidova. When this is solved, it would be great if engineers include on this task the date when the problem started occurring so we know which data it impacts.

We are attaching the view details button to .image but this selector no longer exists. This class was removed in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/VisualEditor/+/769507

Change 799005 had a related patch set uploaded (by MewOphaswongse; author: MewOphaswongse):

[mediawiki/extensions/GrowthExperiments@master] Add an image: Attach view image details button to .mw-ge-recommendedImage-imageWrapper

https://gerrit.wikimedia.org/r/799005

Change 799007 had a related patch set uploaded (by MewOphaswongse; author: MewOphaswongse):

[mediawiki/extensions/GrowthExperiments@wmf/1.39.0-wmf.13] Add an image: Attach view image details button to .mw-ge-recommendedImage-imageWrapper

https://gerrit.wikimedia.org/r/799007

Change 799008 had a related patch set uploaded (by MewOphaswongse; author: MewOphaswongse):

[mediawiki/extensions/GrowthExperiments@wmf/1.39.0-wmf.12] Add an image: Attach view image details button to .mw-ge-recommendedImage-imageWrapper

https://gerrit.wikimedia.org/r/799008

Change 799005 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Add an image: Attach view image details button to .mw-ge-recommendedImage-imageWrapper

https://gerrit.wikimedia.org/r/799005

Change 799008 merged by Kosta Harlan:

[mediawiki/extensions/GrowthExperiments@wmf/1.39.0-wmf.12] Add an image: Attach view image details button to .mw-ge-recommendedImage-imageWrapper

https://gerrit.wikimedia.org/r/799008

Mentioned in SAL (#wikimedia-operations) [2022-05-25T08:29:45Z] <kharlan@deploy1002> Synchronized php-1.39.0-wmf.12/extensions/GrowthExperiments/modules/ext.growthExperiments.StructuredTask/addimage: Backport: [[gerrit:799008|Add an image: Attach view image details button to .mw-ge-recommendedImage-imageWrapper (T309152)]] (duration: 00m 51s)

Change 799007 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@wmf/1.39.0-wmf.13] Add an image: Attach view image details button to .mw-ge-recommendedImage-imageWrapper

https://gerrit.wikimedia.org/r/799007

Mentioned in SAL (#wikimedia-operations) [2022-05-25T08:51:42Z] <kharlan@deploy1002> Synchronized php-1.39.0-wmf.13/extensions/GrowthExperiments/modules/ext.growthExperiments.StructuredTask/addimage: Backport: [[gerrit:799007|Add an image: Attach view image details button to .mw-ge-recommendedImage-imageWrapper (T309152)]] (duration: 00m 49s)

Checked on testwiki wmf.13

DesktopMobile (Android)
Screen Shot 2022-05-25 at 4.46.10 PM.png (1×2 px, 828 KB)
Screen Shot 2022-05-25 at 4.46.17 PM.png (1×1 px, 744 KB)
Screenshot_20220525-164950_Chrome.jpg (2×1 px, 690 KB)
Screenshot_20220525-164958_Chrome.jpg (2×1 px, 421 KB)