<small> gallery caption can't be edited
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Esanders
	Oct 27 2021, 4:18 PM

Description

Create a gallery caption with <small> text: https://www.mediawiki.org/wiki/User:ESanders_(WMF)/sandbox/gallery
Try to append some text to the caption in the gallery dialog
In the save dialog, preview your changes, observe the text you added is not there

Details

	Subject	Repo	Branch	Lines +/-
	Bump Parsoid to 0.15.0-a10	mediawiki/vendor	master	+289 -267
	DOM diff galleries	mediawiki/services/parsoid	master	+27 -0

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		• ppelberg	T294450 <small> gallery caption can't be edited
		Resolved		Arlolra	T214648 DOMDiff'ing doesn't traverse into galleries

Event Timeline

Esanders created this task.Oct 27 2021, 4:18 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 27 2021, 4:18 PM

Esanders added a project: Parsoid.Oct 27 2021, 4:25 PM

After editing the caption I get the following HTML from VE (using ve.init.target.surface.getHtml())

<ul typeof="mw:Extension/gallery" data-mw='{"name":"gallery","attrs":{},"body":{}}' class="gallery mw-gallery-traditional" about="#mwt2" id="mwAg">
    <li class="gallerybox">
        <div class="thumb">
            <span typeof="mw:Image">
                <a><img resource="./File:VisualEditor-logo.svg" src="https://upload.wikimedia.org/wikipedia/commons/thumb/1/12/VisualEditor-logo.svg/200px-VisualEditor-logo.svg.png" /></a>
            </span>
        </div>
        <div class="gallerytext"><small id="mwCQ">Small caption MODIFIED</small></div>
    </li>
</ul>

Which converts to the correct wikitext in a standalone instance of Parsoid. This leads me to believe this must be a problem with restbase IDs / data-parsoid.

If I remove then re-add the <small> styling in the editor, I get a new HTML element in the output, without id="mwCQ" and the bug goes away, so this is definitely a Parsoid issue.

Yeah, the dom diff'er doesn't traverse into the gallery content so the presence of an id without diff markers indicates that source can be reused and the modification is dropped. We have T214648 and T214651 which captures this already

Arlolra closed this task as a duplicate of T214648: DOMDiff'ing doesn't traverse into galleries.Oct 27 2021, 6:05 PM

Change 735081 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/services/parsoid@master] [WIP] DOM diff galleries

https://gerrit.wikimedia.org/r/735081

gerritbot added a project: Patch-For-Review.Oct 28 2021, 12:27 AM

Let's keep this task open as it more clearly describes the user problem from the Editing team's perspective. It will be easier for our QA to verify.

Arlolra added a subtask: T214648: DOMDiff'ing doesn't traverse into galleries.Oct 28 2021, 4:39 PM

Arlolra moved this task from Needs Triage to Bugs & Crashers on the Parsoid board.

Change 735081 merged by jenkins-bot:

[mediawiki/services/parsoid@master] DOM diff galleries

https://gerrit.wikimedia.org/r/735081

Maintenance_bot removed a project: Patch-For-Review.Oct 29 2021, 11:10 PM