Page MenuHomePhabricator
Create Task
Maniphest T294734

Add phpunit tests to Kartographer that cover revid changes
Closed, ResolvedPublic5 Estimated Story Points
Actions

Description

  • Cover legacy mapdata API with tests
  • Cover new revid logic with tests
  • Test feature flag

Details

SubjectRepoBranchLines +/-
Add first tests for mapdata APImediawiki/extensions/Kartographermaster+98 -0
Simplify/cleanup ApiQueryMapDataTest implementationmediawiki/extensions/Kartographermaster+46 -37
Add mapdata tests for multiple titles and revisionsmediawiki/extensions/Kartographermaster+34 -11
Customize query in gerrit

Related Objects
Search...

Event Timeline

WMDE-Fisch created this task.Nov 1 2021, 10:26 AM
WMDE-Fisch merged a task: T294732: Write API tests for Kartographer.Nov 1 2021, 10:29 AM
awight mentioned this in T293844: Merge revid branches to production.Nov 1 2021, 10:30 AM
WMDE-Fisch moved this task from Sprint Backlog to Doing on the WMDE-TechWish-Sprint-2021-10-27 board.Nov 1 2021, 10:31 AM
TheDJ subscribed.Nov 1 2021, 12:16 PM
gerritbot added a comment.Nov 3 2021, 11:03 AM

Change 736438 had a related patch set uploaded (by WMDE-Fisch; author: WMDE-Fisch):

[mediawiki/extensions/Kartographer@master] Add mapdata tests for multiple titles and revisions

https://gerrit.wikimedia.org/r/736438

gerritbot added a project: Patch-For-Review.Nov 3 2021, 11:03 AM
gerritbot added a comment.Nov 3 2021, 11:22 AM

Change 736309 had a related patch set uploaded (by WMDE-Fisch; author: WMDE-Fisch):

[mediawiki/extensions/Kartographer@master] Add first tests for mapdata API

https://gerrit.wikimedia.org/r/736309

gerritbot added a comment.Nov 3 2021, 2:18 PM

Change 736476 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Kartographer@master] Simplify/cleanup ApiQueryMapDataTest implementation

https://gerrit.wikimedia.org/r/736476

gerritbot added a comment.Nov 3 2021, 2:43 PM

Change 736309 merged by jenkins-bot:

[mediawiki/extensions/Kartographer@master] Add first tests for mapdata API

https://gerrit.wikimedia.org/r/736309

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.9; 2021-11-16).Nov 3 2021, 3:00 PM
gerritbot added a comment.Nov 4 2021, 2:39 PM

Change 736438 merged by jenkins-bot:

[mediawiki/extensions/Kartographer@master] Add mapdata tests for multiple titles and revisions

https://gerrit.wikimedia.org/r/736438

WMDE-Fisch moved this task from Doing to Tech Review on the WMDE-TechWish-Sprint-2021-10-27 board.Nov 5 2021, 8:40 AM
WMDE-Fisch moved this task from Tech Review to Doing on the WMDE-TechWish-Sprint-2021-10-27 board.
awight moved this task from Backlog to In sprint on the WMDE-GeoInfo-FocusArea board.Nov 5 2021, 10:33 AM
gerritbot added a comment.Nov 5 2021, 11:45 AM

Change 736476 merged by jenkins-bot:

[mediawiki/extensions/Kartographer@master] Simplify/cleanup ApiQueryMapDataTest implementation

https://gerrit.wikimedia.org/r/736476

Maintenance_bot removed a project: Patch-For-Review.Nov 5 2021, 12:10 PM
WMDE-Fisch moved this task from Doing to Done on the WMDE-TechWish-Sprint-2021-10-27 board.Nov 5 2021, 6:15 PM
WMDE-Fisch set the point value for this task to 5.
thiemowmde closed this task as Resolved.Nov 9 2021, 12:55 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits