Page MenuHomePhabricator
Create Task
Maniphest T295794

Sticky header: manage z-index of ULS & sticky header
Closed, ResolvedPublic2 Estimated Story Points
Actions

Assigned To
ovasileva
Authored By
• alexhollender_WMF
Nov 16 2021, 6:10 PM
Tags
Referenced Files
F34888672: Screen Recording 2021-12-18 at 12.31.20 PM.mov.gif
Dec 18 2021, 8:41 PM
F34862712: Screen Recording 2021-12-08 at 8.35.15 AM.mov.gif
Dec 8 2021, 4:36 PM
F34750499: uls overlaps sticky header.webm
Nov 16 2021, 6:10 PM
Subscribers
Aklapper
• alexhollender_WMF
bwang
Edtadros
Jdlrobson
ovasileva

Description

Description

Currently if you open the ULS from the top of the page, then scroll down a bit (with the ULS still open) until the sticky header appears, you will notice that the ULS overlaps the sticky header. This is not correct. The ULS (if opened from the top of the page) should have a lower z-index than the sticky header.

NOTE: it is also possible to open the ULS from the sticky header (see T295391), in which case it should have a higher z-index than the sticky header.

QA Results - Beta

ACStatusDetails
1✅T295794#7556685

QA Results - Prod

ACStatusDetails
1✅T295794#7579252

Details

SubjectRepoBranchLines +/-
Lower .uls-menu z-index for Vector skinmediawiki/extensions/UniversalLanguageSelectormaster+2 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

• alexhollender_WMF created this task.Nov 16 2021, 6:10 PM
ovasileva triaged this task as High priority.Nov 16 2021, 6:33 PM
LGoto assigned this task to bwang.Nov 16 2021, 6:33 PM
bwang added a comment.EditedNov 16 2021, 10:57 PM

This looks like it should be a straightforward CSS change. The overlays are set to 1000 and the sticky header is set to 4, we could simply update the overlay to match the other menu overlays (i.e. user menu) and have a value of 3. We do need a way to distinguish between the ULS at the top of the page and the one in the sticky header however, similar to T295391. Edit: nevermind, they both have unique ids

bwang moved this task from Needs Analysis to Upcoming on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.Nov 16 2021, 10:57 PM
bwang removed bwang as the assignee of this task.Nov 16 2021, 11:02 PM
LGoto moved this task from Incoming to Sticky header on the Desktop Improvements (Vector 2022) board.Nov 18 2021, 6:25 PM
LGoto set the point value for this task to 2.
LGoto moved this task from Upcoming to Ready for Development on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.
gerritbot added a comment.Nov 23 2021, 7:17 AM

Change 740718 had a related patch set uploaded (by Jdrewniak; author: Jdrewniak):

[mediawiki/extensions/UniversalLanguageSelector@master] Lower .uls-menu z-index for Vector skin

https://gerrit.wikimedia.org/r/740718

gerritbot added a project: Patch-For-Review.Nov 23 2021, 7:17 AM
Jdrewniak moved this task from Ready for Development to Code Review on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.Nov 23 2021, 7:18 AM
bwang claimed this task.Nov 23 2021, 5:27 PM
bwang reassigned this task from bwang to Edtadros.Nov 24 2021, 4:54 PM
bwang moved this task from Code Review to QA on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.
gerritbot added a comment.Nov 24 2021, 5:13 PM

Change 740718 merged by jenkins-bot:

[mediawiki/extensions/UniversalLanguageSelector@master] Lower .uls-menu z-index for Vector skin

https://gerrit.wikimedia.org/r/740718

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.12; 2021-12-06).Nov 24 2021, 6:00 PM
Maintenance_bot removed a project: Patch-For-Review.Nov 24 2021, 6:10 PM
Edtadros moved this task from QA to QA in Prod on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.Dec 8 2021, 4:36 PM

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Monterey
Browser: Chrome
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps

✅ AC1: The ULS (if opened from the top of the page) should have a lower z-index than the sticky header.

Screen Recording 2021-12-08 at 8.35.15 AM.mov.gif (640×860 px, 949 KB)

Edtadros updated the task description. (Show Details)Dec 8 2021, 4:36 PM
Edtadros reassigned this task from Edtadros to ovasileva.Dec 18 2021, 8:41 PM
Edtadros moved this task from QA in Prod to Ready for Signoff on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.
Edtadros subscribed.

Test Result - Prod

Status: ✅ PASS
Environment: enwiki
OS: macOS Monterey
Browser: Chrome
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps

✅ AC1: The ULS (if opened from the top of the page) should have a lower z-index than the sticky header.

Screen Recording 2021-12-18 at 12.31.20 PM.mov.gif (932×858 px, 2 MB)

Note: @ovasileva , I created a task T297999 for the coordinates overlapping the page image. Hopefully it's not a dupe.

Edtadros updated the task description. (Show Details)Dec 18 2021, 8:42 PM
ovasileva closed this task as Resolved.Jan 4 2022, 11:08 AM

All done on this one. @Edtadros - it was actually a dupe, but thank you for opening anyhow!

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits