| ovasileva | |
| Nov 9 2021, 6:26 PM |
| F34882852: Screen Recording 2021-12-13 at 3.42.17 PM.mov.gif | |
| Dec 13 2021, 11:45 PM |
| F34882850: Screen Recording 2021-12-13 at 3.42.17 PM.mov.gif | |
| Dec 13 2021, 11:44 PM |
| F34863003: Screen Recording 2021-12-08 at 9.19.38 AM.mov.gif | |
| Dec 8 2021, 5:22 PM |
| F34749005: ULS from sticky header.webm | |
| Nov 15 2021, 6:48 PM |
Observed: ULS stays open and scrolls out of view
Expected: ULS should scroll along with the header (similar to the user menu)
| AC | Status | Details |
|---|---|---|
| 1 | ✅ | T295391#7556887 |
| AC | Status | Details |
|---|---|---|
| 1 | ✅ | T295391#7568159 |
The ULS overlay's position is calculated and set in the ULS extension. It also has "Display settings" and "Input settings" buttons, both of which open new overlays that are also positioned similarly.
This task could be achieved by updating the ULS extension to support fixed positioning, i.e. through a new option. This option would update the CSS and the positioning logic. Because fixed positioning is relative to the window viewport, this could be done by updating the positioning logic for the top attribute to account for the scroll height.
We also would need a better way to distinguish between ULS instances, as right now both content language switcher buttons are instantiated the same via the .mw-interlanguage-selector class.
Change 740962 had a related patch set uploaded (by Jdrewniak; author: Jdrewniak):
[mediawiki/extensions/UniversalLanguageSelector@master] Accommodate Vector sticky header in menu positioning
Change 740962 merged by jenkins-bot:
[mediawiki/extensions/UniversalLanguageSelector@master] Accommodate Vector sticky header in menu positioning
Status: ✅ PASS
Environment: beta
OS: macOS Monterey
Browser: Chrome
Device: MBP
Emulated Device:NA
Test Artifact(s):
Go to https://en.wikipedia.org/wiki/Japan?vectorstickyheader=1
Scroll down the page until sticky header appears and open the ULS
Continue scrolling
✅ AC1: Expected: ULS should scroll along with the header (similar to the user menu)
Status: ✅ PASS
Environment: enwiki{F34882850}
OS: macOS Monterey
Browser: Chrome
Device: MBP
Emulated Device:NA
Test Artifact(s):
Go to https://en.wikipedia.org/wiki/Japan?vectorstickyheader=1
Scroll down the page until sticky header appears and open the ULS
Continue scrolling
✅ AC1: Expected: ULS should scroll along with the header (similar to the user menu)
