Page MenuHomePhabricator
Create Task
Maniphest T296366

GrowthExperiments: Call to undefined method StatusValue::getTotalCount()
Closed, ResolvedPublicBUG REPORT
Actions

Description

From /srv/mediawiki/php-1.38.0-wmf.9/extensions/GrowthExperiments/includes/HomepageModules/SuggestedEdits.php(797)
#0 /srv/mediawiki/php-1.38.0-wmf.9/extensions/GrowthExperiments/includes/HomepageModules/BaseModule.php(165): GrowthExperiments\HomepageModules\SuggestedEdits->getActionData()
#1 /srv/mediawiki/php-1.38.0-wmf.9/extensions/GrowthExperiments/includes/DashboardModule/DashboardModule.php(184): GrowthExperiments\HomepageModules\BaseModule->outputDependencies()
#2 /srv/mediawiki/php-1.38.0-wmf.9/extensions/GrowthExperiments/includes/Specials/SpecialHomepage.php(335): GrowthExperiments\DashboardModule\DashboardModule->render(string)
#3 /srv/mediawiki/php-1.38.0-wmf.9/extensions/GrowthExperiments/includes/Specials/SpecialHomepage.php(315): GrowthExperiments\Specials\SpecialHomepage->getModuleRenderHtmlSafe(GrowthExperiments\HomepageModules\SuggestedEdits, string)
#4 /srv/mediawiki/php-1.38.0-wmf.9/extensions/GrowthExperiments/includes/Specials/SpecialHomepage.php(137): GrowthExperiments\Specials\SpecialHomepage->renderMobileSummary()
#5 /srv/mediawiki/php-1.38.0-wmf.9/includes/specialpage/SpecialPage.php(647): GrowthExperiments\Specials\SpecialHomepage->execute(NULL)
#6 /srv/mediawiki/php-1.38.0-wmf.9/includes/specialpage/SpecialPageFactory.php(1368): SpecialPage->run(NULL)
#7 /srv/mediawiki/php-1.38.0-wmf.9/includes/MediaWiki.php(314): MediaWiki\SpecialPage\SpecialPageFactory->executePath(string, RequestContext)
#8 /srv/mediawiki/php-1.38.0-wmf.9/includes/MediaWiki.php(925): MediaWiki->performRequest()
#9 /srv/mediawiki/php-1.38.0-wmf.9/includes/MediaWiki.php(559): MediaWiki->main()
#10 /srv/mediawiki/php-1.38.0-wmf.9/index.php(53): MediaWiki->run()
#11 /srv/mediawiki/php-1.38.0-wmf.9/index.php(46): wfIndexMain()
#12 /srv/mediawiki/w/index.php(3): require(string)
#13 {main}

example
Happens a couple times per hour.

Details

SubjectRepoBranchLines +/-
SearchTaskSuggester: Don't throw error on invalid tasktypemediawiki/extensions/GrowthExperimentsmaster+16 -7
Newcomer tasks: Fix filtering of non-existent task typesmediawiki/extensions/GrowthExperimentswmf/1.38.0-wmf.9+4 -5
Newcomer tasks: Fix filtering of non-existent task typesmediawiki/extensions/GrowthExperimentsmaster+4 -5
Fix error handling in SuggestedEdits::getActionData()mediawiki/extensions/GrowthExperimentswmf/1.38.0-wmf.9+7 -6
Fix error handling in SuggestedEdits::getActionData()mediawiki/extensions/GrowthExperimentsmaster+7 -6
Customize query in gerrit

Related Objects

Event Timeline

Tgr created this task.Nov 24 2021, 3:32 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 24 2021, 3:32 AM
Tgr moved this task from Incoming to Ready for Development on the Growth-Team (Sprint 0 (Growth Team)) board.Nov 24 2021, 3:32 AM
gerritbot added a comment.Nov 24 2021, 8:30 AM

Change 741081 had a related patch set uploaded (by Gergő Tisza; author: Gergő Tisza):

[mediawiki/extensions/GrowthExperiments@master] Fix error handling in SuggestedEdits::getActionData()

https://gerrit.wikimedia.org/r/741081

gerritbot added a project: Patch-For-Review.Nov 24 2021, 8:30 AM
Tgr moved this task from Ready for Development to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.Nov 24 2021, 8:30 AM
Tgr updated the task description. (Show Details)
Tgr updated the task description. (Show Details)
kostajh moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Nov 24 2021, 10:20 AM
gerritbot added a comment.Nov 24 2021, 10:46 AM

Change 741081 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Fix error handling in SuggestedEdits::getActionData()

https://gerrit.wikimedia.org/r/741081

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.12; 2021-12-06).Nov 24 2021, 11:00 AM
Maintenance_bot removed a project: Patch-For-Review.Nov 24 2021, 11:10 AM
Etonkovidova moved this task from QA to Test in Production | Watching on the Growth-Team (Sprint 0 (Growth Team)) board.Nov 24 2021, 6:11 PM
gerritbot added a comment.Nov 29 2021, 8:41 AM

Change 742254 had a related patch set uploaded (by Kosta Harlan; author: Gergő Tisza):

[mediawiki/extensions/GrowthExperiments@wmf/1.38.0-wmf.9] Fix error handling in SuggestedEdits::getActionData()

https://gerrit.wikimedia.org/r/742254

gerritbot added a project: Patch-For-Review.Nov 29 2021, 8:41 AM
Urbanecm_WMF subscribed.Nov 29 2021, 10:18 AM

Note the impact of this is fully broken suggested edits at German Wikipedia:

image.png (989×1 px, 181 KB)

I was able to reproduce at dewiki after doing new mw.Api().saveOption('growthexperiments-homepage-se-filters', null) to reset my filter preference to default value. Also see P17889 for a difference between a random user affected by the error and my account (before changing growthexperiments-homepage-se-filters to default, of course).

gerritbot added a comment.Nov 29 2021, 10:34 AM

Change 742433 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/GrowthExperiments@master] SearchTaskSuggester: Don't throw error on invalid tasktype

https://gerrit.wikimedia.org/r/742433

gerritbot added a comment.Nov 29 2021, 12:23 PM

Change 742254 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@wmf/1.38.0-wmf.9] Fix error handling in SuggestedEdits::getActionData()

https://gerrit.wikimedia.org/r/742254

Stashbot added a comment.Nov 29 2021, 12:32 PM

Mentioned in SAL (#wikimedia-operations) [2021-11-29T12:32:21Z] <urbanecm@deploy1002> Synchronized php-1.38.0-wmf.9/extensions/GrowthExperiments/includes/HomepageModules/SuggestedEdits.php: 05704407395fbf227eec47cf716393dc60a36a35: Fix error handling in SuggestedEdits::getActionData (T296366) (duration: 05m 37s)

ReleaseTaggerBot edited projects, added MW-1.38-notes (1.38.0-wmf.9; 2021-11-16); removed MW-1.38-notes (1.38.0-wmf.12; 2021-12-06).Nov 29 2021, 1:00 PM
gerritbot added a comment.Nov 29 2021, 5:58 PM

Change 742502 had a related patch set uploaded (by Gergő Tisza; author: Gergő Tisza):

[mediawiki/extensions/GrowthExperiments@master] Newcomer tasks: Fix filtering of non-existent task types

https://gerrit.wikimedia.org/r/742502

gerritbot added a comment.Nov 30 2021, 12:13 AM

Change 742502 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Newcomer tasks: Fix filtering of non-existent task types

https://gerrit.wikimedia.org/r/742502

ReleaseTaggerBot edited projects, added MW-1.38-notes (1.38.0-wmf.12; 2021-12-06); removed MW-1.38-notes (1.38.0-wmf.9; 2021-11-16).Nov 30 2021, 1:00 AM
gerritbot added a comment.Nov 30 2021, 1:04 AM

Change 742548 had a related patch set uploaded (by Gergő Tisza; author: Gergő Tisza):

[mediawiki/extensions/GrowthExperiments@wmf/1.38.0-wmf.9] Newcomer tasks: Fix filtering of non-existent task types

https://gerrit.wikimedia.org/r/742548

gerritbot added a comment.Dec 1 2021, 12:28 AM

Change 742548 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@wmf/1.38.0-wmf.9] Newcomer tasks: Fix filtering of non-existent task types

https://gerrit.wikimedia.org/r/742548

Stashbot added a comment.Dec 1 2021, 12:32 AM

Mentioned in SAL (#wikimedia-operations) [2021-12-01T00:32:21Z] <catrope@deploy1002> Synchronized php-1.38.0-wmf.9/extensions/GrowthExperiments/includes/NewcomerTasks/NewcomerTasksUserOptionsLookup.php: Backport: [[gerrit:742548|Newcomer tasks: Fix filtering of non-existent task types (T296366)]] (duration: 00m 56s)

ReleaseTaggerBot edited projects, added MW-1.38-notes (1.38.0-wmf.9; 2021-11-16); removed MW-1.38-notes (1.38.0-wmf.12; 2021-12-06).Dec 1 2021, 1:00 AM
Krinkle moved this task from Untriaged to Nov 2021 on the Wikimedia-production-error board.Dec 2 2021, 12:05 AM
Umherirrender closed this task as Resolved.Dec 4 2021, 4:55 PM
Umherirrender removed a project: Patch-For-Review.
gerritbot added a comment.Dec 13 2021, 9:23 AM

Change 742433 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] SearchTaskSuggester: Don't throw error on invalid tasktype

https://gerrit.wikimedia.org/r/742433

ReleaseTaggerBot edited projects, added MW-1.38-notes (1.38.0-wmf.13; 2021-12-13); removed MW-1.38-notes (1.38.0-wmf.9; 2021-11-16).Dec 13 2021, 10:00 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits