Page MenuHomePhabricator

[Add an image] Identify portrait-format images to add the upright parameter to them when published
Open, Needs TriagePublic

Description

Event Timeline

kostajh moved this task from Inbox to Needs Discussion on the Growth-Team board.
kostajh added subscribers: MMiller_WMF, RHo, kostajh.

@RHo @MMiller_WMF could you please comment if you want this done in the current sprint? It seems like it would be a pretty straightforward change.

@RHo @MMiller_WMF could you please comment if you want this done in the current sprint? It seems like it would be a pretty straightforward change.

Agree this sounds uncontroversial, but wanted to check with @Trizek-WMF that my understanding is correct about when we want the upright parameter to be applied. Do you mean adding it to the placed image at the "add caption" step or only after it is published?

The upright parameter would be added to the placed image when published. A user adding images won't have any idea of what is going on.

Got it, in that case yes, that sounds good to me! @kostajh if it is pretty straightforward happy to have this done in the current sprint.

RHo renamed this task from [Add an image] Identify portrait-format images to add the upright parameter to them to [Add an image] Identify portrait-format images to add the upright parameter to them when published.Dec 2 2021, 11:26 AM

My personal experience, and thus for proposing this is that, as a newer editor, I edited ~30 articles using the visual editor before I realized that this was happening. It seems like a straight-forward upgrade to the visual editor. By the way, I went back and modified those 30 edited articles using "upright". I have since noticed many articles with specific "px" instead of upright and manually fix those myself; so this seems to be a fairly widespread problem. So, when using the visual editor and dragging on an image to change its size, the underlying code should be in "upright" units rather than "px" units.