Hi @eigyan and all! I just checked the Farsi translation and it looks like the privacy statement link wasn't updated in translatewiki from when we had the URL changed (this is my bad) -- would it break anything on your end if I updated the link in the translation now? (or is there anything else I need to know?)

The appropriate link is https://foundation.wikimedia.org/wiki/Legal:Community_Safety_Survey_Privacy_Statement

@TAndic You can go ahead and update the link.

@eigyan Thank you - updated! Verification that it works?

@eigyan @jsn.sherman (including from our first translatewiki adventure) sorry, me again with more to update;

I see two different configurations on translatewiki for the survey (https://translatewiki.net/wiki/Special:Translate?filter=%21translated&action=translate&language=fa&group=ext-wikimediamessages)

Is it now using the stem:
MediaWiki:Ext-quicksurveys-internal-gdi-safety-survey-privacy-policy/fa
or
MediaWiki:Ext-quicksurveys-tst-internal-survey-answer-positive/fa

I can't tell where the deployment to Farsi beta cluster is sourcing from, as the question itself is still in the "untranslated" tab (maybe it just does its best and chooses what's there?)

@jsn.sherman would you be able to write up a ticket for what's needed for translation for this please? and link it back to this ticket?

We have green light from stakeholders and comms so we can unblock this.

Deployment was aborted on 02-03-2022 as we found a bug in WikiMediaMessages that we are awaiting an update from translatewiki to resolve.

It looks like we're probably waiting on MediaWiki_1.38/wmf.21?
There isn't a release branch for that yet in the WikimediaMessages extension, but I'm not sure what time on Monday those typically get generated:
https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/WikimediaMessages/+refs

fawiki is in group 2, so that would put the update on 10 February 2022

The release branch is there now:
https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/WikimediaMessages/+/refs/heads/wmf/1.38.0-wmf.21
So presumably it will roll out as expected on the 10th.

The release page lists wikimediamessages as unchanged, but it doesn't seem to list translation updates, presumably because most of the release notes would then be localization updates from translatewiki

Change 762490 had a related patch set uploaded (by Eigyan; author: Eigyan):

[operations/mediawiki-config@master] wmf-config: Deploy the fawiki test safety survey to production

https://gerrit.wikimedia.org/r/762490

Change 762490 merged by jenkins-bot:

[operations/mediawiki-config@master] wmf-config: Deploy the fawiki test safety survey to production

https://gerrit.wikimedia.org/r/762490

Change 761764 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[operations/mediawiki-config@master] Revert \"wmf-config: Deploy the fawiki test safety survey to production\"

https://gerrit.wikimedia.org/r/761764

Change 761764 merged by jenkins-bot:

[operations/mediawiki-config@master] Revert \"wmf-config: Deploy the fawiki test safety survey to production\"

https://gerrit.wikimedia.org/r/761764

Hello, in my role as a B&C deployer, I was asked by @eigyan to deploy https://gerrit.wikimedia.org/r/c/operations/mediawiki-config/+/762490 to Wikimedia production. Because after both @eigyan's and my tests, no survey was appearing and we wasn't able to figure out what's wrong, I decided to not deploy the patch (and that's why the patch got reverted).

Thank you so much for this update @Urbanecm, and for the revert. We'll look into this on our end.

Hi @eigyan and @Urbanecm -- just a thought, possibly unrelated but possibly related, is it maybe that the fa.wiki skin is set to default on the new Vector 2022 layout?

In T297629#7710979, @TAndic wrote:

Hi @eigyan and @Urbanecm -- just a thought, possibly unrelated but possibly related, is it maybe that the fa.wiki skin is set to default on the new Vector 2022 layout?

I think it's highly unlikely, although not impossible. I definitely did try to trigger the survey manually (via ?quicksurvey=internal-gdi-safety-survey) with my skin switched to Vector 2022, Vector and Timeless (my primary skin) at the very least.

Now that I'm playing with it again, it appears the issue I faced (I'm not sure if @eigyan, who was testing in parallel to me, faced the same issue or not) was I used the quicksurvey URL parameter at the main page. When I try it at other pages, it appears to work. If this is the only issue (@eigyan, more details on how testing went on your part would be appreciated), we might want to just try again?

Thank you so much for continuing to look into this @Urbanecm! I just went to a random page on fawiki and added a parameter for an example survey, but we've concluded the example surveys are not deployed (wisely). The survey was reverted so I'm assuming you mean on beta?

I'm actually on a call with @eigyan and other members of the team as we try to reproduce this right now.

@Urbanecm QuickSurveys has some known limitations to where surveys may be displayed:
https://www.mediawiki.org/wiki/Extension:QuickSurveys#Notes_and_Gotchas

The current hypothesis is that the "+fawiki" is not currently merging with the empty default array. @jsn.sherman and @eigyan are looking into why that would cause an issue. We may need to switch it for "fawiki" but it's also worth understanding why this is happening.

Hey Team, the process I used to debug/verify is to check for the existence of the survey key:value pair in local storage. When I did not see the gdi-survey survey as an available survey in local storage I assumed the change did not take. I also had a QA resource try to verify using these steps and they were unable to trigger the survey or any key:value pairs. here is an example of fawiki in beta-> notice the gdi-survey

Change 762881 had a related patch set uploaded (by Eigyan; author: Eigyan):

[operations/mediawiki-config@master] [wmf-config]: Deploy the fawiki test safety survey to production

https://gerrit.wikimedia.org/r/762881

After discussion in the engineering meeting, it was determined we should remove the "+" from the config as it was needed in beta and is not needed in production.

In T297629#7711455, @mepps wrote:

Thank you so much for continuing to look into this @Urbanecm! I just went to a random page on fawiki and added a parameter for an example survey, but we've concluded the example surveys are not deployed (wisely). The survey was reverted so I'm assuming you mean on beta?

Sorry for not being clear about that. The patch was indeed reverted – I deployed the survey's config to a debug server temporarily to be able to test it in production.

In T297629#7711635, @mepps wrote:

The current hypothesis is that the "+fawiki" is not currently merging with the empty default array. @jsn.sherman and @eigyan are looking into why that would cause an issue. We may need to switch it for "fawiki" but it's also worth understanding why this is happening.

I verified the config gets applied (and recognized by QuickSurveys) during the yesterday deployment. With the patch applied, the QuickSurveys.EnabledSurveys service properly recognized the newly-configured survey (but it didn't display, even when requested manually).

This is a paste I shared over IRC during the deployment window:

[urbanecm@mwdebug1001 ~]$ mwscript shell.php fawiki
Psy Shell v0.11.1 (PHP 7.2.34-18+0~20210223.60+debian10~1.gbpb21322+wmf5 — cli) by Justin Hileman
>>> $surveys = \MediaWiki\MediaWikiServices::getInstance()->getService( 'QuickSurveys.EnabledSurveys' )
=> [
     QuickSurveys\InternalSurvey {#5753},
   ]
>>> sudo $surveys[0]->name
=> "internal-gdi-safety-survey"
>>>

Hmm, even more curious @Urbanecm...and that you were able to see it on the debug server.

Change 762881 merged by jenkins-bot:

[operations/mediawiki-config@master] [wmf-config]: Deploy the fawiki test safety survey to production

https://gerrit.wikimedia.org/r/762881

Mentioned in SAL (#wikimedia-operations) [2022-02-22T21:25:29Z] <urbanecm@deploy1002> Synchronized wmf-config/InitialiseSettings.php: ee7608c7b56b579e2aaa50b504b6c2e28b63058e: Deploy the fawiki test safety survey to production (T297629) (duration: 00m 51s)

Using the url that @eigyan provided (https://fa.wikipedia.org/wiki/برلین?quicksurvey=internal-gdi-safety-survey), I was able to confirm the Quick Survey was displaying and functioning correctly on the Fawiki Production site...

Below are screenshots of the Quick Survey displaying on different devices/browsers:

Thanks @Djackson-ctr !

Confirming likewise that data is coming back and all looks good.

IMPORTANTLY: If anyone happens to see this and is testing out the survey, either send me a ping with your response so I can remove it OR try and test it at least twice with opposite responses (Yes and No, eg.) so I'll see the identical survey tokens and know to clean out the invalid responses. I had a bit of a scare yesterday wondering, "why are these US users without any edit buckets responding randomly? Is someone attempting to mess with the survey!?" 😂