Mentees assigned to others mentors are visible in my recent changes list
Closed, ResolvedPublicBUG REPORT
Actions

Description

This issue has been reported by NGC at ro.wp, and I also have encountered the issue at fr.wp: some of the mentees that appear in the list of recent changes under the "my mentees" filters aren't mentees assigned to the mentor's account.

Filters used by NGC 54 at ro.wp
Some mentees that are visible using the filters but who aren't assigned to them: Tudorrares111, AlexB15l, Constantin Dutchevici.

My filter at fr.wp
Some mentees that are visible using the filters but who aren't assigned to me: Lokotoro, Aayc03, LaMotte514
- I checked the 10 first mentees I have in my recent changes.

These users should only be visible to their mentors, not to other random mentors.

Details

	Subject	Repo	Branch	Lines +/-
	MentorFilterHooks: Include only primary mentors	mediawiki/extensions/GrowthExperiments	wmf/1.38.0-wmf.13	+4 -1
	MentorFilterHooks: Include only primary mentors	mediawiki/extensions/GrowthExperiments	master	+4 -1

Customize query in gerrit

Related Objects

Mentioned Here: rEGRE24e15e1fd5c7: MentorFilterHooks: Include only primary mentors

Event Timeline

Trizek-WMF created this task.Dec 20 2021, 2:09 PM

Restricted Application added a project: User-Urbanecm_WMF. · View Herald TranscriptDec 20 2021, 2:09 PM

Restricted Application added subscribers: Strainu, Aklapper. · View Herald Transcript

I can reproduce at cswiki. I'll investigate how this happens -- I suspect cache pollution might be happening somehow?

CC @Tgr as the code author.

Sophonauta is a mentee I see at (filtered) cswiki RC, who isn't assigned to me.

[urbanecm@mwmaint1002 ~]$ mwscript shell.php cswiki
Psy Shell v0.10.8 (PHP 7.2.34-18+0~20210223.60+debian10~1.gbpb21322+wmf3 — cli) by Justin Hileman
>>> use MediaWiki\MediaWikiServices;
>>> $config = MediaWikiServices::getInstance()->getMainConfig()
=> GlobalVarConfig {#511}
>>> $mentorStore = MediaWikiServices::getInstance()->get('GrowthExperimentsMentorStore')
=> GrowthExperiments\Mentorship\Store\DatabaseMentorStore {#5818}
>>> $starredMenteesStore = MediaWikiServices::getInstance()->get('GrowthExperimentsStarredMenteesStore')
=> GrowthExperiments\MentorDashboard\MenteeOverview\StarredMenteesStore {#3313}
>>> $mentorManager = MediaWikiServices::getInstance()->get('GrowthExperimentsMentorManager')
=> GrowthExperiments\Mentorship\MentorPageMentorManager {#5793}
>>> $hookHandler = new \GrowthExperiments\Mentorship\Hooks\MentorFilterHooks($config, $mentorStore, $starredMenteesStore, $mentorManager)
=> GrowthExperiments\Mentorship\Hooks\MentorFilterHooks {#6097}
>>> sudo $ids = $hookHandler->getUnstarredMenteeIds(User::newFromName('Martin Urbanec'))
[...]
>>> in_array(User::newFromName('Sophonauta')->getId(), $ids)
=> true
>>>

So, it's MentorFilterHooks::getUnstarredMenteeIds itself that's broken.

In T298031#7581375, @Urbanecm_WMF wrote:

Sophonauta is a mentee I see at (filtered) cswiki RC, who isn't assigned to me.
[...]
So, it's MentorFilterHooks::getUnstarredMenteeIds itself that's broken.

Or also not:

wikiadmin@10.64.32.11(cswiki)> select * from growthexperiments_mentor_mentee where gemm_mentee_id=557979;
+----------------+------------------+----------------+
| gemm_mentee_id | gemm_mentor_role | gemm_mentor_id |
+----------------+------------------+----------------+
|         557979 | backup           |         275298 |
|         557979 | primary          |          44751 |
+----------------+------------------+----------------+
2 rows in set (0.001 sec)

wikiadmin@10.64.32.11(cswiki)>

275298 is my user ID.

Root cause seems to be that the filtering code includes backup mentors in the game. That's not the expected behavior, and fortunately, easy to fix. Patch incoming.

Change 748829 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] MentorFilterHooks: Include only primary mentors

https://gerrit.wikimedia.org/r/748829

gerritbot added a project: Patch-For-Review.Dec 20 2021, 10:21 PM

Urbanecm_WMF changed the subtype of this task from "Task" to "Bug Report".Dec 20 2021, 10:22 PM

Urbanecm_WMF edited projects, added Growth-Team (Sprint 0 (Growth Team)), User-Urbanecm_WMF (Engineering); removed Growth-Team, User-Urbanecm_WMF.

Urbanecm_WMF moved this task from Incoming to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.

Urbanecm_WMF moved this task from Backlog to In review on the User-Urbanecm_WMF (Engineering) board.

• BilalShirwani closed this task as a duplicate of T298058: [Impact Analysis] Evaluate Impact of Mobile Reply and New Discussion Tools.Dec 21 2021, 12:04 AM

MusikAnimal reopened this task as Open.Dec 21 2021, 12:16 AM

Tgr moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Dec 23 2021, 7:09 AM

Change 748829 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] MentorFilterHooks: Include only primary mentors

https://gerrit.wikimedia.org/r/748829

Maintenance_bot removed a project: Patch-For-Review.Dec 23 2021, 8:10 AM

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.16; 2022-01-03).Dec 23 2021, 9:00 AM

Change 750807 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@wmf/1.38.0-wmf.13] MentorFilterHooks: Include only primary mentors

https://gerrit.wikimedia.org/r/750807

gerritbot added a project: Patch-For-Review.Jan 2 2022, 8:49 PM

Change 750807 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@wmf/1.38.0-wmf.13] MentorFilterHooks: Include only primary mentors

https://gerrit.wikimedia.org/r/750807

Mentioned in SAL (#wikimedia-operations) [2022-01-05T09:53:54Z] <urbanecm@deploy1002> Synchronized php-1.38.0-wmf.13/extensions/GrowthExperiments/includes/Mentorship/Hooks/MentorFilterHooks.php: 24e15e1fd5c7feb2377974ee666c61aef8f82da5: MentorFilterHooks: Include only primary mentors (T298031) (duration: 01m 07s)

Should be now fixed in production (wmf.13). FYI @Trizek-WMF, @Etonkovidova.

ReleaseTaggerBot edited projects, added MW-1.38-notes (1.38.0-wmf.13; 2021-12-13); removed MW-1.38-notes (1.38.0-wmf.16; 2022-01-03).Jan 5 2022, 10:00 AM

Maintenance_bot removed a project: Patch-For-Review.Jan 5 2022, 10:10 AM

Using my volunteer account, I checked in recent changes and I only have my mentees being displayed there.

That's great to know, thanks!

Checked in my cswiki mentor role, works as expected. Closing.

Mentees assigned to others mentors are visible in my recent changes listClosed, ResolvedPublicBUG REPORTActions

Description

Details

Related Objects

Event Timeline

Mentees assigned to others mentors are visible in my recent changes list
Closed, ResolvedPublicBUG REPORT
Actions