Change 753785 had a related patch set uploaded (by Clare Ming; author: Clare Ming):

[mediawiki/core@master] POC: check if TOC is enabled when using NOTOC magic word.

https://gerrit.wikimedia.org/r/753785

In order for Vector to know if the data is empty or not, would we also have to update Skin::getSectionsData to be protected instead of private? Or create another method like Skin::isTOCEmpty ?

hi @bwang -- if we output null for array-sections in Skin::getTemplateData when __NOTOC__ (via OutputPage::isTOCEnabled) is set -- we'll see that it's null in $parentData in SkinVector::getTemplateData too.

{{#array-sections}} will be skipped in the case of null, so no PHP should be required

e.g.

{{#array-sections}}
There is a TOC in this page.
{{/array-sections}}
{{^array-sections}}
There is no TOC in this page.
{{/array-sections}}

Change 753785 merged by jenkins-bot:

[mediawiki/core@master] Check if TOC is enabled when using NOTOC magic word to return sections data or not.

https://gerrit.wikimedia.org/r/753785

Change 756715 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):

[mediawiki/skins/Vector@master] Ensure TOC is not shown when section data is empty

https://gerrit.wikimedia.org/r/756715

Change 757037 had a related patch set uploaded (by Clare Ming; author: Bernard Wang):

[mediawiki/core@master] Add additional layer of nesting to TOC data to better support rendering of TOC with mustache templates

https://gerrit.wikimedia.org/r/757037

Change 757390 had a related patch set uploaded (by Clare Ming; author: Clare Ming):

[mediawiki/skins/Vector@master] Update TOC template with data wrapper

https://gerrit.wikimedia.org/r/757390

Change 757390 abandoned by Clare Ming:

[mediawiki/skins/Vector@master] Update TOC template and logic

Reason:

spoke with Bernard - he already has a patch going so abandoning in favor of https://gerrit.wikimedia.org/r/c/mediawiki/skins/Vector/+/756715

https://gerrit.wikimedia.org/r/757390

Change 757037 merged by jenkins-bot:

[mediawiki/core@master] Add additional layer of nesting to TOC data to better support rendering of TOC with mustache templates

https://gerrit.wikimedia.org/r/757037

Change 756715 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Rely on core TOC data to show the TOC in Vector

https://gerrit.wikimedia.org/r/756715

Test Result - Beta
Status: ✅ (but another bug should be taken care of)
Environment: beta
OS: Windows 11 Family 21H2
Browser: Vivaldi
Device: Desktop
Emulated Device:NA

Test Artifact(s):

QA Steps
With the new Vector skin:

✅ AC1: Visit https://en.wikipedia.beta.wmflabs.org/wiki/Table_of_contents_test_page?tableofcontents=1 and confirm the table of contents is visible in the sidebar
TOC is there as long as long as I don't try to display the left bar at the same time, even after scrolling (see screenshot #2). I think a new task should be creates for this bug.

✅ AC2: Visit https://en.wikipedia.beta.wmflabs.org/wiki/Table_of_contents_NOTOC_test_page?tableofcontents=1 and confirm the table of contents does not display in the sidebar or the article

@Feldo - see T300875: [ToC] Render main menu above the ToC for the next steps on the issue you raised

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Monterey
Browser: Chrome
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps

With the new Vector skin:

✅ AC1: Visit https://en.wikipedia.beta.wmflabs.org/wiki/Table_of_contents_test_page?tableofcontents=1 and confirm the table of contents is visible in the sidebar