Page MenuHomePhabricator

deformed layout of ogg player options in new gallery
Closed, ResolvedPublic

Description

Author: a.d.bergi

Description:
I'm not sure whether this belongs to images, page rendering or even javascript.

Having a ogg video embedded in one of the new galleries with variable width, you can't set options any more.
Clicking on the play symbol returns a link "optionen..." with a javascript:void("options")-href (which is also bad, this should be done with event listeners).
Clicking on this link pops up the options div (<div style="width: 110px; display: none;" class="ogg-player-options" id="ogg_player_1_options_box" align="center">) which will be displayed wrong as the surrounding <div class="thumb"... element has fixed width and height.

Solutions would be
a) rewriting the js with detecting this case or
b) a css patch like
div.thumb { position: relative; }
div.thumb div.ogg-player-options { position:absolute; top:150px; }


Version: 1.17.x
Severity: major
URL: %3Cgallery%3E%0A%20%20Datei:Space%20Shuttle%20Enterprise%20747%20separation.ogg%7CText%0A%3C/gallery%3E%0AText%20Text%20Text%20Text%20Text%20Text%20Text%20Text%20Text%20Text

Details

Reference
bz27982

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:28 PM
bzimport set Reference to bz27982.
TheDJ added a comment.Mar 14 2011, 9:29 PM

This primarily requires deploy of r82181, r82215 and r82309

Though then it's still ugly, but i'll follow that up later.

Marking fixed as the fix is in trunk. Code will be deployed shortly.