Page MenuHomePhabricator

Write code for handing write and read of rev_comment_id
Closed, ResolvedPublic

Description

Basically gerrit:684142 but for comment table (and rev_comment_id field). Including the maint script for it. The configuration and so on.

Details

SubjectRepoBranchLines +/-
mediawiki/coremaster+6 -45
operations/mediawiki-configmaster+0 -13
mediawiki/coremaster+5 -64
operations/mediawiki-configmaster+0 -6
operations/mediawiki-configmaster+3 -0
operations/mediawiki-configmaster+1 -1
operations/mediawiki-configmaster+3 -0
operations/mediawiki-configmaster+0 -18
operations/mediawiki-configmaster+3 -0
operations/mediawiki-configmaster+3 -0
operations/mediawiki-configmaster+9 -0
mediawiki/coremaster+6 -13
operations/mediawiki-configmaster+1 -1
operations/mediawiki-configmaster+1 -1
mediawiki/coremaster+16 -1
mediawiki/coremaster+114 -0
operations/mediawiki-configmaster+3 -0
mediawiki/coremaster+2 -0
operations/mediawiki-configmaster+1 -1
operations/mediawiki-configmaster+0 -15
operations/mediawiki-configmaster+3 -0
operations/mediawiki-configmaster+3 -0
operations/mediawiki-configmaster+9 -0
operations/mediawiki-configmaster+6 -0
mediawiki/coremaster+48 -12
operations/mediawiki-configmaster+7 -0
Show related patches Customize query in gerrit

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes

Mentioned in SAL (#wikimedia-operations) [2023-01-11T22:51:40Z] <zabe@deploy1002> Finished scap: Backport for [[gerrit:879055|Start reading from cuc_actor on group0 and group1 wikis (T233004)]], [[gerrit:879148|Start writing to rev_comment_id on group0 wikis (T299954)]], [[gerrit:879057|Stop writing to cul_user and cul_user_text on testwiki (T233004)]] (duration: 09m 28s)

Change 879591 had a related patch set uploaded (by Zabe; author: Zabe):

[operations/mediawiki-config@master] Start writing to rev_comment_id on group1 wikis

https://gerrit.wikimedia.org/r/879591

Change 879591 merged by jenkins-bot:

[operations/mediawiki-config@master] Start writing to rev_comment_id on group1 wikis

https://gerrit.wikimedia.org/r/879591

Mentioned in SAL (#wikimedia-operations) [2023-01-12T16:21:46Z] <zabe@deploy1002> Started scap: Backport for [[gerrit:879590|Stop writing to cul_user and cul_user_text on a few wikis (T233004)]], [[gerrit:879591|Start writing to rev_comment_id on group1 wikis (T299954)]]

Mentioned in SAL (#wikimedia-operations) [2023-01-12T16:23:30Z] <zabe@deploy1002> zabe and zabe: Backport for [[gerrit:879590|Stop writing to cul_user and cul_user_text on a few wikis (T233004)]], [[gerrit:879591|Start writing to rev_comment_id on group1 wikis (T299954)]] synced to the testservers: mwdebug1002.eqiad.wmnet, mwdebug2002.codfw.wmnet, mwdebug2001.codfw.wmnet, mwdebug1001.eqiad.wmnet

Mentioned in SAL (#wikimedia-operations) [2023-01-12T16:31:35Z] <zabe@deploy1002> Finished scap: Backport for [[gerrit:879590|Stop writing to cul_user and cul_user_text on a few wikis (T233004)]], [[gerrit:879591|Start writing to rev_comment_id on group1 wikis (T299954)]] (duration: 09m 49s)

Change 880902 had a related patch set uploaded (by Zabe; author: Zabe):

[operations/mediawiki-config@master] Start writing to rev_comment_id everywhere

https://gerrit.wikimedia.org/r/880902

Change 880902 merged by jenkins-bot:

[operations/mediawiki-config@master] Start writing to rev_comment_id everywhere

https://gerrit.wikimedia.org/r/880902

Mentioned in SAL (#wikimedia-operations) [2023-01-17T22:55:54Z] <zabe@deploy1002> Started scap: Backport for [[gerrit:880903|Stop writing to cul_user and cul_user_text everywhere (T233004)]], [[gerrit:880902|Start writing to rev_comment_id everywhere (T299954)]]

Mentioned in SAL (#wikimedia-operations) [2023-01-17T22:57:39Z] <zabe@deploy1002> zabe and zabe: Backport for [[gerrit:880903|Stop writing to cul_user and cul_user_text everywhere (T233004)]], [[gerrit:880902|Start writing to rev_comment_id everywhere (T299954)]] synced to the testservers: mwdebug2002.codfw.wmnet, mwdebug2001.codfw.wmnet, mwdebug1002.eqiad.wmnet, mwdebug1001.eqiad.wmnet

Mentioned in SAL (#wikimedia-operations) [2023-01-17T23:06:24Z] <zabe@deploy1002> Finished scap: Backport for [[gerrit:880903|Stop writing to cul_user and cul_user_text everywhere (T233004)]], [[gerrit:880902|Start writing to rev_comment_id everywhere (T299954)]] (duration: 10m 29s)

Change 873906 merged by jenkins-bot:

[mediawiki/core@master] Add migrateRevisionCommentTemp maintenance script

https://gerrit.wikimedia.org/r/873906

Mentioned in SAL (#wikimedia-releng) [2023-01-19T19:10:48Z] <zabe> zabe@deployment-mwmaint02:~$ foreachwiki migrateRevisionCommentTemp.php # T299954

Mentioned in SAL (#wikimedia-releng) [2023-01-19T19:10:48Z] <zabe> zabe@deployment-mwmaint02:~$ foreachwiki migrateRevisionCommentTemp.php # T299954

Since it might not be obvious for everyone: that is beta-cluster.

Change 881729 had a related patch set uploaded (by Zabe; author: Zabe):

[operations/mediawiki-config@master] beta: start reading from rev_comment_id

https://gerrit.wikimedia.org/r/881729

Change 881729 merged by jenkins-bot:

[operations/mediawiki-config@master] beta: start reading from rev_comment_id

https://gerrit.wikimedia.org/r/881729

Change 881834 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/core@master] migrateRevisionCommentTemp: Improve select query

https://gerrit.wikimedia.org/r/881834

Change 881834 merged by jenkins-bot:

[mediawiki/core@master] migrateRevisionCommentTemp: Improve select query

https://gerrit.wikimedia.org/r/881834

Change 883281 had a related patch set uploaded (by Zabe; author: Zabe):

[operations/mediawiki-config@master] Start reading from rev_comment_id on testcommonswiki

https://gerrit.wikimedia.org/r/883281

Change 883281 merged by jenkins-bot:

[operations/mediawiki-config@master] Start reading from rev_comment_id on testcommonswiki

https://gerrit.wikimedia.org/r/883281

Mentioned in SAL (#wikimedia-operations) [2023-01-24T23:02:27Z] <zabe@deploy1002> Started scap: Backport for [[gerrit:883281|Start reading from rev_comment_id on testcommonswiki (T299954)]]

Mentioned in SAL (#wikimedia-operations) [2023-01-24T23:04:12Z] <zabe@deploy1002> zabe: Backport for [[gerrit:883281|Start reading from rev_comment_id on testcommonswiki (T299954)]] synced to the testservers: mwdebug2001.codfw.wmnet, mwdebug1002.eqiad.wmnet, mwdebug1001.eqiad.wmnet, mwdebug2002.codfw.wmnet

Mentioned in SAL (#wikimedia-operations) [2023-01-24T23:10:29Z] <zabe@deploy1002> Finished scap: Backport for [[gerrit:883281|Start reading from rev_comment_id on testcommonswiki (T299954)]] (duration: 08m 02s)

Change 886429 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/core@master] respect migration stage when deleting from revision_comment_temp

https://gerrit.wikimedia.org/r/886429

Change 886429 merged by jenkins-bot:

[mediawiki/core@master] respect migration stage when deleting from revision_comment_temp

https://gerrit.wikimedia.org/r/886429

I think there are some slow queries caused by this:
https://logstash.wikimedia.org/goto/8d65c3242be7d6345881e0dccf2ee46f

I don't like the (CASE WHEN rev_comment_id != 0 THEN rev_comment_id ELSE temp_rev_comment.revcomment_comment_id END). Just respect the wiki's config until this is over.

Change 889266 had a related patch set uploaded (by Zabe; author: Zabe):

[operations/mediawiki-config@master] Stop trying to read from rev_comment_id

https://gerrit.wikimedia.org/r/889266

Change 889266 merged by jenkins-bot:

[operations/mediawiki-config@master] Stop trying to read from rev_comment_id

https://gerrit.wikimedia.org/r/889266

Mentioned in SAL (#wikimedia-operations) [2023-02-15T01:22:04Z] <zabe@deploy1002> Synchronized wmf-config/InitialiseSettings.php: T299954 (duration: 06m 50s)

Thanks. Now slow queries by this code path went to zero basically.

Change 922492 had a related patch set uploaded (by Zabe; author: Zabe):

[operations/mediawiki-config@master] Start reading from rev_comment_id in test wikis

https://gerrit.wikimedia.org/r/922492

Change 923748 had a related patch set uploaded (by Zabe; author: Zabe):

[operations/mediawiki-config@master] beta: Stop writing to revision_comment_temp

https://gerrit.wikimedia.org/r/923748

Change 923748 merged by jenkins-bot:

[operations/mediawiki-config@master] beta: Stop writing to revision_comment_temp

https://gerrit.wikimedia.org/r/923748

Change 923749 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/core@master] Migrate revision_comment_temp to rev_comment_id

https://gerrit.wikimedia.org/r/923749

Change 923750 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/core@master] Drop revision_comment_temp

https://gerrit.wikimedia.org/r/923750

Change 924123 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/core@master] Drop $wgCommentTempTableSchemaMigrationStage

https://gerrit.wikimedia.org/r/924123

Change 923749 merged by jenkins-bot:

[mediawiki/core@master] Migrate revision_comment_temp to rev_comment_id

https://gerrit.wikimedia.org/r/923749

Change 922492 merged by jenkins-bot:

[operations/mediawiki-config@master] Start reading from rev_comment_id in test wikis

https://gerrit.wikimedia.org/r/922492

Mentioned in SAL (#wikimedia-operations) [2023-05-30T09:29:23Z] <zabe@deploy1002> Started scap: Backport for [[gerrit:922492|Start reading from rev_comment_id in test wikis (T299954)]]

Mentioned in SAL (#wikimedia-operations) [2023-05-30T09:30:53Z] <zabe@deploy1002> zabe: Backport for [[gerrit:922492|Start reading from rev_comment_id in test wikis (T299954)]] synced to the testservers: mwdebug1002.eqiad.wmnet, mwdebug2002.codfw.wmnet, mwdebug2001.codfw.wmnet, mwdebug1001.eqiad.wmnet

Mentioned in SAL (#wikimedia-operations) [2023-05-30T09:37:11Z] <zabe@deploy1002> Finished scap: Backport for [[gerrit:922492|Start reading from rev_comment_id in test wikis (T299954)]] (duration: 07m 48s)

Change 924469 had a related patch set uploaded (by Zabe; author: Zabe):

[operations/mediawiki-config@master] Start reading from rev_comment_id in group0 wikis

https://gerrit.wikimedia.org/r/924469

Change 924469 merged by jenkins-bot:

[operations/mediawiki-config@master] Start reading from rev_comment_id in group0 wikis

https://gerrit.wikimedia.org/r/924469

Mentioned in SAL (#wikimedia-operations) [2023-05-30T09:52:36Z] <zabe@deploy1002> Started scap: Backport for [[gerrit:924469|Start reading from rev_comment_id in group0 wikis (T299954)]]

Mentioned in SAL (#wikimedia-operations) [2023-05-30T09:54:49Z] <zabe@deploy1002> zabe: Backport for [[gerrit:924469|Start reading from rev_comment_id in group0 wikis (T299954)]] synced to the testservers: mwdebug2002.codfw.wmnet, mwdebug1001.eqiad.wmnet, mwdebug1002.eqiad.wmnet, mwdebug2001.codfw.wmnet

Mentioned in SAL (#wikimedia-operations) [2023-05-30T10:00:48Z] <zabe@deploy1002> Finished scap: Backport for [[gerrit:924469|Start reading from rev_comment_id in group0 wikis (T299954)]] (duration: 08m 12s)

Change 924564 had a related patch set uploaded (by Zabe; author: Zabe):

[operations/mediawiki-config@master] Start reading from rev_comment_id in group1 wikis

https://gerrit.wikimedia.org/r/924564

Change 924564 merged by jenkins-bot:

[operations/mediawiki-config@master] Start reading from rev_comment_id in group1 wikis

https://gerrit.wikimedia.org/r/924564

Mentioned in SAL (#wikimedia-operations) [2023-05-30T23:30:01Z] <zabe@deploy1002> Started scap: Backport for [[gerrit:924564|Start reading from rev_comment_id in group1 wikis (T299954)]]

Mentioned in SAL (#wikimedia-operations) [2023-05-30T23:31:32Z] <zabe@deploy1002> zabe: Backport for [[gerrit:924564|Start reading from rev_comment_id in group1 wikis (T299954)]] synced to the testservers: mwdebug2001.codfw.wmnet, mwdebug2002.codfw.wmnet, mwdebug1001.eqiad.wmnet, mwdebug1002.eqiad.wmnet

Change 924605 had a related patch set uploaded (by Zabe; author: Zabe):

[operations/mediawiki-config@master] Start reading from rev_comment_id everywhere

https://gerrit.wikimedia.org/r/924605

Mentioned in SAL (#wikimedia-operations) [2023-05-30T23:38:02Z] <zabe@deploy1002> Finished scap: Backport for [[gerrit:924564|Start reading from rev_comment_id in group1 wikis (T299954)]] (duration: 08m 00s)

Change 924605 merged by jenkins-bot:

[operations/mediawiki-config@master] Start reading from rev_comment_id everywhere

https://gerrit.wikimedia.org/r/924605

Mentioned in SAL (#wikimedia-operations) [2023-05-31T20:52:41Z] <zabe@deploy1002> Started scap: Backport for [[gerrit:924605|Start reading from rev_comment_id everywhere (T299954)]]

Mentioned in SAL (#wikimedia-operations) [2023-05-31T20:54:15Z] <zabe@deploy1002> zabe: Backport for [[gerrit:924605|Start reading from rev_comment_id everywhere (T299954)]] synced to the testservers: mwdebug2002.codfw.wmnet, mwdebug1002.eqiad.wmnet, mwdebug1001.eqiad.wmnet, mwdebug2001.codfw.wmnet

Mentioned in SAL (#wikimedia-operations) [2023-05-31T21:00:26Z] <zabe@deploy1002> Finished scap: Backport for [[gerrit:924605|Start reading from rev_comment_id everywhere (T299954)]] (duration: 07m 44s)

Change 925047 had a related patch set uploaded (by Zabe; author: Zabe):

[operations/mediawiki-config@master] Stop writing to revision_comment_temp in testwiki

https://gerrit.wikimedia.org/r/925047

Change 925047 merged by jenkins-bot:

[operations/mediawiki-config@master] Stop writing to revision_comment_temp in testwiki

https://gerrit.wikimedia.org/r/925047

Mentioned in SAL (#wikimedia-operations) [2023-06-05T22:40:27Z] <zabe@deploy1002> Started scap: Backport for [[gerrit:925047|Stop writing to revision_comment_temp in testwiki (T299954)]]

Mentioned in SAL (#wikimedia-operations) [2023-06-05T22:41:48Z] <zabe@deploy1002> zabe: Backport for [[gerrit:925047|Stop writing to revision_comment_temp in testwiki (T299954)]] synced to the testservers: mwdebug1002.eqiad.wmnet, mwdebug1001.eqiad.wmnet, mwdebug2002.codfw.wmnet, mwdebug2001.codfw.wmnet

Mentioned in SAL (#wikimedia-operations) [2023-06-05T22:49:41Z] <zabe@deploy1002> Finished scap: Backport for [[gerrit:925047|Stop writing to revision_comment_temp in testwiki (T299954)]] (duration: 09m 13s)

Change 927312 had a related patch set uploaded (by Zabe; author: Zabe):

[operations/mediawiki-config@master] Stop writing to revision_comment_temp in group0 wikis

https://gerrit.wikimedia.org/r/927312

Change 927312 merged by jenkins-bot:

[operations/mediawiki-config@master] Stop writing to revision_comment_temp in group0 wikis

https://gerrit.wikimedia.org/r/927312

Mentioned in SAL (#wikimedia-operations) [2023-06-05T23:42:27Z] <zabe@deploy1002> Started scap: Backport for [[gerrit:927312|Stop writing to revision_comment_temp in group0 wikis (T299954)]]

Mentioned in SAL (#wikimedia-operations) [2023-06-05T23:43:47Z] <zabe@deploy1002> zabe: Backport for [[gerrit:927312|Stop writing to revision_comment_temp in group0 wikis (T299954)]] synced to the testservers: mwdebug1001.eqiad.wmnet, mwdebug2001.codfw.wmnet, mwdebug2002.codfw.wmnet, mwdebug1002.eqiad.wmnet

Mentioned in SAL (#wikimedia-operations) [2023-06-05T23:49:29Z] <zabe@deploy1002> Finished scap: Backport for [[gerrit:927312|Stop writing to revision_comment_temp in group0 wikis (T299954)]] (duration: 07m 02s)

Change 927594 had a related patch set uploaded (by Zabe; author: Zabe):

[operations/mediawiki-config@master] Stop writing to revision_comment_temp in group1 wikis

https://gerrit.wikimedia.org/r/927594

Change 927594 merged by jenkins-bot:

[operations/mediawiki-config@master] Stop writing to revision_comment_temp in group1 wikis

https://gerrit.wikimedia.org/r/927594

Mentioned in SAL (#wikimedia-operations) [2023-06-06T10:44:50Z] <zabe@deploy1002> Started scap: Backport for [[gerrit:927594|Stop writing to revision_comment_temp in group1 wikis (T299954)]]

Mentioned in SAL (#wikimedia-operations) [2023-06-06T10:46:23Z] <zabe@deploy1002> zabe: Backport for [[gerrit:927594|Stop writing to revision_comment_temp in group1 wikis (T299954)]] synced to the testservers: mwdebug2001.codfw.wmnet, mwdebug1002.eqiad.wmnet, mwdebug1001.eqiad.wmnet, mwdebug2002.codfw.wmnet

Mentioned in SAL (#wikimedia-operations) [2023-06-06T10:51:54Z] <zabe@deploy1002> Finished scap: Backport for [[gerrit:927594|Stop writing to revision_comment_temp in group1 wikis (T299954)]] (duration: 07m 03s)

Change 927615 had a related patch set uploaded (by Zabe; author: Zabe):

[operations/mediawiki-config@master] Stop writing to revision_comment_temp everywhere

https://gerrit.wikimedia.org/r/927615

Change 927615 merged by jenkins-bot:

[operations/mediawiki-config@master] Stop writing to revision_comment_temp everywhere

https://gerrit.wikimedia.org/r/927615

Mentioned in SAL (#wikimedia-operations) [2023-06-06T22:19:41Z] <zabe@deploy1002> Started scap: Backport for [[gerrit:927615|Stop writing to revision_comment_temp everywhere (T299954)]]

Mentioned in SAL (#wikimedia-operations) [2023-06-06T22:21:32Z] <zabe@deploy1002> zabe: Backport for [[gerrit:927615|Stop writing to revision_comment_temp everywhere (T299954)]] synced to the testservers: mwdebug2001.codfw.wmnet, mwdebug1002.eqiad.wmnet, mwdebug1001.eqiad.wmnet, mwdebug2002.codfw.wmnet

Mentioned in SAL (#wikimedia-operations) [2023-06-06T22:27:14Z] <zabe@deploy1002> Finished scap: Backport for [[gerrit:927615|Stop writing to revision_comment_temp everywhere (T299954)]] (duration: 07m 33s)

Any further patch should be connected to T215466

Change 923750 merged by jenkins-bot:

[mediawiki/core@master] Drop revision_comment_temp

https://gerrit.wikimedia.org/r/923750

Change 924123 merged by jenkins-bot:

[mediawiki/core@master] Drop $wgCommentTempTableSchemaMigrationStage

https://gerrit.wikimedia.org/r/924123

Change 929997 had a related patch set uploaded (by Zabe; author: Zabe):

[operations/mediawiki-config@master] Stop setting $wgCommentTempTableSchemaMigrationStage

https://gerrit.wikimedia.org/r/929997

Change 929997 merged by jenkins-bot:

[operations/mediawiki-config@master] Stop setting $wgCommentTempTableSchemaMigrationStage

https://gerrit.wikimedia.org/r/929997

Mentioned in SAL (#wikimedia-operations) [2023-07-04T22:38:05Z] <zabe@deploy1002> Started scap: Backport for [[gerrit:929997|Stop setting $wgCommentTempTableSchemaMigrationStage (T299954)]]

Mentioned in SAL (#wikimedia-operations) [2023-07-04T22:39:39Z] <zabe@deploy1002> zabe: Backport for [[gerrit:929997|Stop setting $wgCommentTempTableSchemaMigrationStage (T299954)]] synced to the testservers: mwdebug2001.codfw.wmnet, mwdebug1001.eqiad.wmnet, mwdebug2002.codfw.wmnet, mwdebug1002.eqiad.wmnet

Mentioned in SAL (#wikimedia-operations) [2023-07-04T22:46:01Z] <zabe@deploy1002> Finished scap: Backport for [[gerrit:929997|Stop setting $wgCommentTempTableSchemaMigrationStage (T299954)]] (duration: 07m 56s)