Page MenuHomePhabricator
Create Task
Maniphest T299954

Write code for handing write and read of rev_comment_id
Open, Needs TriagePublic
Actions

Description

Basically gerrit:684142 but for comment table (and rev_comment_id field). Including the maint script for it. The configuration and so on.

Details

Show related patches Customize query in gerrit

Related Objects
Search...

Event Timeline

Ladsgroup created this task.Jan 24 2022, 6:55 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 24 2022, 6:55 PM
Ladsgroup mentioned this in T297633: <Tech Initiative> Improving Databases in MediaWiki.Jan 24 2022, 8:02 PM
DannyS712 added a subscriber: DannyS712.Jan 25 2022, 1:11 AM
Zabe added a subscriber: Zabe.Apr 2 2022, 11:13 AM
Universal_Omega added a subscriber: Universal_Omega.Jul 31 2022, 6:07 PM
Zabe claimed this task.Dec 31 2022, 1:59 PM
gerritbot added a comment.Dec 31 2022, 1:59 PM

Change 872985 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/core@master] Prepare migration from revision_comment_temp to rev_comment_id

https://gerrit.wikimedia.org/r/872985

gerritbot added a project: Patch-For-Review.Dec 31 2022, 1:59 PM
gerritbot added a comment.Dec 31 2022, 2:03 PM

Change 873887 had a related patch set uploaded (by Zabe; author: Zabe):

[operations/mediawiki-config@master] Pin $wgCommentTempTableSchemaMigrationStage to default value

https://gerrit.wikimedia.org/r/873887

gerritbot added a comment.Dec 31 2022, 2:10 PM

Change 873888 had a related patch set uploaded (by Zabe; author: Zabe):

[operations/mediawiki-config@master] beta: Start writing to rev_comment_id

https://gerrit.wikimedia.org/r/873888

gerritbot added a comment.Dec 31 2022, 3:08 PM

Change 873906 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/core@master] Migrate revision comments from revision_comment_id to rev_comment_id

https://gerrit.wikimedia.org/r/873906

gerritbot added a comment.Jan 3 2023, 9:05 PM

Change 873887 merged by jenkins-bot:

[operations/mediawiki-config@master] Pin $wgCommentTempTableSchemaMigrationStage to default value

https://gerrit.wikimedia.org/r/873887

Stashbot added a comment.Jan 3 2023, 9:06 PM

Mentioned in SAL (#wikimedia-operations) [2023-01-03T21:06:40Z] <taavi@deploy1002> Started scap: Backport for [[gerrit:873880|Stop setting $wgActorTableSchemaMigrationStage (T215466)]], [[gerrit:873887|Pin $wgCommentTempTableSchemaMigrationStage to default value (T299954)]], [[gerrit:874418|Pin cu_changes comment migration to old schema (T233004)]]

Stashbot mentioned this in T215466: Remove revision_comment_temp and revision_actor_temp.Jan 3 2023, 9:06 PM
Stashbot mentioned this in T233004: Update CheckUser for actor and comment table.

Mentioned in SAL (#wikimedia-operations) [2023-01-03T21:08:30Z] <taavi@deploy1002> taavi and zabe: Backport for [[gerrit:873880|Stop setting $wgActorTableSchemaMigrationStage (T215466)]], [[gerrit:873887|Pin $wgCommentTempTableSchemaMigrationStage to default value (T299954)]], [[gerrit:874418|Pin cu_changes comment migration to old schema (T233004)]] synced to the testservers: mwdebug1001.eqiad.wmnet, mwdebug2002.codfw.wmnet, mwdebug1002.eqiad.wmnet, mwdebug2001.codfw.wmnet

Stashbot added a comment.Jan 3 2023, 9:15 PM

Mentioned in SAL (#wikimedia-operations) [2023-01-03T21:15:29Z] <taavi@deploy1002> Finished scap: Backport for [[gerrit:873880|Stop setting $wgActorTableSchemaMigrationStage (T215466)]], [[gerrit:873887|Pin $wgCommentTempTableSchemaMigrationStage to default value (T299954)]], [[gerrit:874418|Pin cu_changes comment migration to old schema (T233004)]] (duration: 08m 49s)

gerritbot added a comment.Mon, Jan 9, 9:02 PM

Change 872985 merged by jenkins-bot:

[mediawiki/core@master] Prepare migration from revision_comment_temp to rev_comment_id

https://gerrit.wikimedia.org/r/872985

gerritbot added a comment.Mon, Jan 9, 9:51 PM

Change 873888 merged by jenkins-bot:

[operations/mediawiki-config@master] beta: Start writing to rev_comment_id

https://gerrit.wikimedia.org/r/873888

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.18; 2023-01-09).Mon, Jan 9, 10:00 PM
gerritbot added a comment.Tue, Jan 10, 10:28 PM

Change 878207 had a related patch set uploaded (by Zabe; author: Zabe):

[operations/mediawiki-config@master] Start writing to rev_comment_id on test wikis

https://gerrit.wikimedia.org/r/878207

gerritbot added a comment.Tue, Jan 10, 11:20 PM

Change 878207 merged by jenkins-bot:

[operations/mediawiki-config@master] Start writing to rev_comment_id on test wikis

https://gerrit.wikimedia.org/r/878207

Stashbot added a comment.Tue, Jan 10, 11:21 PM

Mentioned in SAL (#wikimedia-operations) [2023-01-10T23:21:16Z] <zabe@deploy1002> Started scap: Backport for [[gerrit:878207|Start writing to rev_comment_id on test wikis (T299954)]]

Stashbot added a comment.Tue, Jan 10, 11:22 PM

Mentioned in SAL (#wikimedia-operations) [2023-01-10T23:22:54Z] <zabe@deploy1002> zabe and zabe: Backport for [[gerrit:878207|Start writing to rev_comment_id on test wikis (T299954)]] synced to the testservers: mwdebug1001.eqiad.wmnet, mwdebug1002.eqiad.wmnet, mwdebug2002.codfw.wmnet, mwdebug2001.codfw.wmnet

Stashbot added a comment.Tue, Jan 10, 11:30 PM

Mentioned in SAL (#wikimedia-operations) [2023-01-10T23:30:56Z] <zabe@deploy1002> Finished scap: Backport for [[gerrit:878207|Start writing to rev_comment_id on test wikis (T299954)]] (duration: 09m 39s)

gerritbot added a comment.Wed, Jan 11, 10:21 PM

Change 879148 had a related patch set uploaded (by Zabe; author: Zabe):

[operations/mediawiki-config@master] Start writing to rev_comment_id on group0 wikis

https://gerrit.wikimedia.org/r/879148

gerritbot added a comment.Wed, Jan 11, 10:41 PM

Change 879148 merged by jenkins-bot:

[operations/mediawiki-config@master] Start writing to rev_comment_id on group0 wikis

https://gerrit.wikimedia.org/r/879148

Stashbot added a comment.Wed, Jan 11, 10:42 PM

Mentioned in SAL (#wikimedia-operations) [2023-01-11T22:42:12Z] <zabe@deploy1002> Started scap: Backport for [[gerrit:879055|Start reading from cuc_actor on group0 and group1 wikis (T233004)]], [[gerrit:879148|Start writing to rev_comment_id on group0 wikis (T299954)]], [[gerrit:879057|Stop writing to cul_user and cul_user_text on testwiki (T233004)]]

Stashbot added a comment.Wed, Jan 11, 10:43 PM

Mentioned in SAL (#wikimedia-operations) [2023-01-11T22:43:58Z] <zabe@deploy1002> zabe and zabe: Backport for [[gerrit:879055|Start reading from cuc_actor on group0 and group1 wikis (T233004)]], [[gerrit:879148|Start writing to rev_comment_id on group0 wikis (T299954)]], [[gerrit:879057|Stop writing to cul_user and cul_user_text on testwiki (T233004)]] synced to the testservers: mwdebug1002.eqiad.wmnet, mwdebug2002.codfw.wmnet, mwdebug1001.eqiad.wmnet, mwdebug2001.codfw.wmnet

Stashbot added a comment.Wed, Jan 11, 10:51 PM

Mentioned in SAL (#wikimedia-operations) [2023-01-11T22:51:40Z] <zabe@deploy1002> Finished scap: Backport for [[gerrit:879055|Start reading from cuc_actor on group0 and group1 wikis (T233004)]], [[gerrit:879148|Start writing to rev_comment_id on group0 wikis (T299954)]], [[gerrit:879057|Stop writing to cul_user and cul_user_text on testwiki (T233004)]] (duration: 09m 28s)

gerritbot added a comment.Thu, Jan 12, 4:18 PM

Change 879591 had a related patch set uploaded (by Zabe; author: Zabe):

[operations/mediawiki-config@master] Start writing to rev_comment_id on group1 wikis

https://gerrit.wikimedia.org/r/879591

gerritbot added a comment.Thu, Jan 12, 4:21 PM

Change 879591 merged by jenkins-bot:

[operations/mediawiki-config@master] Start writing to rev_comment_id on group1 wikis

https://gerrit.wikimedia.org/r/879591

Stashbot added a comment.Thu, Jan 12, 4:21 PM

Mentioned in SAL (#wikimedia-operations) [2023-01-12T16:21:46Z] <zabe@deploy1002> Started scap: Backport for [[gerrit:879590|Stop writing to cul_user and cul_user_text on a few wikis (T233004)]], [[gerrit:879591|Start writing to rev_comment_id on group1 wikis (T299954)]]

Stashbot added a comment.Thu, Jan 12, 4:23 PM

Mentioned in SAL (#wikimedia-operations) [2023-01-12T16:23:30Z] <zabe@deploy1002> zabe and zabe: Backport for [[gerrit:879590|Stop writing to cul_user and cul_user_text on a few wikis (T233004)]], [[gerrit:879591|Start writing to rev_comment_id on group1 wikis (T299954)]] synced to the testservers: mwdebug1002.eqiad.wmnet, mwdebug2002.codfw.wmnet, mwdebug2001.codfw.wmnet, mwdebug1001.eqiad.wmnet

Stashbot added a comment.Thu, Jan 12, 4:31 PM

Mentioned in SAL (#wikimedia-operations) [2023-01-12T16:31:35Z] <zabe@deploy1002> Finished scap: Backport for [[gerrit:879590|Stop writing to cul_user and cul_user_text on a few wikis (T233004)]], [[gerrit:879591|Start writing to rev_comment_id on group1 wikis (T299954)]] (duration: 09m 49s)

gerritbot added a comment.Tue, Jan 17, 11:13 AM

Change 880902 had a related patch set uploaded (by Zabe; author: Zabe):

[operations/mediawiki-config@master] Start writing to rev_comment_id everywhere

https://gerrit.wikimedia.org/r/880902

gerritbot added a comment.Tue, Jan 17, 10:55 PM

Change 880902 merged by jenkins-bot:

[operations/mediawiki-config@master] Start writing to rev_comment_id everywhere

https://gerrit.wikimedia.org/r/880902

Stashbot added a comment.Tue, Jan 17, 10:55 PM

Mentioned in SAL (#wikimedia-operations) [2023-01-17T22:55:54Z] <zabe@deploy1002> Started scap: Backport for [[gerrit:880903|Stop writing to cul_user and cul_user_text everywhere (T233004)]], [[gerrit:880902|Start writing to rev_comment_id everywhere (T299954)]]

Stashbot added a comment.Tue, Jan 17, 10:57 PM

Mentioned in SAL (#wikimedia-operations) [2023-01-17T22:57:39Z] <zabe@deploy1002> zabe and zabe: Backport for [[gerrit:880903|Stop writing to cul_user and cul_user_text everywhere (T233004)]], [[gerrit:880902|Start writing to rev_comment_id everywhere (T299954)]] synced to the testservers: mwdebug2002.codfw.wmnet, mwdebug2001.codfw.wmnet, mwdebug1002.eqiad.wmnet, mwdebug1001.eqiad.wmnet

Stashbot added a comment.Tue, Jan 17, 11:06 PM

Mentioned in SAL (#wikimedia-operations) [2023-01-17T23:06:24Z] <zabe@deploy1002> Finished scap: Backport for [[gerrit:880903|Stop writing to cul_user and cul_user_text everywhere (T233004)]], [[gerrit:880902|Start writing to rev_comment_id everywhere (T299954)]] (duration: 10m 29s)

gerritbot added a comment.Thu, Jan 19, 4:16 AM

Change 873906 merged by jenkins-bot:

[mediawiki/core@master] Add migrateRevisionCommentTemp maintenance script

https://gerrit.wikimedia.org/r/873906

ReleaseTaggerBot edited projects, added MW-1.40-notes (1.40.0-wmf.20; 2023-01-23); removed MW-1.40-notes (1.40.0-wmf.18; 2023-01-09).Thu, Jan 19, 5:00 AM
Stashbot added a comment.Thu, Jan 19, 7:10 PM

Mentioned in SAL (#wikimedia-releng) [2023-01-19T19:10:48Z] <zabe> zabe@deployment-mwmaint02:~$ foreachwiki migrateRevisionCommentTemp.php # T299954

Zabe added a comment.Thu, Jan 19, 7:23 PM
In T299954#8541625, @Stashbot wrote:

Mentioned in SAL (#wikimedia-releng) [2023-01-19T19:10:48Z] <zabe> zabe@deployment-mwmaint02:~$ foreachwiki migrateRevisionCommentTemp.php # T299954

Since it might not be obvious for everyone: that is beta-cluster.

gerritbot added a comment.Fri, Jan 20, 1:19 AM

Change 881729 had a related patch set uploaded (by Zabe; author: Zabe):

[operations/mediawiki-config@master] beta: start reading from rev_comment_id

https://gerrit.wikimedia.org/r/881729

gerritbot added a comment.Fri, Jan 20, 1:20 AM

Change 881729 merged by jenkins-bot:

[operations/mediawiki-config@master] beta: start reading from rev_comment_id

https://gerrit.wikimedia.org/r/881729

gerritbot added a comment.Fri, Jan 20, 10:23 AM

Change 881834 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/core@master] migrateRevisionCommentTemp: Improve select query

https://gerrit.wikimedia.org/r/881834

gerritbot added a comment.Sat, Jan 21, 4:58 PM

Change 881834 merged by jenkins-bot:

[mediawiki/core@master] migrateRevisionCommentTemp: Improve select query

https://gerrit.wikimedia.org/r/881834

Maintenance_bot removed a project: Patch-For-Review.Sat, Jan 21, 5:30 PM
gerritbot added a comment.Tue, Jan 24, 9:57 PM

Change 883281 had a related patch set uploaded (by Zabe; author: Zabe):

[operations/mediawiki-config@master] Start reading from rev_comment_id on testcommonswiki

https://gerrit.wikimedia.org/r/883281

gerritbot added a project: Patch-For-Review.Tue, Jan 24, 9:57 PM
gerritbot added a comment.Tue, Jan 24, 11:02 PM

Change 883281 merged by jenkins-bot:

[operations/mediawiki-config@master] Start reading from rev_comment_id on testcommonswiki

https://gerrit.wikimedia.org/r/883281

Stashbot added a comment.Tue, Jan 24, 11:02 PM

Mentioned in SAL (#wikimedia-operations) [2023-01-24T23:02:27Z] <zabe@deploy1002> Started scap: Backport for [[gerrit:883281|Start reading from rev_comment_id on testcommonswiki (T299954)]]

Stashbot added a comment.Tue, Jan 24, 11:04 PM

Mentioned in SAL (#wikimedia-operations) [2023-01-24T23:04:12Z] <zabe@deploy1002> zabe: Backport for [[gerrit:883281|Start reading from rev_comment_id on testcommonswiki (T299954)]] synced to the testservers: mwdebug2001.codfw.wmnet, mwdebug1002.eqiad.wmnet, mwdebug1001.eqiad.wmnet, mwdebug2002.codfw.wmnet

Stashbot added a comment.Tue, Jan 24, 11:10 PM

Mentioned in SAL (#wikimedia-operations) [2023-01-24T23:10:29Z] <zabe@deploy1002> Finished scap: Backport for [[gerrit:883281|Start reading from rev_comment_id on testcommonswiki (T299954)]] (duration: 08m 02s)

Maintenance_bot removed a project: Patch-For-Review.Tue, Jan 24, 11:30 PM
gerritbot added a comment.Fri, Feb 3, 9:55 PM

Change 886429 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/core@master] respect migration stage when deleting from revision_comment_temp

https://gerrit.wikimedia.org/r/886429

gerritbot added a project: Patch-For-Review.Fri, Feb 3, 9:55 PM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL