Maniphest T300135

Create a LoggerFactory service for IPInfo
Closed, ResolvedPublic2 Estimated Story Points
Actions

Assigned To

Authored By

	Tchanders
	Jan 26 2022, 1:06 PM

Tags

Referenced Files

None

Subscribers

Description

This will help with testing T294658: Create a log entry when the RevisionHandler is called and T294657: Create a log entry when the LogHandler is called.

For similar work where a ReaderFactory was introduced, see this patch: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/IPInfo/+/731936

Details

	Subject	Repo	Branch	Lines +/-
	Introduce LoggerFactory service for access logging	mediawiki/extensions/IPInfo	master	+47 -14

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		Tchanders	T295017 Display ipinfo log lines on Special:Log
		Resolved		Tchanders	T300773 Log whether a user views limited or full IP information
		Resolved		STran	T300136 Add tests for access logging
		Resolved		Tchanders	T300897 Log debouncing fails for users with different user IDs and actor IDs
		Resolved		Tchanders	T300135 Create a LoggerFactory service for IPInfo

Event Timeline

Tchanders created this task.Jan 26 2022, 1:06 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 26 2022, 1:06 PM

Tchanders mentioned this in T300136: Add tests for access logging.Jan 26 2022, 1:13 PM

Tchanders added a parent task: T300136: Add tests for access logging.

Tchanders moved this task from Untriaged to Pre-estimation/Triage on the Anti-Harassment board.Jan 31 2022, 2:05 PM

Tchanders set the point value for this task to 2.Jan 31 2022, 3:21 PM

Tchanders moved this task from Pre-estimation/Triage to Cards ready for development on the Anti-Harassment board.

Tchanders moved this task from Cards ready for development to The Letter Song on the Anti-Harassment board.Feb 3 2022, 6:40 PM

Tchanders edited projects, added Anti-Harassment (The Letter Song); removed Anti-Harassment.

Tchanders claimed this task.Feb 4 2022, 3:44 AM

Tchanders moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to In Progress 💪 on the Anti-Harassment (The Letter Song) board.

Change 759743 had a related patch set uploaded (by Tchanders; author: Tchanders):

[mediawiki/extensions/IPInfo@master] Introduce LoggerFactory class

https://gerrit.wikimedia.org/r/759743

gerritbot added a project: Patch-For-Review.Feb 4 2022, 5:13 PM

Tchanders moved this task from In Progress 💪 to Code Review 🔍 on the Anti-Harassment (The Letter Song) board.Feb 4 2022, 5:13 PM

Picked this up because it has become a prerequisite for some of our in-progress tasks (see parent tasks).

Change 759743 merged by jenkins-bot:

[mediawiki/extensions/IPInfo@master] Introduce LoggerFactory service for access logging

https://gerrit.wikimedia.org/r/759743

Maintenance_bot removed a project: Patch-For-Review.Feb 15 2022, 10:10 AM

Bypassing QA because this will be tested via the parent tasks

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.23; 2022-02-21).Feb 15 2022, 3:00 PM

Niharika closed this task as Resolved.Feb 17 2022, 1:34 AM

Niharika moved this task from Backlog to Closed on the IP Info board.Aug 8 2022, 7:58 PM