The "Review changes" and "Show preview" buttons should not show once you click on them. This regressed around 0.42.0 which leads me to suspect this commit: https://gerrit.wikimedia.org/r/c/oojs/ui/+/686439
Expected:
Actual:
Description
Description
Details
Details
Related Objects
Related Objects
- Mentioned Here
- T174497: ActionSet does not work as documented
Event Timeline
Comment Actions
Reverting that patch locally fixes the issue, so it is indeed the cause of the regression. Thanks to @Jdforrester-WMF for spotting this.
Comment Actions
Change 771913 had a related patch set uploaded (by Esanders; author: Esanders):
[oojs/ui@master] Revert "Fix for OO.ui.ActionSet.prototype.get() not returning invisible widgets"
Comment Actions
Change 772345 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/VisualEditor@master] Fix review button shown when review panel is already active
Comment Actions
Change 771913 abandoned by Esanders:
[oojs/ui@master] Revert "Fix for OO.ui.ActionSet.prototype.get() not returning invisible widgets"
Reason:
Fixed downstream.
Comment Actions
Change 772345 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Fix review button shown when review panel is already active
Comment Actions
@Esanders One last thing before I move this task. See https://photos.app.goo.gl/13RoWw1MtjoBVG6P8, pay attention to 00:20 - 00:27 - is the "Show preview" button expected to be visible in the preview page? That has been my experience with it but I'd like to confirm that it's how it should be.
Cc: @matmarex
Comment Actions
Yes - that is correct behaviour in the old editor, as you can change the wikitext above, and then press "show preview" again to update the preview.