Maniphest T302051

MWException: Non-string key given
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Assigned To

Authored By

	Ammarpad
	Feb 18 2022, 6:21 AM

Description

Error

mwversion: ``
reqId: Yg89IFiN-w5FI1lkvXgH5QAAAJM

normalized_message

exception.trace

from /srv/mediawiki/php-master/includes/cache/MessageCache.php(937)
#0 /srv/mediawiki/php-master/includes/language/Message.php(1479): MessageCache->get(NULL, boolean, LanguageEn)
#1 /srv/mediawiki/php-master/includes/language/Message.php(963): Message->fetchMessage()
#2 /srv/mediawiki/php-master/includes/language/Message.php(1059): Message->format(string)
#3 /srv/mediawiki/php-master/includes/skins/SkinTemplate.php(1138): Message->text()
#4 /srv/mediawiki/php-master/includes/skins/SkinTemplate.php(1381): SkinTemplate->getSkinNavOverrideableLabel(string)
#5 /srv/mediawiki/php-master/includes/skins/SkinTemplate.php(781): SkinTemplate->buildContentNavigationUrlsInternal()
#6 /srv/mediawiki/php-master/includes/skins/SkinTemplate.php(201): SkinTemplate->getPortletsTemplateData()
#7 /srv/mediawiki/php-master/includes/skins/SkinMustache.php(81): SkinTemplate->getTemplateData()
#8 /srv/mediawiki/php-master/skins/Vector/includes/SkinVector.php(589): SkinMustache->getTemplateData()
#9 /srv/mediawiki/php-master/includes/skins/SkinMustache.php(58): SkinVector->getTemplateData()
#10 /srv/mediawiki/php-master/skins/Vector/includes/SkinVector.php(465): SkinMustache->generateHTML()
#11 /srv/mediawiki/php-master/includes/skins/SkinTemplate.php(149): SkinVector->generateHTML()
#12 /srv/mediawiki/php-master/includes/OutputPage.php(2723): SkinTemplate->outputPage()
#13 /srv/mediawiki/php-master/includes/MediaWiki.php(923): OutputPage->output(boolean)
#14 /srv/mediawiki/php-master/includes/MediaWiki.php(936): MediaWiki::{closure}()
#15 /srv/mediawiki/php-master/includes/MediaWiki.php(563): MediaWiki->main()
#16 /srv/mediawiki/php-master/index.php(53): MediaWiki->run()
#17 /srv/mediawiki/php-master/index.php(46): wfIndexMain()
#18 /srv/mediawiki/w/index.php(3): require(string)
#19 {main}

Impact

Notes

Details

Request URL: https://commons.wikimedia.beta.wmflabs.org/wiki/User:AJ-test

	Subject	Repo	Branch	Lines +/-
	skins: Do not send null value to wfMessageFallback	mediawiki/core	master	+11 -2

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Resolved		ovasileva	T273473 [Epic] Improve the table of contents
Resolved		Jdrewniak	T291098 [TECHNICAL GOAL] Split Vector into 2 separate skins with 2 different keys
Open	BUG REPORT	None	T300183 Reconsider skin-specific menu label item behaviour
Resolved	BUG REPORT	None	T302672 Mirage edit button messages are wrong
Resolved		Jdlrobson	T301203 Update skin-specific menu labels to be more predictable, intuitive with better default values
Resolved	Release	dduvall	T300199 1.38.0-wmf.23 deployment blockers
Resolved	PRODUCTION ERROR	Jdlrobson	T302051 MWException: Non-string key given

Event Timeline

Ammarpad created this task.Feb 18 2022, 6:21 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 18 2022, 6:21 AM

Ammarpad edited projects, added Beta-Cluster-reproducible; removed Wikimedia-production-error.Feb 18 2022, 6:23 AM

Ammarpad set Request URL to https://commons.wikimedia.beta.wmflabs.org/wiki/User:AJ-test.Feb 18 2022, 6:32 AM

Ammarpad updated the task description. (Show Details)

Narrowed down to this https://gerrit.wikimedia.org/r/c/mediawiki/core/+/760670

Zabe added a parent task: T300199: 1.38.0-wmf.23 deployment blockers.Feb 18 2022, 11:50 AM

Zabe added a project: MediaWiki-Core-Skin-Architecture.Feb 18 2022, 4:29 PM

Zabe subscribed.

gerritbot added a project: Patch-For-Review.Feb 18 2022, 4:55 PM

Jdlrobson assigned this task to Jdrewniak.Feb 18 2022, 4:55 PM

Jdlrobson removed Jdrewniak as the assignee of this task.

Jdlrobson triaged this task as Unbreak Now! priority.

Jdlrobson edited projects, added Web-Team-Backlog (Kanbanana-FY-2021-22); removed Patch-For-Review.

Jdlrobson moved this task from Needs Analysis to Code Review on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.

Jdlrobson added a parent task: T301203: Update skin-specific menu labels to be more predictable, intuitive with better default values.

Jdlrobson added a subscriber: Jdrewniak.

Zabe mentioned this in T302089: gerritbot randomly added #patch-for-review to a task.Feb 18 2022, 4:56 PM

I expected more @gerritbot.

https://gerrit.wikimedia.org/r/c/mediawiki/core/+/763784

Jdlrobson mentioned this in T302082: "Read" menu item does not appear correctly on articles.Feb 18 2022, 9:07 PM

Change 763784 abandoned by Jdlrobson:

[mediawiki/core@master] skins: Do not send null value to wfMessageFallback

Reason:

Since it's Friday I'm reverting the original patch and I've folded these changes into https://gerrit.wikimedia.org/r/c/mediawiki/core/+/763839 to give us more time to test.

https://gerrit.wikimedia.org/r/763784

Fixed by revert https://gerrit.wikimedia.org/r/c/mediawiki/core/+/763838

MWException: Non-string key givenClosed, ResolvedPublicPRODUCTION ERRORActions