Page MenuHomePhabricator

PHP Notice: Undefined index: mobileformat
Closed, ResolvedPublicPRODUCTION ERROR

Description

Error
normalized_message
[{reqId}] {exception_url}   PHP Notice: Undefined index: mobileformat
exception.trace
from /srv/mediawiki/php-1.38.0-wmf.23/extensions/VisualEditor/includes/ApiVisualEditorEdit.php(136)
#0 /srv/mediawiki/php-1.38.0-wmf.23/extensions/VisualEditor/includes/ApiVisualEditorEdit.php(136): MWExceptionHandler::handleError(integer, string, string, integer, array)
#1 /srv/mediawiki/php-1.38.0-wmf.23/extensions/VisualEditor/includes/ApiVisualEditorEdit.php(449): ApiVisualEditorEdit->parseWikitext(integer, array)
#2 /srv/mediawiki/php-1.38.0-wmf.23/includes/api/ApiMain.php(1891): ApiVisualEditorEdit->execute()
#3 /srv/mediawiki/php-1.38.0-wmf.23/includes/api/ApiMain.php(869): ApiMain->executeAction()
#4 /srv/mediawiki/php-1.38.0-wmf.23/includes/api/ApiMain.php(840): ApiMain->executeActionWithErrorHandling()
#5 /srv/mediawiki/php-1.38.0-wmf.23/api.php(90): ApiMain->execute()
#6 /srv/mediawiki/php-1.38.0-wmf.23/api.php(45): wfApiMain()
#7 /srv/mediawiki/w/api.php(3): require(string)
#8 {main}
Impact

Low impact. Half a dozen or so new errors upon group0 promotion.

Notes

A git blame tells me this was possibly introduced in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/VisualEditor/+/763769

Related Objects

StatusSubtypeAssignedTask
ResolvedReleasedduvall
ResolvedPRODUCTION ERRORppelberg

Event Timeline

dduvall triaged this task as Unbreak Now! priority.Feb 22 2022, 8:29 PM
dduvall created this task.

Will look in a bit, should be a fairly simple fix.

Change 764898 had a related patch set uploaded (by DLynch; author: DLynch):

[mediawiki/extensions/VisualEditor@master] Avoid undefined index for mobileformat

https://gerrit.wikimedia.org/r/764898

Change 764899 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/DiscussionTools@master] Avoid undefined index for mobileformat

https://gerrit.wikimedia.org/r/764899

Change 764899 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] Avoid undefined index for mobileformat

https://gerrit.wikimedia.org/r/764899

Change 764898 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Avoid undefined index for mobileformat

https://gerrit.wikimedia.org/r/764898

Change 764833 had a related patch set uploaded (by DLynch; author: DLynch):

[mediawiki/extensions/VisualEditor@wmf/1.38.0-wmf.23] Avoid undefined index for mobileformat

https://gerrit.wikimedia.org/r/764833

Change 764834 had a related patch set uploaded (by DLynch; author: Esanders):

[mediawiki/extensions/DiscussionTools@wmf/1.38.0-wmf.23] Avoid undefined index for mobileformat

https://gerrit.wikimedia.org/r/764834

Change 764833 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@wmf/1.38.0-wmf.23] Avoid undefined index for mobileformat

https://gerrit.wikimedia.org/r/764833

Change 764834 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@wmf/1.38.0-wmf.23] Avoid undefined index for mobileformat

https://gerrit.wikimedia.org/r/764834

Mentioned in SAL (#wikimedia-operations) [2022-02-22T22:52:21Z] <dduvall@deploy1002> Synchronized php-1.38.0-wmf.23/extensions/DiscussionTools/includes/ApiDiscussionToolsEdit.php: Backport: [[gerrit:764834|DiscussionTools: Avoid undefined index for mobileformat ([T302344])]] (duration: 00m 51s)

Mentioned in SAL (#wikimedia-operations) [2022-02-22T22:53:49Z] <dduvall@deploy1002> Synchronized php-1.38.0-wmf.23/extensions/VisualEditor/includes/ApiVisualEditorEdit.php: Backport: [[gerrit:764833|VisualEditor: Avoid undefined index for mobileformat ([T302344])]] (duration: 00m 49s)

ppelberg claimed this task.
ppelberg added a project: Skipped QA.