Page MenuHomePhabricator
Create Task
Maniphest T302789

Icons are missing when communicating publishing issues
Closed, ResolvedPublic
Actions

Assigned To
Wangombe
Authored By
Pginer-WMF
Mar 1 2022, 11:22 AM
Tags
Referenced Files
F37161519: Screenshot 2023-08-03 at 12.03.13 AM.png
Aug 3 2023, 5:14 AM
F37161515: Screenshot 2023-08-03 at 12.10.07 AM.png
Aug 3 2023, 5:14 AM
F37161516: Screenshot 2023-08-03 at 12.09.00 AM.png
Aug 3 2023, 5:14 AM
F37121777: Screenshot from 2023-06-28 09-46-03.png
Jun 28 2023, 6:49 AM
F37121778: Screenshot from 2023-06-28 09-45-45.png
Jun 28 2023, 6:49 AM
F37121779: Screenshot from 2023-06-28 09-45-19.png
Jun 28 2023, 6:49 AM
F34971030: test.m.wikipedia.org_w_index.php_title=Special_ContentTranslation&from=en&to=bn&sx=true(iPhone SE).png
Mar 1 2022, 11:22 AM
F31819232: Publish - Issues.png
Mar 1 2022, 11:22 AM
View All 9 Files
Subscribers
Aklapper
EChukwukere-WMF
ngkountas
Pginer-WMF
RodneyAraujo
• santhosh
Theory42
View All 9 Subscribers

Description

Errors and warnings can be shown in the Preview and publish step (T260134). These are shown in a message box and the spec indicates that an icon ('alert' for warnings, and 'block' for errors) should be used:

Publish - Issues.png (768×1 px, 179 KB)

However, the initial implementation is not including the icons:

ErrorWarning
Screen Shot 2022-02-15 at 5.10.35 PM.png (695×400 px, 63 KB)
test.m.wikipedia.org_w_index.php_title=Special_ContentTranslation&from=en&to=bn&sx=true(iPhone SE).png (667×375 px, 112 KB)

Details

SubjectRepoBranchLines +/-
CX3 Build 0.2.0+20230626mediawiki/extensions/ContentTranslationmaster+3 K -3 K
SX: Remove .col class from icon in publisher review infomediawiki/extensions/ContentTranslationmaster+5 -9
Customize query in gerrit

Related Objects
Search...

Event Timeline

Pginer-WMF triaged this task as Medium priority.Mar 1 2022, 11:22 AM
Pginer-WMF created this task.
Pginer-WMF moved this task from Backlog to Core workflow on the SectionTranslation board.
Pginer-WMF updated the task description. (Show Details)Mar 1 2022, 11:24 AM
Pginer-WMF mentioned this in T302792: Adjust navigation controls for multiple publishing issues.Mar 1 2022, 11:45 AM
Pginer-WMF mentioned this in T260134: Preview and publish: Communicate publishing issues.
ngkountas added a project: Language-Team (Language-2023-April-June).Jun 15 2023, 7:13 AM
Wangombe changed the task status from Open to In Progress.Jun 19 2023, 6:22 AM
Wangombe claimed this task.
Wangombe moved this task from Quarter Backlog to In Progress on the Language-Team (Language-2023-April-June) board.
gerritbot added a comment.Jun 19 2023, 7:00 AM

Change 931058 had a related patch set uploaded (by Wangombe; author: Wangombe):

[mediawiki/extensions/ContentTranslation@master] SX: Remove .col class from icon in publisher review info

https://gerrit.wikimedia.org/r/931058

gerritbot added a project: Patch-For-Review.Jun 19 2023, 7:00 AM
gerritbot added a comment.Jun 19 2023, 5:33 PM

Change 931058 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] SX: Remove .col class from icon in publisher review info

https://gerrit.wikimedia.org/r/931058

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.15; 2023-06-27).Jun 19 2023, 6:00 PM
Maintenance_bot removed a project: Patch-For-Review.Jun 19 2023, 6:10 PM
Wangombe moved this task from In Progress to In Review on the Language-Team (Language-2023-April-June) board.Jun 20 2023, 5:18 AM
ngkountas moved this task from In Review to Check after deployment on the Language-Team (Language-2023-April-June) board.Jun 22 2023, 9:15 AM
gerritbot added a comment.Jun 26 2023, 5:41 AM

Change 932684 had a related patch set uploaded (by Santhosh; author: Santhosh):

[mediawiki/extensions/ContentTranslation@master] CX3 Build 0.2.0+20230626

https://gerrit.wikimedia.org/r/932684

gerritbot added a project: Patch-For-Review.Jun 26 2023, 5:41 AM
gerritbot added a comment.Jun 26 2023, 4:08 PM

Change 932684 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] CX3 Build 0.2.0+20230626

https://gerrit.wikimedia.org/r/932684

Maintenance_bot removed a project: Patch-For-Review.Jun 26 2023, 4:13 PM
Wangombe closed this task as Resolved.Jun 28 2023, 6:49 AM
Wangombe moved this task from Check after deployment to Done on the Language-Team (Language-2023-April-June) board.

As seen on test wiki

Screenshot from 2023-06-28 09-45-19.png (985×556 px, 84 KB)
Screenshot from 2023-06-28 09-45-45.png (985×446 px, 72 KB)
Screenshot from 2023-06-28 09-46-03.png (985×446 px, 81 KB)
ngkountas reopened this task as Open.Jun 28 2023, 8:19 AM
ngkountas moved this task from Done to Needs QA on the Language-Team (Language-2023-April-June) board.
Pginer-WMF edited projects, added Language-Team (Language-2023-July-September); removed Language-Team (Language-2023-April-June).Jun 30 2023, 11:43 AM
Pginer-WMF moved this task from Quarter Backlog to Needs QA on the Language-Team (Language-2023-July-September) board.
EChukwukere-WMF subscribed.Aug 3 2023, 5:14 AM

Test status : QA PASS

Icons do now exist for the scenarios highlighted during the publishing stage

Screenshot 2023-08-03 at 12.09.00 AM.png (527×1 px, 73 KB)

Screenshot 2023-08-03 at 12.10.07 AM.png (557×1 px, 58 KB)

Screenshot 2023-08-03 at 12.03.13 AM.png (812×623 px, 199 KB)

EChukwukere-WMF moved this task from Needs QA to Done on the Language-Team (Language-2023-July-September) board.Aug 3 2023, 5:14 AM
Pginer-WMF closed this task as Resolved.Aug 4 2023, 1:29 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL