| Pginer-WMF | |
| Aug 11 2020, 1:16 PM |
| F34962461: Screen Shot 2022-02-15 at 5.10.35 PM.png | |
| Feb 23 2022, 1:57 AM |
| F34956728: Publish_-_Issues.png | |
| Feb 18 2022, 11:08 AM |
| F34953023: Screen Shot 2022-02-15 at 5.15.44 PM.png | |
| Feb 16 2022, 1:59 AM |
| F34953020: Screen Shot 2022-02-15 at 5.30.58 PM.png | |
| Feb 16 2022, 1:59 AM |
| F31819232: Publish - Issues.png | |
| Aug 11 2020, 1:16 PM |
As part of the "Preview and publish" step (T252542) of the mobile editor for Section Translation, users can publish their translation contents after previewing them.
At that point we may want to communicate different potential issues to the user based on the content they are trying to publish or the result of a previous publish attempt.
More details in the parent task: T252542: Section Translation Editor: Preview and publish
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T243495 [Epic] Support for Section Translation | |||
| Open | None | T252542 Section Translation Editor: Preview and publish | |||
| Resolved | ngkountas | T260134 Preview and publish: Communicate publishing issues |
Change 638158 had a related patch set uploaded (by Nik Gkountas; owner: Nik Gkountas):
[mediawiki/extensions/ContentTranslation@master] SXPublisher: Add review info component
Change 638158 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@master] SXPublisher: Add review info component
Change 664295 had a related patch set uploaded (by Nik Gkountas; owner: Nik Gkountas):
[mediawiki/extensions/ContentTranslation@master] Section Translation: Check for MT abuse before publishing
@Pginer-WMF, in the current implementation these warning or error is shown when the user click on publish button. Is that the expected behaviour? Should we display the error or warning along with the publish preview? That is, when user press "Done" button in previous screen?
Yes. The warnings and errors that we can anticipate is better to show them at the preview step. Especially for warnings that do not block publishing, this will give a chance for the content to be improved before it goes live.
@Pginer-WMF I understand that since the information for both MT abuse warnings and errors is available inside Preview Translation screen, we want to display MT warnings/errors immediately to the user (inside the review info section). Warnings can be suppressed (by clicking the check icon) so that user can be proceed with publishing but MT errors cannot be suppressed and will block publishing (unless user modifies translation to fix MT issues). Am I correct? Should the "Publish" button be disabled until user suppress MT warnings or fix MT issues?
Change 664295 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@master] SX publishing: Add MT validation before publishing
Here we surface two kids of issues:
For MT we were following this: " show warnings when MT > 85% and block publishing when MT > 95%". Thus:
The numbers (and ranges) should be consistent with the approach we used to represent MT in the cards for already translated sentences (T260128). I'd recommend reusing variables to make sure that future adjustments in the percentages keep the consistency.
If there are multiple issues, errors are shown first, since they explain why publishing is not possible.
A side note about disabling the publish button:
Disabling the button for errors makes sense, but we need to be very careful with the code to make sure there are no false positives. We have this kind of problems when trying to anticipate abuse filters in CX (some abuse filters such as "too short article" were triggered when applied to a paragraph), but that seems unlikely to happen for section translation since the preview represents the complete edit. But please, surface any possible false positive scenario you can think of.
Change 731329 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):
[mediawiki/extensions/ContentTranslation@master] SXPublisher: Disable publish button when publish result has errors
Change 731329 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@master] SXPublisher: Disable publish button when publish result has errors
Change 731330 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):
[mediawiki/extensions/ContentTranslation@master] SX publishing: Reimplement communication of publishing issues
Change 734939 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):
[mediawiki/extensions/ContentTranslation@master] SX Publish Translation: Validate for MT when publish step is loaded
Change 734940 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):
[mediawiki/extensions/ContentTranslation@master] SX MT validation: Reset publish result on successful MT validation
Change 734941 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):
[mediawiki/extensions/ContentTranslation@master] SX Publish: Remove MT validation from publishTranslation action
Change 734943 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):
[mediawiki/extensions/ContentTranslation@master] SX MT warnings: Remove suppressing functionality
Change 734967 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):
[mediawiki/extensions/ContentTranslation@master] SX: Add navigation for publishing feedback errors and warnings
Change 734939 merged by Santhosh:
[mediawiki/extensions/ContentTranslation@master] SX Publish Translation: Validate for MT when publish step is loaded
Change 734940 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@master] SX MT validation: Reset publish result on successful MT validation
Change 734941 merged by Nik Gkountas:
[mediawiki/extensions/ContentTranslation@master] SX Publish: Remove MT validation from publishTranslation action
Change 734943 merged by Nik Gkountas:
[mediawiki/extensions/ContentTranslation@master] SX MT warnings: Remove suppressing functionality
Change 735952 had a related patch set uploaded (by Santhosh; author: Santhosh):
[mediawiki/extensions/ContentTranslation@master] CX3 Build 0.1.0+20211101
Change 735952 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@master] CX3 Build 0.1.0+20211101
Change 731330 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@master] SX publish: Remove PublishResult model and use PublishFeedbackMessage
Change 734967 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@master] SX: Add navigation for publishing feedback errors and warnings
Change 737354 had a related patch set uploaded (by Santhosh; author: Santhosh):
[mediawiki/extensions/ContentTranslation@master] CX3 Build 0.1.0+20211108
Change 737354 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@master] CX3 Build 0.1.0+20211108
I checked the section translation following the above guidelines on testwiki wmf.22 and on sx.wmflabs(tested on an Android device and a browser emulator) - seems to be working as expected (saying this with some caution- more testing/monitoring is needed).
Questions:
| (1) the icon is missing) (2) the counter for errors is missing (3) the arrows to navigate are placed closer than in the mockup |  |
[60d53942a7bf3cdcf1bb065d] Caught exception of type Error
Error while translating segment SyntaxError: JSON.parse: unexpected character at line 1 column 1 of the JSON data
if (!e['mediawiki/isValidProviderForTranslation'](i, o, a)) return Promise.resolve();
try {
const e = await t('application/getCXServerToken', {
}, {
root: !0
});
return await q.fetchSegmentTranslation(i, o, a, s, e)
} catch (c) {
return mw.log.error('Error while translating segment', c),
s
}Questions:
- there are minor UI differences from the mockup in the specs
(1) the icon is missing) (2) the counter for errors is missing (3) the arrows to navigate are placed closer than in the mockup
- is it expected do not able to publish on sx.wmflabs.org. I get an error
I'm not sure if it is related to T294642#7677751 or a new issue. @ngkountas may know better.
- why the wording of the warning message is the same ("You can still publish..." even when the MT percentage is 100% and the publish button is disabled?
When "the MT percentage is 100% and the publish button is disabled" the message should be represented as an error instead of a warning and look more like this:
When "the MT percentage is 100% and the publish button is disabled" the message should be represented as an error instead of a warning and look more like this:
Thanks, @Pginer-WMF. I just realized that I did not provide the screenshot for this case - the message is an error (the background is read) but the wording is as in a warning message:
- is it expected do not able to publish on sx.wmflabs.org. I get an error
I can confirm that publishing is currently blocked on sx.wmflabs, but it's not related to neither the error posted above nor the sandbox publishing. Since this task refers to something totally different I believe we can continue closing this one, and creating new tasks to track: 1) the UI glitches that Elena noticed in this task and 2) the publishing issue in sx.wmflabs.org.