Page MenuHomePhabricator

Preview and publish: Communicate publishing issues
Open, MediumPublic

Description

As part of the "Preview and publish" step (T252542) of the mobile editor for Section Translation, users can publish their translation contents after previewing them.

At that point we may want to communicate different potential issues to the user based on the content they are trying to publish or the result of a previous publish attempt.

More details in the parent task: T252542: Section Translation Editor: Preview and publish

Event Timeline

Pginer-WMF triaged this task as Medium priority.Aug 11 2020, 1:16 PM
Pginer-WMF created this task.
Pginer-WMF moved this task from Backlog to Mobile editor on the SectionTranslation board.

Change 638158 had a related patch set uploaded (by Nik Gkountas; owner: Nik Gkountas):
[mediawiki/extensions/ContentTranslation@master] SXPublisher: Add review info component

https://gerrit.wikimedia.org/r/638158

Change 638158 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@master] SXPublisher: Add review info component

https://gerrit.wikimedia.org/r/638158

ngkountas added a subscriber: ngkountas.

Change 664295 had a related patch set uploaded (by Nik Gkountas; owner: Nik Gkountas):
[mediawiki/extensions/ContentTranslation@master] Section Translation: Check for MT abuse before publishing

https://gerrit.wikimedia.org/r/664295

@Pginer-WMF, in the current implementation these warning or error is shown when the user click on publish button. Is that the expected behaviour? Should we display the error or warning along with the publish preview? That is, when user press "Done" button in previous screen?

@Pginer-WMF, in the current implementation these warning or error is shown when the user click on publish button. Is that the expected behaviour? Should we display the error or warning along with the publish preview? That is, when user press "Done" button in previous screen?

Yes. The warnings and errors that we can anticipate is better to show them at the preview step. Especially for warnings that do not block publishing, this will give a chance for the content to be improved before it goes live.

@Pginer-WMF I understand that since the information for both MT abuse warnings and errors is available inside Preview Translation screen, we want to display MT warnings/errors immediately to the user (inside the review info section). Warnings can be suppressed (by clicking the check icon) so that user can be proceed with publishing but MT errors cannot be suppressed and will block publishing (unless user modifies translation to fix MT issues). Am I correct? Should the "Publish" button be disabled until user suppress MT warnings or fix MT issues?

Change 664295 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@master] SX publishing: Add MT validation before publishing

https://gerrit.wikimedia.org/r/664295

@Pginer-WMF I understand that since the information for both MT abuse warnings and errors is available inside Preview Translation screen, we want to display MT warnings/errors immediately to the user (inside the review info section). Warnings can be suppressed (by clicking the check icon) so that user can be proceed with publishing but MT errors cannot be suppressed and will block publishing (unless user modifies translation to fix MT issues). Am I correct? Should the "Publish" button be disabled until user suppress MT warnings or fix MT issues?

Here we surface two kids of issues:

  • Errors are shown in red and prevent publishing. We can show the publish button disabled.
  • Warnings are shown in yellow and publishing is still possible (the button must be active).

For MT we were following this: " show warnings when MT > 85% and block publishing when MT > 95%". Thus:

  • If the MT percentage is in the 85-95% range, we show a warning, but do not disable publishing.
  • If the MT percentage is in the 95-100% range, we show an error, and keep the publish button disabled.

The numbers (and ranges) should be consistent with the approach we used to represent MT in the cards for already translated sentences (T260128). I'd recommend reusing variables to make sure that future adjustments in the percentages keep the consistency.

If there are multiple issues, errors are shown first, since they explain why publishing is not possible.

A side note about disabling the publish button:
Disabling the button for errors makes sense, but we need to be very careful with the code to make sure there are no false positives. We have this kind of problems when trying to anticipate abuse filters in CX (some abuse filters such as "too short article" were triggered when applied to a paragraph), but that seems unlikely to happen for section translation since the preview represents the complete edit. But please, surface any possible false positive scenario you can think of.