Page MenuHomePhabricator

Adjust error message for the publish step
Closed, ResolvedPublic1 Estimated Story Points

Description

Errors and warnings can be shown in the Preview and publish step (T260134). These are shown in a message box and the spec indicates that a different message is used in each case:

Publish - Issues.png (768×1 px, 179 KB)

However, the initial implementation the errors use the same message as the warnings. This is confusing because the message claims that the user can still publish when that is not the case:

ErrorWarning
Screen Shot 2022-02-15 at 5.10.35 PM.png (695×400 px, 63 KB)
test.m.wikipedia.org_w_index.php_title=Special_ContentTranslation&from=en&to=bn&sx=true(iPhone SE).png (667×375 px, 112 KB)

The message for errors should be the following instead:

Your translation cannot be published: contains X% of unmodified text
Machine translation is only a starting point. Make sure your translation reads naturally in your language.

Event Timeline

Pginer-WMF triaged this task as Medium priority.Mar 1 2022, 11:29 AM
Pginer-WMF created this task.
Pginer-WMF moved this task from Backlog to Core workflow on the SectionTranslation board.
Pginer-WMF set the point value for this task to 1.Mar 9 2022, 8:26 AM
santhosh changed the task status from Open to In Progress.Mar 17 2022, 6:36 AM
santhosh claimed this task.

Change 771510 had a related patch set uploaded (by Santhosh; author: Santhosh):

[mediawiki/extensions/ContentTranslation@master] SX: Adjust error message for the publish step

https://gerrit.wikimedia.org/r/771510

I did a minor correction in the error message to avoid the phrase without subject. I hope this is ok.

Your translation cannot be published: contains X% of unmodified text

Your translation cannot be published: it contains X% of unmodified text

After the fix:

ErrorWarning
image.png (782×450 px, 58 KB)
image.png (782×450 px, 56 KB)

I did a minor correction in the error message to avoid the phrase without subject. I hope this is ok.

Your translation cannot be published: contains X% of unmodified text

Your translation cannot be published: it contains X% of unmodified text

The adjustment looks good to me. Thanks!

Change 771510 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] SX: Adjust error message for the publish step

https://gerrit.wikimedia.org/r/771510

Etonkovidova subscribed.

Checked in wmf.5 (Android, testwiki and cawiki).

Here are the three states for confirming publishing:

ErrorWarningSuccess
Screen Shot 2022-03-30 at 11.36.33 AM.png (1×746 px, 143 KB)
Screenshot_20220330-114514_Chrome.jpg (2×1 px, 342 KB)
Screenshot_20220330-114422_Chrome.jpg (2×1 px, 278 KB)

Moved to Pending input for QA for a quick review - if there are no follow-up actions, the task can be closed as Resolved:
Notes:
(1) "Learn more" link (<a class="sx-publisher__review-info__learn-more-anchor" href="#">Learn more</a>) re-starts the translation workflow - is it expected for now?
(2) the Confirm Publication box is narrower than in the mockup (in the task description) and the VE publish box:

Screen Shot 2022-03-30 at 12.01.13 PM.png (828×756 px, 194 KB)

(3) the Publish options button looks marooned and it's occupied the whole line.

I did a minor correction in the error message to avoid the phrase without subject. I hope this is ok.

Your translation cannot be published: contains X% of unmodified text

Your translation cannot be published: it contains X% of unmodified text

Based on the screenshots posted in T302791#7819708, the final message seems to use the form "contains 95% machine translation" instead of "contains 95% of machine translation". @santhosh, @ngkountas is this intentional or a typo?

Based on my non-native knowledge of English I think of two valid formulations, either "contains 95% of machine translation" or "is 95% unmodified machine translation". The current "contains 95% machine translation" does not read very natural to me. But feel free to correct me since I may be wrong.

(1) "Learn more" link (<a class="sx-publisher__review-info__learn-more-anchor" href="#">Learn more</a>) re-starts the translation workflow - is it expected for now?

I created a follow-up ticket (T305131) and will propose it for the next sprint since there is a risk of losing contents (and teaches not to access documentation links, which is not what we want).

(2) the Confirm Publication box is narrower than in the mockup (in the task description) and the VE publish box:

Screen Shot 2022-03-30 at 12.01.13 PM.png (828×756 px, 194 KB)

If you refer to the header on top, that should be captured already in T275375: Adjust publish header to be more consistent

(3) the Publish options button looks marooned and it's occupied the whole line.

The button is intended to occupy its own line. In this case due to the specific width of the device the text lines on top wrap much before they reach the end of the text area, generating an additional space above. I'll look into the spacing into more detail, but I think this can be left as is for now.

Change 776194 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@master] SX: Fix grammar issue in messages

https://gerrit.wikimedia.org/r/776194

I did a minor correction in the error message to avoid the phrase without subject. I hope this is ok.

Your translation cannot be published: contains X% of unmodified text

Your translation cannot be published: it contains X% of unmodified text

Based on the screenshots posted in T302791#7819708, the final message seems to use the form "contains 95% machine translation" instead of "contains 95% of machine translation". @santhosh, @ngkountas is this intentional or a typo?

Based on my non-native knowledge of English I think of two valid formulations, either "contains 95% of machine translation" or "is 95% unmodified machine translation". The current "contains 95% machine translation" does not read very natural to me. But feel free to correct me since I may be wrong.

This error wasn't intentional. Fixed in latest patch.

Change 776194 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] SX: Fix grammar issue in translation messages

https://gerrit.wikimedia.org/r/776194

Change 776470 had a related patch set uploaded (by Santhosh; author: Santhosh):

[mediawiki/extensions/ContentTranslation@master] CX3 Build 0.2.0+20220404

https://gerrit.wikimedia.org/r/776470

Change 776470 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] CX3 Build 0.2.0+20220404

https://gerrit.wikimedia.org/r/776470

Completed testing for this task.
The changes in the Error and Warning messages for unmodified texts are observed in the test server https://sx.wmflabs.org

SXServer Message modification ( Android and iOS)

See attached