Page MenuHomePhabricator

Make it possible to customize EchoHooks::getNewUserPreferenceOverrides per wiki or remove it entirely
Closed, ResolvedPublic

Description

It looks like Echo enforces certain notifications are always disabled for new users, regardless of wgDefaultUserOptions. French Wikipedia asked in T273787 for notification about reverted edits to be enabled for everyone, not just current accounts.

This means we should either make EchoHooks::getNewUserPreferenceOverrides an actual config variable, or remove it entirely (it might've been part of some experiment?)

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

I'm not sure whether to remove it or move to config. For instance, enabling email notifications for thanks or mentions seems reasonable (and we probably don't want to enable that for everyone, even for accounts that are here for decades). But reverts are probably important to know about too, so you can communicate with the reverting user (if they didn't approach you directly) and don't just have to wonder "why are my edits gone now".

I'm not sure whether to remove it or move to config

Moving to config probably seems safer, in case some wiki wants to override it.