Page MenuHomePhabricator

Remove 6 deprecated ResourceLoader skin modules in core
Closed, ResolvedPublic2 Estimated Story Points

Description

Various skin modules have been deprecated over the years and it's time to finally remove them! This will reduce the amount of ResourceLoader modules in the startup manifest.

  • ''Remove mediawiki.skinning.elements''

Overclocked skin which is unstable is the only user (https://codesearch.wmcloud.org/search/?q=%5B%22%27%5Dmediawiki.skinning.elements&i=nope&files=&excludeFiles=&repos=)

  • Remove mediawiki.skinning.content, no usages
  • Remove mediawiki.toc.styles, deprecated in 1.37, used by Cargo. Will degrade gracefully without breaking as the table of content styles are currently double loaded there.
  • Remove mediawiki.legacy.config deprecated in 1.37, no users
  • Remove mediawiki.legacy.shared deprecated in 1.37, 1 potential user in Chameleon, no changes necessary.
  • Remove mediawiki.legacy.commonPrint

Tracked separately

Remove mediawiki.skinning.content.externallinks will be tracked in T269626. Being used by various skins but hardly a breaking change. These skins will lose external icons and fixed where important.

Acceptance criteria

  • Remove the module definitions in Resources.php
  • Remove any assets relating exclusively to these modules
  • Update the RELEASE NOTES file, listing these modules being removed under breaking changes.

Event Timeline

Jdlrobson added a project: MW-1.39-release.
Jdlrobson renamed this task from Remove 7 deprecated ResourceLoader skin modules in core to Remove 6 deprecated ResourceLoader skin modules in core.May 16 2022, 5:09 PM
Jdlrobson updated the task description. (Show Details)

Change 802576 had a related patch set uploaded (by Mabualruz; author: Mabualruz):

[mediawiki/core@master] Remove 6 deprecated ResourceLoader skin modules in core

https://gerrit.wikimedia.org/r/802576

Change 802577 had a related patch set uploaded (by Mabualruz; author: Mabualruz):

[mediawiki/extensions/Cargo@master] Remove 6 deprecated ResourceLoader skin modules in core

https://gerrit.wikimedia.org/r/802577

Change 802578 had a related patch set uploaded (by Mabualruz; author: Mabualruz):

[operations/mediawiki-config@master] Remove 6 deprecated ResourceLoader skin modules in core

https://gerrit.wikimedia.org/r/802578

Mabualruz added a subscriber: Mabualruz.

Change 802577 merged by jenkins-bot:

[mediawiki/extensions/Cargo@master] Remove 6 deprecated ResourceLoader skin modules in core

https://gerrit.wikimedia.org/r/802577

Change 802576 merged by jenkins-bot:

[mediawiki/core@master] Remove 6 deprecated ResourceLoader skin modules in core

https://gerrit.wikimedia.org/r/802576

Change 802759 had a related patch set uploaded (by Mabualruz; author: Mabualruz):

[mediawiki/core@master] Remove 6 deprecated ResourceLoader skin modules in core PT2

https://gerrit.wikimedia.org/r/802759

Change 802759 merged by jenkins-bot:

[mediawiki/core@master] Remove 6 deprecated ResourceLoader skin modules in core PT2

https://gerrit.wikimedia.org/r/802759

Change 802578 abandoned by Mabualruz:

[operations/mediawiki-config@master] Remove 6 deprecated ResourceLoader skin modules in core

Reason:

https://gerrit.wikimedia.org/r/802578