TypeError: Argument 3 passed to GrowthExperiments\NewcomerTasks\TemplateBasedTaskSubmissionHandler must be of the type integer
Closed, DuplicatePublicPRODUCTION ERROR
Actions

Assigned To

Authored By

	Etonkovidova
	Apr 5 2022, 12:23 AM

Description

Error

mwversion: 1.39.0-wmf.5
reqId: 0f99889d-3320-429c-bb41-55cdc023a789
Find reqId in Logstash
url: https://de.wikipedia.org/w/api.php

normalized_message

[{reqId}] {exception_url}   TypeError: Argument 3 passed to GrowthExperiments\NewcomerTasks\TemplateBasedTaskSubmissionHandler::validate() must be of the type integer, null given, called in /srv/mediawiki/php-1.39.0-wmf.5/extensions/GrowthExperiments/incl

exception.trace

from /srv/mediawiki/php-1.39.0-wmf.5/extensions/GrowthExperiments/includes/NewcomerTasks/TemplateBasedTaskSubmissionHandler.php(19)
#0 /srv/mediawiki/php-1.39.0-wmf.5/extensions/GrowthExperiments/includes/VisualEditorHooks.php(88): GrowthExperiments\NewcomerTasks\TemplateBasedTaskSubmissionHandler->validate(MediaWiki\Page\PageIdentityValue, User, NULL, array)
#1 /srv/mediawiki/php-1.39.0-wmf.5/includes/HookContainer/HookContainer.php(160): GrowthExperiments\VisualEditorHooks->onVisualEditorApiVisualEditorEditPreSave(MediaWiki\Page\PageIdentityValue, User, string, array, array, array)
#2 /srv/mediawiki/php-1.39.0-wmf.5/extensions/VisualEditor/includes/VisualEditorHookRunner.php(54): MediaWiki\HookContainer\HookContainer->run(string, array, array)
#3 /srv/mediawiki/php-1.39.0-wmf.5/extensions/VisualEditor/includes/ApiVisualEditorEdit.php(444): MediaWiki\Extension\VisualEditor\VisualEditorHookRunner->onVisualEditorApiVisualEditorEditPreSave(MediaWiki\Page\PageIdentityValue, User, string, array, array, array)
#4 /srv/mediawiki/php-1.39.0-wmf.5/includes/api/ApiMain.php(1897): MediaWiki\Extension\VisualEditor\ApiVisualEditorEdit->execute()
#5 /srv/mediawiki/php-1.39.0-wmf.5/includes/api/ApiMain.php(871): ApiMain->executeAction()
#6 /srv/mediawiki/php-1.39.0-wmf.5/includes/api/ApiMain.php(842): ApiMain->executeActionWithErrorHandling()
#7 /srv/mediawiki/php-1.39.0-wmf.5/api.php(90): ApiMain->execute()
#8 /srv/mediawiki/php-1.39.0-wmf.5/api.php(45): wfApiMain()
#9 /srv/mediawiki/w/api.php(3): require(string)
#10 {main}

Impact

Two errors during 24 hours

Details

Request URL: https://de.wikipedia.org/w/api.php

	Subject	Repo	Branch	Lines +/-
	Pass fallback baseRevId to SubmissionHandler::handle and SubmissionHandler::validate	mediawiki/extensions/GrowthExperiments	master	+2 -2

Customize query in gerrit

Related Objects

Mentioned Here: T297004: Rework how we track newcomer task edits

Event Timeline

Etonkovidova created this task.Apr 5 2022, 12:23 AM

Restricted Application added a project: Growth-Team. · View Herald TranscriptApr 5 2022, 12:23 AM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Fallout from T297004: Rework how we track newcomer task edits, let's fix it.

kostajh triaged this task as Medium priority.Apr 6 2022, 10:46 AM

kostajh moved this task from Incoming to Ready for Development on the Growth-Team (Sprint 0 (Growth Team)) board.

Krinkle moved this task from Untriaged to Apr 2022 on the Wikimedia-production-error board.Apr 14 2022, 3:18 PM

• mewoph claimed this task.May 2 2022, 8:48 PM

• mewoph moved this task from Ready for Development to In Progress on the Growth-Team (Sprint 0 (Growth Team)) board.

Change 788434 had a related patch set uploaded (by MewOphaswongse; author: MewOphaswongse):

[mediawiki/extensions/GrowthExperiments@master] Pass fallback baseRevId to SubmissionHandler::handle and SubmissionHandler::validate

https://gerrit.wikimedia.org/r/788434

gerritbot added a project: Patch-For-Review.May 2 2022, 10:27 PM

• mewoph moved this task from In Progress to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.May 2 2022, 10:33 PM

Change 788434 abandoned by MewOphaswongse:

[mediawiki/extensions/GrowthExperiments@master] Pass fallback baseRevId to SubmissionHandler::handle and SubmissionHandler::validate

Reason:

The error only occurred on Apr 6 and hasn't occurred since.

https://gerrit.wikimedia.org/r/788434

Declining as the error only occurred on April 6 and hasn't occurred since

• mewoph closed this task as a duplicate of T309120: TypeError: Argument 3 passed to GrowthExperiments\NewcomerTasks\TemplateBasedTaskSubmissionHandler::validate() must be of the type integer, null given.May 26 2022, 10:19 PM

Maintenance_bot removed a project: Patch-For-Review.May 26 2022, 10:30 PM

TypeError: Argument 3 passed to GrowthExperiments\NewcomerTasks\TemplateBasedTaskSubmissionHandler must be of the type integerClosed, DuplicatePublicPRODUCTION ERRORActions