Page MenuHomePhabricator
Create Task
Maniphest T306609

[PageTools] Set up feature flag for page tools menu
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

NOTE: No blockers for this work

Background

Prior to beginning the work on the page tools menu, we would like to set up a feature flag to ensure that the feature is not seen in production

Acceptance criteria

  • Set up feature flag for page tools menu and corresponding url parameter

Details

SubjectRepoBranchLines +/-
Add Article Tools feature flagmediawiki/skins/Vectormaster+42 -0
Add article tools menu feature flagmediawiki/skins/Vectormaster+53 -0
Define feature classes with FeatureManagermediawiki/skins/Vectormaster+64 -13
Customize query in gerrit

Related Objects
Search...

Event Timeline

ovasileva created this task.Apr 21 2022, 11:44 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 21 2022, 11:44 AM
ovasileva triaged this task as High priority.Apr 21 2022, 11:44 AM
ovasileva added a parent task: T302073: [GOAL] Page Tools available on all wikis.
Jdlrobson moved this task from Needs Analysis to Upcoming on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.Apr 25 2022, 5:49 PM
LGoto moved this task from Incoming to Page Tools on the Desktop Improvements (Vector 2022) board.May 16 2022, 5:32 PM
LGoto set the point value for this task to 2.
LGoto moved this task from Upcoming to Ready for Development on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.
bwang moved this task from Ready for Development to Doing on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.Jun 1 2022, 7:11 PM
bwang claimed this task.Jun 1 2022, 7:13 PM
gerritbot added a comment.Jun 1 2022, 8:48 PM

Change 802197 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):

[mediawiki/skins/Vector@master] Add article tools menu feature flag

https://gerrit.wikimedia.org/r/802197

gerritbot added a project: Patch-For-Review.Jun 1 2022, 8:48 PM
gerritbot added a comment.Jun 1 2022, 9:10 PM

Change 802200 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):

[mediawiki/skins/Vector@master] Define feature classes with FeatureManager

https://gerrit.wikimedia.org/r/802200

bwang removed bwang as the assignee of this task.Jun 1 2022, 9:26 PM
bwang moved this task from Doing to Code Review on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.
bwang subscribed.
Jdlrobson moved this task from Code Review to Needs More Work on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.Jun 1 2022, 10:29 PM
Jdlrobson moved this task from Needs More Work to Blocked on Others on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.Jun 2 2022, 3:52 PM
Jdlrobson added a comment.Jun 2 2022, 3:55 PM

I'm moving this to blocked for now, as I'm realizing we now have several feature flags that have implications on layout and it's becoming really difficult to reason with either of them. Adding another at this point seems risky, so I'd suggest before adding this one we remove at least one of the following:
$wgVectorTableOfContents, $wgVectorGrid, $wgVectorTitleAboveTabs, $wgVectorStickyHeader

gerritbot added a comment.Jun 2 2022, 4:44 PM

Change 802200 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):

[mediawiki/skins/Vector@master] Define feature classes with FeatureManager

https://gerrit.wikimedia.org/r/802200

bwang moved this task from Blocked on Others to Code Review on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.Jun 2 2022, 5:05 PM
bwang moved this task from Code Review to Blocked on Others on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.
Jdlrobson claimed this task.Jun 7 2022, 5:14 PM
Jdlrobson moved this task from Blocked on Others to Doing on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.Jun 23 2022, 6:26 PM
Jdlrobson moved this task from Doing to Code Review on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.Jun 24 2022, 3:52 PM

Looking to merge this sometime next week.

We should capture https://gerrit.wikimedia.org/r/802200 in a separate ticket as that seems like super useful functionality but is not as high a priority.

Jdlrobson moved this task from Code Review to Blocked on Others on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.Jun 27 2022, 11:09 PM
ovasileva edited projects, added Web-Team-Backlog; removed Web-Team-Backlog (Kanbanana-FY-2021-22).Jun 29 2022, 3:47 PM
Jdlrobson added a comment.Jun 29 2022, 4:10 PM

After chatting to Olga we decided to put this back in the backlog for now until the grid and table of contents work is completed.

Jdlrobson moved this task from Incoming to Not ready to estimate on the Web-Team-Backlog board.Jun 29 2022, 4:11 PM
gerritbot added a comment.Jul 15 2022, 4:01 PM

Change 802197 abandoned by Bernard Wang:

[mediawiki/skins/Vector@master] Add article tools menu feature flag

Reason:

https://gerrit.wikimedia.org/r/802197

ovasileva moved this task from Not ready to estimate to Current Fiscal Year on the Web-Team-Backlog board.Jul 25 2022, 9:43 AM
gerritbot added a comment.Sep 2 2022, 3:28 PM

Change 802200 abandoned by Jdlrobson:

[mediawiki/skins/Vector@master] Define feature classes with FeatureManager

Reason:

Done in https://gerrit.wikimedia.org/r/c/mediawiki/skins/Vector/+/829041

https://gerrit.wikimedia.org/r/802200

Jdlrobson moved this task from Current Fiscal Year to Not ready to estimate on the Web-Team-Backlog board.Sep 15 2022, 3:49 PM
Jdlrobson mentioned this in T317897: [L] [Page Tools] Make the page tools menu pinnable.Sep 15 2022, 3:59 PM
Jdlrobson mentioned this in T317898: [M] [PageTools] Restructure page tools menu contents.Sep 15 2022, 4:05 PM
Jdlrobson renamed this task from Set up feature flag for article tools menu to [ArticleTools] Set up feature flag for article tools menu.Sep 15 2022, 4:11 PM
Jdlrobson mentioned this in T317899: [L] [PageTools] Convert main menu into a dropdown menu.
Jdlrobson updated the task description. (Show Details)
ovasileva edited projects, added Web-Team-Backlog (Kanbanana-2022-23-Q1); removed Web-Team-Backlog.Sep 19 2022, 8:55 AM
Jdlrobson moved this task from Needs Analysis to Upcoming on the Web-Team-Backlog (Kanbanana-2022-23-Q1) board.Sep 19 2022, 3:23 PM
Jdlrobson lowered the priority of this task from High to Low.Sep 19 2022, 5:29 PM
Jdlrobson removed Jdlrobson as the assignee of this task.Sep 19 2022, 5:52 PM
Jdlrobson moved this task from Upcoming to Ready for Development on the Web-Team-Backlog (Kanbanana-2022-23-Q1) board.

(these have previously been estimated)

gerritbot added a comment.Sep 23 2022, 5:08 PM

Change 802197 restored by Jdlrobson:

[mediawiki/skins/Vector@master] Add article tools menu feature flag

https://gerrit.wikimedia.org/r/802197

Jdlrobson mentioned this in T318434: PageTools: Move toolbox from main menu to page tools menu.Sep 23 2022, 5:18 PM
bwang claimed this task.Sep 28 2022, 4:43 PM
bwang moved this task from Ready for Development to Doing on the Web-Team-Backlog (Kanbanana-2022-23-Q1) board.
gerritbot added a comment.Sep 28 2022, 5:54 PM

Change 802197 abandoned by Bernard Wang:

[mediawiki/skins/Vector@master] Add article tools menu feature flag

Reason:

https://gerrit.wikimedia.org/r/802197

bwang moved this task from Doing to Code Review on the Web-Team-Backlog (Kanbanana-2022-23-Q1) board.Sep 28 2022, 5:54 PM
gerritbot added a comment.Sep 28 2022, 5:54 PM

Change 836262 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):

[mediawiki/skins/Vector@master] Add Article Tools feature flag

https://gerrit.wikimedia.org/r/836262

bwang removed bwang as the assignee of this task.Sep 28 2022, 5:56 PM
gerritbot added a comment.Sep 28 2022, 7:31 PM

Change 836262 had a related patch set uploaded (by Jdlrobson; author: Bernard Wang):

[mediawiki/skins/Vector@master] Add Article Tools feature flag

https://gerrit.wikimedia.org/r/836262

Jdlrobson moved this task from Code Review to Ready for Signoff on the Web-Team-Backlog (Kanbanana-2022-23-Q1) board.Sep 28 2022, 9:55 PM
gerritbot added a comment.Sep 28 2022, 10:15 PM

Change 836262 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Add Article Tools feature flag

https://gerrit.wikimedia.org/r/836262

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.4; 2022-10-03).Sep 28 2022, 11:00 PM
LGoto assigned this task to Jdrewniak.Sep 29 2022, 5:07 PM
Jdrewniak closed this task as Resolved.Sep 30 2022, 3:52 PM
• alexhollender_WMF renamed this task from [ArticleTools] Set up feature flag for article tools menu to [PageTools] Set up feature flag for article tools menu.Oct 25 2022, 7:20 PM
• alexhollender_WMF renamed this task from [PageTools] Set up feature flag for article tools menu to [PageTools] Set up feature flag for page tools menu.Oct 25 2022, 7:25 PM
• alexhollender_WMF updated the task description. (Show Details)
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits