Page MenuHomePhabricator

Set up feature flag for article tools menu
Open, HighPublic2 Estimated Story Points

Description

Background

Prior to beginning the work on the article tools menu, we would like to set up a feature flag to ensure that the feature is not seen in production

Acceptance criteria

  • Set up feature flag for article tools menu and corresponding url parameter

Related Objects

StatusSubtypeAssignedTask
OpenNone
OpenJdlrobson

Event Timeline

LGoto set the point value for this task to 2.

Change 802197 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):

[mediawiki/skins/Vector@master] Add article tools menu feature flag

https://gerrit.wikimedia.org/r/802197

Change 802200 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):

[mediawiki/skins/Vector@master] Define feature classes with FeatureManager

https://gerrit.wikimedia.org/r/802200

bwang removed bwang as the assignee of this task.Wed, Jun 1, 9:26 PM
bwang added a subscriber: bwang.

I'm moving this to blocked for now, as I'm realizing we now have several feature flags that have implications on layout and it's becoming really difficult to reason with either of them. Adding another at this point seems risky, so I'd suggest before adding this one we remove at least one of the following:
$wgVectorTableOfContents, $wgVectorGrid, $wgVectorTitleAboveTabs, $wgVectorStickyHeader

Change 802200 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):

[mediawiki/skins/Vector@master] Define feature classes with FeatureManager

https://gerrit.wikimedia.org/r/802200

Looking to merge this sometime next week.

We should capture https://gerrit.wikimedia.org/r/802200 in a separate ticket as that seems like super useful functionality but is not as high a priority.

After chatting to Olga we decided to put this back in the backlog for now until the grid and table of contents work is completed.