I flagged this a while ago. The banner replaces the heading element that we use to trigger the sticky header. If we are to fix this, we'd likely want to make a change inside Wikidata-Page-Banner to make sure the heading there is marked up consistently so that Vector's code picks it up.

Change 802825 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):

[mediawiki/extensions/WikidataPageBanner@master] Add #firstHeading id to banner template

https://gerrit.wikimedia.org/r/802825

Change 802825 merged by jenkins-bot:

[mediawiki/extensions/WikidataPageBanner@master] Add #firstHeading id to banner template

https://gerrit.wikimedia.org/r/802825

I'm still investigating why the sticky header isnt showing. For the first link in the description (https://eu.wikipedia.org/wiki/Txikipedia:Munduko_zazpi_mirariak) I believe its because the sticky header isnt available in that namespace 104. For the second, (https://eu.wikipedia.org/wiki/Atari:Hezkuntza/Lehiaketak/2022/04) I havent found any obvious reason why its not working. I probably have to setup page banners locally to reproduce and debug.

Edit: Ok I figured it out, my previous patch didnt work because the original #firstHeading element was just hidden with CSS, when it really needs to be removed so that there is a unique element to query for for the sticky intersection element

https://eu.wikipedia.org/wiki/Atari:Hezkuntza/Lehiaketak/2022/04 is namespace 100.
https://eu.wikipedia.org/wiki/Txikipedia:Munduko_zazpi_mirariak is namespace 104.

@bwang is correct that the sticky header is not enabled on either of these namespaces:
https://gerrit.wikimedia.org/g/mediawiki/skins/Vector/+/615181154cf668a54220b18e77b994d4d64668b1/resources/skins.vector.es6/stickyHeader.js#467
.

In T306744#8042604, @Jdlrobson wrote:

https://eu.wikipedia.org/wiki/Atari:Hezkuntza/Lehiaketak/2022/04 is namespace 100.
https://eu.wikipedia.org/wiki/Txikipedia:Munduko_zazpi_mirariak is namespace 104.

@bwang is correct that the sticky header is not enabled on either of these namespaces:
https://gerrit.wikimedia.org/g/mediawiki/skins/Vector/+/615181154cf668a54220b18e77b994d4d64668b1/resources/skins.vector.es6/stickyHeader.js#467
.

I think this is okay? I'm not entirely sure what the atari namespace is. For Txikipedia - I suppose it would make sense to have the header appear here for consistency with the main namespace. On the other hand, few of the articles here are long enough to make it particularly useful (by design). @Theklan - any thoughts on this one?

Atari is Portal. Is NS 100, and it's used in all Wikimedia projects. Totally related: T303258, where I explain why portals should be also considered by the design team.

I think that for consistency the sticky header should be shown in any page, regardless of the ns.

Change 807219 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):

[mediawiki/skins/Vector@master] WIP: Add collapsed TOC to sticky header

https://gerrit.wikimedia.org/r/807219

I tagged the wrong task, pls ignore the patch above

It seems like this issue is still present. To summarize my understanding, there was a patch merged into PageBanner, but it didn't actually fix the issue. From @bwang's comment on that patch:

After some more investigating, there are two issues that need to be fixed for this task to work.

1. Ensure stickyHeader.js can query for a unique "heading" element on pages with page banners. Either by updating the selector used in Vector to be a class, or by adding code to the page banner extension that removes the original h1 element.
2. The template data for the title is empty when page banner is used, still unsure if that's something that can be updated in page banner extension or can be handled in Vector.

Additionally, the stickyHeader namespace logic is handled client-side with this this line

const allowedNamespaceNumbers = [ 0, 2, 4, 10, 12, 14, 100, 828 ];

which doesn't include namespace 104, for pages like: https://eu.wikipedia.org/wiki/Txikipedia:Munduko_zazpi_mirariak.

Could someone please give higher priority at fixing this? Banners are widely used on Wikivoyage, and all projects are soon going to be switched to the new Vector skin.

Vector's sticky header seems to work by cloning or parsing the DOM element of the article title, identified by its id ("firstHeader"). This extension blanks the title before the page is rendered and adds another element with the same ID, so in the output page there are two elements with the same ID, the first of which is empty. Instead of blanking the page title, the extension should somehow delete the first element with that ID, or avoid re-using the ID and use CSS to hide the title element when it's in the page header and not the sticky header.

I am not familiar with MW's internals, so the only possible quick-and-dirty fix that I could think of is to have the extension also inject a JS that deletes the first encounter with a "firstHeader" element on page load. I managed to test this partially by adding the following to vector-2022.js in my userspace:

$('#firstHeading').remove();

As a result, the sticky header started showing up, but with the page name blank.

Edited to add: further investigation shows that perhaps the best way to fix that is to avoid blanking the page title. (https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/WikidataPageBanner/+/refs/heads/master/includes/Banner.php#381) and use solely CSS. The code in that conditional block can be replaced with e.g. loading a separate CSS file that hides the title.

@ovasileva perhaps this bug fix could be aligned with future Vector 2022 deploys?

Change #1088372 had a related patch set uploaded (by Bmarinov; author: Bmarinov):

[mediawiki/extensions/WikidataPageBanner@master] hide the original title with CSS instead of blanking

https://gerrit.wikimedia.org/r/1088372

Thanks for the patch! adding this to our next sprint to make sure we look at it!

the pinning does not behave correctly either:

I took a look at https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikidataPageBanner/+/1088372 but there are a few problems with that patch.

I've applied a local fix for now:
https://en.wikivoyage.org/wiki/MediaWiki:Vector-2022.css#L-17
I think this should be upstreamed to WikidataPageBanner and Vector 2022.

The sticky header works with this fix, but doesn't have the title. I think this is appropriately fixed by sourcing the title in Vector via a stable JavaScript function in the mediawiki.util library.

@Daggerstab are you still working on this ticket? There is some feedback on the Gerrit patch.

Change #1088372 abandoned by Jdlrobson:

[mediawiki/extensions/WikidataPageBanner@master] hide the original title with CSS instead of blanking

Reason:

@Bmarinov I'm abandoning this patch since there have been no updates in over 3 months, but feel free to restore this if you want to continue! Thanks again for giving this a go!

https://gerrit.wikimedia.org/r/1088372