Page MenuHomePhabricator

Add VueUse within the codex repository
Closed, DeclinedPublic

Description

After the Frontend standards meeting held on april the 28th and recorded here, it was decided to use the VueUse package as a possible source of "composables" to be use during development of Vue applications.

Codex was chosen as the first repository to use this package due to its build step and ability to treeshake the application and for its increased needs in composable due to development of new components and the use of Vue 3.


Acceptance criteria
  • Add VueUse within the codex repository
  • Swap out existing composables with VueUse equivalent (where possible)
  • Document this in the contributing code docs
  • Asses the impact of using this library and share feedback with the rest of the Frotnend team for future discussion and adoption

Event Timeline

Some composables from vueUse that we might use:

  • useEventListener to replace the manual event listener logic in Menu for mouseup (not factored into a composable yet in Codex because its only used in that one place)
  • useIntersectionObserver to replace our own composable by the same name
  • useVModel which appears to do the same as our useModelWrapper composable
AnneT renamed this task from Add vueUse within the codex repository to Add VueUse within the codex repository.Aug 18 2022, 4:33 PM
AnneT updated the task description. (Show Details)
ldelench_wmf moved this task from Inbox to Needs Refinement on the Design-System-Team board.
egardner subscribed.

I'm closing this task as declined for now, since it's been ~8 months but we still have not seen fit to introduce this dependency.

Feel free to re-open if you still want to make the case for including it.